[PATCH] irqchip/wpcm450: Drop COMPILE_TEST

[PATCH] irqchip/wpcm450: Drop COMPILE_TEST

[Marc Zyngier]

This driver is (for now) ARM specific, and currently doesn't
build with a variety of architectures (ia64, RISC-V, x86_64
at the very least).

Drop COMPILE_TEST from Kconfig until it gets sorted out.

Cc: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 38ad9dcf42c3..715eb4366e35 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -579,7 +579,7 @@ config MST_IRQ
 
 config WPCM450_AIC
 	bool "Nuvoton WPCM450 Advanced Interrupt Controller"
-	depends on ARCH_WPCM450 || COMPILE_TEST
+	depends on ARCH_WPCM450
 	help
 	  Support for the interrupt controller in the Nuvoton WPCM450 BMC SoC.
 
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] irqchip/wpcm450: Drop COMPILE_TEST

[Jonathan Neuschäfer]

[-- Attachment #1.1: Type: text/plain, Size: 1053 bytes --]

On Thu, Apr 08, 2021 at 09:00:30AM +0100, Marc Zyngier wrote:
> This driver is (for now) ARM specific, and currently doesn't
> build with a variety of architectures (ia64, RISC-V, x86_64
> at the very least).
> 
> Drop COMPILE_TEST from Kconfig until it gets sorted out.
> 
> Cc: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---

Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

>  drivers/irqchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 38ad9dcf42c3..715eb4366e35 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -579,7 +579,7 @@ config MST_IRQ
>  
>  config WPCM450_AIC
>  	bool "Nuvoton WPCM450 Advanced Interrupt Controller"
> -	depends on ARCH_WPCM450 || COMPILE_TEST
> +	depends on ARCH_WPCM450

I guess I could use (COMPILE_TEST && ARM) or something…


Thanks,
Jonathan

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] irqchip/wpcm450: Drop COMPILE_TEST

[Marc Zyngier]

On 2021-04-08 09:45, Jonathan Neuschäfer wrote:
> On Thu, Apr 08, 2021 at 09:00:30AM +0100, Marc Zyngier wrote:
>> This driver is (for now) ARM specific, and currently doesn't
>> build with a variety of architectures (ia64, RISC-V, x86_64
>> at the very least).
>> 
>> Drop COMPILE_TEST from Kconfig until it gets sorted out.
>> 
>> Cc: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Signed-off-by: Marc Zyngier <maz@kernel.org>
>> ---
> 
> Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Thanks for that.

> 
>>  drivers/irqchip/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 38ad9dcf42c3..715eb4366e35 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -579,7 +579,7 @@ config MST_IRQ
>> 
>>  config WPCM450_AIC
>>  	bool "Nuvoton WPCM450 Advanced Interrupt Controller"
>> -	depends on ARCH_WPCM450 || COMPILE_TEST
>> +	depends on ARCH_WPCM450
> 
> I guess I could use (COMPILE_TEST && ARM) or something…

One of the major interest of COMPILE_TEST to be able to check code
cross-architecture. For code that cannot compile cross-architecture,
I'm not sure it matters much.

We can achieve the same result by enabling multi-platform builds (and
this system should probably end-up in multi_v5_defconfig).

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] irqchip/wpcm450: Drop COMPILE_TEST

[Jonathan Neuschäfer]

[-- Attachment #1.1: Type: text/plain, Size: 557 bytes --]

On Thu, Apr 08, 2021 at 11:43:19AM +0100, Marc Zyngier wrote:
> On 2021-04-08 09:45, Jonathan Neuschäfer wrote:
[...]
> > I guess I could use (COMPILE_TEST && ARM) or something…
> 
> One of the major interest of COMPILE_TEST to be able to check code
> cross-architecture. For code that cannot compile cross-architecture,
> I'm not sure it matters much.
> 
> We can achieve the same result by enabling multi-platform builds (and
> this system should probably end-up in multi_v5_defconfig).

Alright, thanks for the explanation.


Jonathan

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel