* [PATCH v4 0/2] i2c: stm32f7: add SMBus-Alert support @ 2021-05-05 13:14 Alain Volmat 2021-05-05 13:14 ` [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert Alain Volmat 2021-05-05 13:14 ` [PATCH v4 2/2] i2c: stm32f7: add SMBus-Alert support Alain Volmat 0 siblings, 2 replies; 8+ messages in thread From: Alain Volmat @ 2021-05-05 13:14 UTC (permalink / raw) To: wsa, robh+dt Cc: mark.rutland, pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue, linux-i2c, devicetree, linux-stm32, linux-arm-kernel, linux-kernel, fabrice.gasnier, alain.volmat This serie adds support for SMBus Alert on the STM32F7. A new binding smbus-alert is added in order to differenciate with the existing smbus binding. SMBus-Alert is an optional SMBus feature and SMBA alert control and status logic must be enabled along with SMBALERT# pin configured via pinctrl in the device tree. This is the rational for adding "smbus-alert" property. --- v4: add a new generic smbus-alert property instead of st,smbus-alert update driver to use smbus-alert instead of st,smbus-alert v3: use lore.kernel.org links instead of marc.info v2: When SMBUS alert isn't available on the board (SMBA unused), this logic musn't be enabled. Enabling it unconditionally wrongly lead to get SMBA interrupts. So, add "st,smbus-alert" dedicated binding to have a smbus alert with a consistent pin configuration in DT. Alain Volmat (2): i2c: add binding to mark a bus as supporting SMBus-Alert i2c: stm32f7: add SMBus-Alert support Documentation/devicetree/bindings/i2c/i2c.txt | 7 ++- drivers/i2c/busses/i2c-stm32f7.c | 73 +++++++++++++++++++++++++++ 2 files changed, 78 insertions(+), 2 deletions(-) -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert 2021-05-05 13:14 [PATCH v4 0/2] i2c: stm32f7: add SMBus-Alert support Alain Volmat @ 2021-05-05 13:14 ` Alain Volmat 2021-05-07 0:55 ` Rob Herring 2021-05-25 19:53 ` Wolfram Sang 2021-05-05 13:14 ` [PATCH v4 2/2] i2c: stm32f7: add SMBus-Alert support Alain Volmat 1 sibling, 2 replies; 8+ messages in thread From: Alain Volmat @ 2021-05-05 13:14 UTC (permalink / raw) To: wsa, robh+dt Cc: mark.rutland, pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue, linux-i2c, devicetree, linux-stm32, linux-arm-kernel, linux-kernel, fabrice.gasnier, alain.volmat Since SMBus-Alert is an optional feature of SMBUS which requires an additional pin, the smbus binding cannot be used to indicate its support. Add an additional smbus-alert binding specific for it and update the description text of smbus to avoid mentioning SMBus-Alert Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> --- Documentation/devicetree/bindings/i2c/i2c.txt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt index df41f72afc87..b864916e087f 100644 --- a/Documentation/devicetree/bindings/i2c/i2c.txt +++ b/Documentation/devicetree/bindings/i2c/i2c.txt @@ -89,8 +89,11 @@ wants to support one of the below features, it should adapt these bindings. - smbus states that additional SMBus restrictions and features apply to this bus. - Examples of features are SMBusHostNotify and SMBusAlert. Examples of - restrictions are more reserved addresses and timeout definitions. + An example of feature is SMBusHostNotify. Examples of restrictions are + more reserved addresses and timeout definitions. + +- smbus-alert + states that the optional SMBus-Alert feature apply to this bus. Required properties (per child device) -------------------------------------- -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert 2021-05-05 13:14 ` [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert Alain Volmat @ 2021-05-07 0:55 ` Rob Herring 2021-05-25 19:47 ` Wolfram Sang 2021-05-25 19:53 ` Wolfram Sang 1 sibling, 1 reply; 8+ messages in thread From: Rob Herring @ 2021-05-07 0:55 UTC (permalink / raw) To: Alain Volmat Cc: wsa, mark.rutland, pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue, linux-i2c, devicetree, linux-stm32, linux-arm-kernel, linux-kernel, fabrice.gasnier On Wed, May 05, 2021 at 03:14:38PM +0200, Alain Volmat wrote: > Since SMBus-Alert is an optional feature of SMBUS which > requires an additional pin, the smbus binding cannot be > used to indicate its support. > > Add an additional smbus-alert binding specific for it and > update the description text of smbus to avoid mentioning > SMBus-Alert > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > --- > Documentation/devicetree/bindings/i2c/i2c.txt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) This needs to be added to i2c-bus.yaml too. Acked-by: Rob Herring <robh@kernel.org> > > diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt > index df41f72afc87..b864916e087f 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c.txt > @@ -89,8 +89,11 @@ wants to support one of the below features, it should adapt these bindings. > > - smbus > states that additional SMBus restrictions and features apply to this bus. > - Examples of features are SMBusHostNotify and SMBusAlert. Examples of > - restrictions are more reserved addresses and timeout definitions. > + An example of feature is SMBusHostNotify. Examples of restrictions are > + more reserved addresses and timeout definitions. > + > +- smbus-alert > + states that the optional SMBus-Alert feature apply to this bus. > > Required properties (per child device) > -------------------------------------- > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert 2021-05-07 0:55 ` Rob Herring @ 2021-05-25 19:47 ` Wolfram Sang 0 siblings, 0 replies; 8+ messages in thread From: Wolfram Sang @ 2021-05-25 19:47 UTC (permalink / raw) To: Rob Herring Cc: Alain Volmat, mark.rutland, pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue, linux-i2c, devicetree, linux-stm32, linux-arm-kernel, linux-kernel, fabrice.gasnier [-- Attachment #1.1: Type: text/plain, Size: 97 bytes --] > This needs to be added to i2c-bus.yaml too. We don't have that yet? Am I missing something? [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert 2021-05-05 13:14 ` [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert Alain Volmat 2021-05-07 0:55 ` Rob Herring @ 2021-05-25 19:53 ` Wolfram Sang 1 sibling, 0 replies; 8+ messages in thread From: Wolfram Sang @ 2021-05-25 19:53 UTC (permalink / raw) To: Alain Volmat Cc: robh+dt, mark.rutland, pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue, linux-i2c, devicetree, linux-stm32, linux-arm-kernel, linux-kernel, fabrice.gasnier [-- Attachment #1.1: Type: text/plain, Size: 450 bytes --] On Wed, May 05, 2021 at 03:14:38PM +0200, Alain Volmat wrote: > Since SMBus-Alert is an optional feature of SMBUS which > requires an additional pin, the smbus binding cannot be > used to indicate its support. > > Add an additional smbus-alert binding specific for it and > update the description text of smbus to avoid mentioning > SMBus-Alert > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> Applied to for-next, thanks! [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v4 2/2] i2c: stm32f7: add SMBus-Alert support 2021-05-05 13:14 [PATCH v4 0/2] i2c: stm32f7: add SMBus-Alert support Alain Volmat 2021-05-05 13:14 ` [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert Alain Volmat @ 2021-05-05 13:14 ` Alain Volmat 2021-05-10 8:02 ` Pierre Yves MORDRET 2021-05-25 19:53 ` Wolfram Sang 1 sibling, 2 replies; 8+ messages in thread From: Alain Volmat @ 2021-05-05 13:14 UTC (permalink / raw) To: wsa, robh+dt Cc: mark.rutland, pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue, linux-i2c, devicetree, linux-stm32, linux-arm-kernel, linux-kernel, fabrice.gasnier, alain.volmat Add support for the SMBus-Alert protocol to the STM32F7 that has dedicated control and status logic. If SMBus-Alert is used, the SMBALERT# pin must be configured as alternate function for I2C Alert. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> --- v4: - check for smbus-alert property v2: - rely on st,smbus-alert binding instead of smbus --- drivers/i2c/busses/i2c-stm32f7.c | 73 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index 0138317ea600..b9b19a2a2ffa 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -51,6 +51,7 @@ /* STM32F7 I2C control 1 */ #define STM32F7_I2C_CR1_PECEN BIT(23) +#define STM32F7_I2C_CR1_ALERTEN BIT(22) #define STM32F7_I2C_CR1_SMBHEN BIT(20) #define STM32F7_I2C_CR1_WUPEN BIT(18) #define STM32F7_I2C_CR1_SBC BIT(16) @@ -125,6 +126,7 @@ (((n) & STM32F7_I2C_ISR_ADDCODE_MASK) >> 17) #define STM32F7_I2C_ISR_DIR BIT(16) #define STM32F7_I2C_ISR_BUSY BIT(15) +#define STM32F7_I2C_ISR_ALERT BIT(13) #define STM32F7_I2C_ISR_PECERR BIT(11) #define STM32F7_I2C_ISR_ARLO BIT(9) #define STM32F7_I2C_ISR_BERR BIT(8) @@ -138,6 +140,7 @@ #define STM32F7_I2C_ISR_TXE BIT(0) /* STM32F7 I2C Interrupt Clear */ +#define STM32F7_I2C_ICR_ALERTCF BIT(13) #define STM32F7_I2C_ICR_PECCF BIT(11) #define STM32F7_I2C_ICR_ARLOCF BIT(9) #define STM32F7_I2C_ICR_BERRCF BIT(8) @@ -279,6 +282,17 @@ struct stm32f7_i2c_msg { }; /** + * struct stm32f7_i2c_alert - SMBus alert specific data + * @setup: platform data for the smbus_alert i2c client + * @ara: I2C slave device used to respond to the SMBus Alert with Alert + * Response Address + */ +struct stm32f7_i2c_alert { + struct i2c_smbus_alert_setup setup; + struct i2c_client *ara; +}; + +/** * struct stm32f7_i2c_dev - private data of the controller * @adap: I2C adapter for this controller * @dev: device for this controller @@ -310,6 +324,7 @@ struct stm32f7_i2c_msg { * @analog_filter: boolean to indicate enabling of the analog filter * @dnf_dt: value of digital filter requested via dt * @dnf: value of digital filter to apply + * @alert: SMBus alert specific data */ struct stm32f7_i2c_dev { struct i2c_adapter adap; @@ -341,6 +356,7 @@ struct stm32f7_i2c_dev { bool analog_filter; u32 dnf_dt; u32 dnf; + struct stm32f7_i2c_alert *alert; }; /* @@ -1624,6 +1640,13 @@ static irqreturn_t stm32f7_i2c_isr_error(int irq, void *data) f7_msg->result = -EINVAL; } + if (status & STM32F7_I2C_ISR_ALERT) { + dev_dbg(dev, "<%s>: SMBus alert received\n", __func__); + writel_relaxed(STM32F7_I2C_ICR_ALERTCF, base + STM32F7_I2C_ICR); + i2c_handle_smbus_alert(i2c_dev->alert->ara); + return IRQ_HANDLED; + } + if (!i2c_dev->slave_running) { u32 mask; /* Disable interrupts */ @@ -1990,6 +2013,42 @@ static void stm32f7_i2c_disable_smbus_host(struct stm32f7_i2c_dev *i2c_dev) } } +static int stm32f7_i2c_enable_smbus_alert(struct stm32f7_i2c_dev *i2c_dev) +{ + struct stm32f7_i2c_alert *alert; + struct i2c_adapter *adap = &i2c_dev->adap; + struct device *dev = i2c_dev->dev; + void __iomem *base = i2c_dev->base; + + alert = devm_kzalloc(dev, sizeof(*alert), GFP_KERNEL); + if (!alert) + return -ENOMEM; + + alert->ara = i2c_new_smbus_alert_device(adap, &alert->setup); + if (IS_ERR(alert->ara)) + return PTR_ERR(alert->ara); + + i2c_dev->alert = alert; + + /* Enable SMBus Alert */ + stm32f7_i2c_set_bits(base + STM32F7_I2C_CR1, STM32F7_I2C_CR1_ALERTEN); + + return 0; +} + +static void stm32f7_i2c_disable_smbus_alert(struct stm32f7_i2c_dev *i2c_dev) +{ + struct stm32f7_i2c_alert *alert = i2c_dev->alert; + void __iomem *base = i2c_dev->base; + + if (alert) { + /* Disable SMBus Alert */ + stm32f7_i2c_clr_bits(base + STM32F7_I2C_CR1, + STM32F7_I2C_CR1_ALERTEN); + i2c_unregister_device(alert->ara); + } +} + static u32 stm32f7_i2c_func(struct i2c_adapter *adap) { struct stm32f7_i2c_dev *i2c_dev = i2c_get_adapdata(adap); @@ -2173,6 +2232,16 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) } } + if (of_property_read_bool(pdev->dev.of_node, "smbus-alert")) { + ret = stm32f7_i2c_enable_smbus_alert(i2c_dev); + if (ret) { + dev_err(i2c_dev->dev, + "failed to enable SMBus alert protocol (%d)\n", + ret); + goto i2c_disable_smbus_host; + } + } + dev_info(i2c_dev->dev, "STM32F7 I2C-%d bus adapter\n", adap->nr); pm_runtime_mark_last_busy(i2c_dev->dev); @@ -2180,6 +2249,9 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) return 0; +i2c_disable_smbus_host: + stm32f7_i2c_disable_smbus_host(i2c_dev); + i2c_adapter_remove: i2c_del_adapter(adap); @@ -2214,6 +2286,7 @@ static int stm32f7_i2c_remove(struct platform_device *pdev) { struct stm32f7_i2c_dev *i2c_dev = platform_get_drvdata(pdev); + stm32f7_i2c_disable_smbus_alert(i2c_dev); stm32f7_i2c_disable_smbus_host(i2c_dev); i2c_del_adapter(&i2c_dev->adap); -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] i2c: stm32f7: add SMBus-Alert support 2021-05-05 13:14 ` [PATCH v4 2/2] i2c: stm32f7: add SMBus-Alert support Alain Volmat @ 2021-05-10 8:02 ` Pierre Yves MORDRET 2021-05-25 19:53 ` Wolfram Sang 1 sibling, 0 replies; 8+ messages in thread From: Pierre Yves MORDRET @ 2021-05-10 8:02 UTC (permalink / raw) To: Alain Volmat, wsa, robh+dt Cc: mark.rutland, mcoquelin.stm32, alexandre.torgue, linux-i2c, devicetree, linux-stm32, linux-arm-kernel, linux-kernel, fabrice.gasnier Hi all Look good to me. I agree more generic Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@foss.st.com> Regards On 5/5/21 3:14 PM, Alain Volmat wrote: > Add support for the SMBus-Alert protocol to the STM32F7 that has > dedicated control and status logic. > > If SMBus-Alert is used, the SMBALERT# pin must be configured as alternate > function for I2C Alert. > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > --- > v4: - check for smbus-alert property > v2: - rely on st,smbus-alert binding instead of smbus > --- > drivers/i2c/busses/i2c-stm32f7.c | 73 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index 0138317ea600..b9b19a2a2ffa 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -51,6 +51,7 @@ > > /* STM32F7 I2C control 1 */ > #define STM32F7_I2C_CR1_PECEN BIT(23) > +#define STM32F7_I2C_CR1_ALERTEN BIT(22) > #define STM32F7_I2C_CR1_SMBHEN BIT(20) > #define STM32F7_I2C_CR1_WUPEN BIT(18) > #define STM32F7_I2C_CR1_SBC BIT(16) > @@ -125,6 +126,7 @@ > (((n) & STM32F7_I2C_ISR_ADDCODE_MASK) >> 17) > #define STM32F7_I2C_ISR_DIR BIT(16) > #define STM32F7_I2C_ISR_BUSY BIT(15) > +#define STM32F7_I2C_ISR_ALERT BIT(13) > #define STM32F7_I2C_ISR_PECERR BIT(11) > #define STM32F7_I2C_ISR_ARLO BIT(9) > #define STM32F7_I2C_ISR_BERR BIT(8) > @@ -138,6 +140,7 @@ > #define STM32F7_I2C_ISR_TXE BIT(0) > > /* STM32F7 I2C Interrupt Clear */ > +#define STM32F7_I2C_ICR_ALERTCF BIT(13) > #define STM32F7_I2C_ICR_PECCF BIT(11) > #define STM32F7_I2C_ICR_ARLOCF BIT(9) > #define STM32F7_I2C_ICR_BERRCF BIT(8) > @@ -279,6 +282,17 @@ struct stm32f7_i2c_msg { > }; > > /** > + * struct stm32f7_i2c_alert - SMBus alert specific data > + * @setup: platform data for the smbus_alert i2c client > + * @ara: I2C slave device used to respond to the SMBus Alert with Alert > + * Response Address > + */ > +struct stm32f7_i2c_alert { > + struct i2c_smbus_alert_setup setup; > + struct i2c_client *ara; > +}; > + > +/** > * struct stm32f7_i2c_dev - private data of the controller > * @adap: I2C adapter for this controller > * @dev: device for this controller > @@ -310,6 +324,7 @@ struct stm32f7_i2c_msg { > * @analog_filter: boolean to indicate enabling of the analog filter > * @dnf_dt: value of digital filter requested via dt > * @dnf: value of digital filter to apply > + * @alert: SMBus alert specific data > */ > struct stm32f7_i2c_dev { > struct i2c_adapter adap; > @@ -341,6 +356,7 @@ struct stm32f7_i2c_dev { > bool analog_filter; > u32 dnf_dt; > u32 dnf; > + struct stm32f7_i2c_alert *alert; > }; > > /* > @@ -1624,6 +1640,13 @@ static irqreturn_t stm32f7_i2c_isr_error(int irq, void *data) > f7_msg->result = -EINVAL; > } > > + if (status & STM32F7_I2C_ISR_ALERT) { > + dev_dbg(dev, "<%s>: SMBus alert received\n", __func__); > + writel_relaxed(STM32F7_I2C_ICR_ALERTCF, base + STM32F7_I2C_ICR); > + i2c_handle_smbus_alert(i2c_dev->alert->ara); > + return IRQ_HANDLED; > + } > + > if (!i2c_dev->slave_running) { > u32 mask; > /* Disable interrupts */ > @@ -1990,6 +2013,42 @@ static void stm32f7_i2c_disable_smbus_host(struct stm32f7_i2c_dev *i2c_dev) > } > } > > +static int stm32f7_i2c_enable_smbus_alert(struct stm32f7_i2c_dev *i2c_dev) > +{ > + struct stm32f7_i2c_alert *alert; > + struct i2c_adapter *adap = &i2c_dev->adap; > + struct device *dev = i2c_dev->dev; > + void __iomem *base = i2c_dev->base; > + > + alert = devm_kzalloc(dev, sizeof(*alert), GFP_KERNEL); > + if (!alert) > + return -ENOMEM; > + > + alert->ara = i2c_new_smbus_alert_device(adap, &alert->setup); > + if (IS_ERR(alert->ara)) > + return PTR_ERR(alert->ara); > + > + i2c_dev->alert = alert; > + > + /* Enable SMBus Alert */ > + stm32f7_i2c_set_bits(base + STM32F7_I2C_CR1, STM32F7_I2C_CR1_ALERTEN); > + > + return 0; > +} > + > +static void stm32f7_i2c_disable_smbus_alert(struct stm32f7_i2c_dev *i2c_dev) > +{ > + struct stm32f7_i2c_alert *alert = i2c_dev->alert; > + void __iomem *base = i2c_dev->base; > + > + if (alert) { > + /* Disable SMBus Alert */ > + stm32f7_i2c_clr_bits(base + STM32F7_I2C_CR1, > + STM32F7_I2C_CR1_ALERTEN); > + i2c_unregister_device(alert->ara); > + } > +} > + > static u32 stm32f7_i2c_func(struct i2c_adapter *adap) > { > struct stm32f7_i2c_dev *i2c_dev = i2c_get_adapdata(adap); > @@ -2173,6 +2232,16 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) > } > } > > + if (of_property_read_bool(pdev->dev.of_node, "smbus-alert")) { > + ret = stm32f7_i2c_enable_smbus_alert(i2c_dev); > + if (ret) { > + dev_err(i2c_dev->dev, > + "failed to enable SMBus alert protocol (%d)\n", > + ret); > + goto i2c_disable_smbus_host; > + } > + } > + > dev_info(i2c_dev->dev, "STM32F7 I2C-%d bus adapter\n", adap->nr); > > pm_runtime_mark_last_busy(i2c_dev->dev); > @@ -2180,6 +2249,9 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) > > return 0; > > +i2c_disable_smbus_host: > + stm32f7_i2c_disable_smbus_host(i2c_dev); > + > i2c_adapter_remove: > i2c_del_adapter(adap); > > @@ -2214,6 +2286,7 @@ static int stm32f7_i2c_remove(struct platform_device *pdev) > { > struct stm32f7_i2c_dev *i2c_dev = platform_get_drvdata(pdev); > > + stm32f7_i2c_disable_smbus_alert(i2c_dev); > stm32f7_i2c_disable_smbus_host(i2c_dev); > > i2c_del_adapter(&i2c_dev->adap); > -- -- ~ Py MORDRET -- _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] i2c: stm32f7: add SMBus-Alert support 2021-05-05 13:14 ` [PATCH v4 2/2] i2c: stm32f7: add SMBus-Alert support Alain Volmat 2021-05-10 8:02 ` Pierre Yves MORDRET @ 2021-05-25 19:53 ` Wolfram Sang 1 sibling, 0 replies; 8+ messages in thread From: Wolfram Sang @ 2021-05-25 19:53 UTC (permalink / raw) To: Alain Volmat Cc: robh+dt, mark.rutland, pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue, linux-i2c, devicetree, linux-stm32, linux-arm-kernel, linux-kernel, fabrice.gasnier [-- Attachment #1.1: Type: text/plain, Size: 374 bytes --] On Wed, May 05, 2021 at 03:14:39PM +0200, Alain Volmat wrote: > Add support for the SMBus-Alert protocol to the STM32F7 that has > dedicated control and status logic. > > If SMBus-Alert is used, the SMBALERT# pin must be configured as alternate > function for I2C Alert. > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> Applied to for-next, thanks! [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-05-25 20:02 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-05 13:14 [PATCH v4 0/2] i2c: stm32f7: add SMBus-Alert support Alain Volmat 2021-05-05 13:14 ` [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert Alain Volmat 2021-05-07 0:55 ` Rob Herring 2021-05-25 19:47 ` Wolfram Sang 2021-05-25 19:53 ` Wolfram Sang 2021-05-05 13:14 ` [PATCH v4 2/2] i2c: stm32f7: add SMBus-Alert support Alain Volmat 2021-05-10 8:02 ` Pierre Yves MORDRET 2021-05-25 19:53 ` Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).