* [RESEND PATCH] pinctrl: single: config: enable the pin's input
@ 2021-06-02 15:04 Dario Binacchi
2021-06-04 8:07 ` Tony Lindgren
2021-06-07 7:02 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Dario Binacchi @ 2021-06-02 15:04 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Haojian Zhuang, Linus Walleij, Tony Lindgren,
linux-arm-kernel, linux-gpio, linux-omap
It enables / disables the input buffer. As explained in the description
of 'enum pin_config_param' this does not affect the pin's ability to
drive output.
Signed-off-by: Dario Binacchi <dariobin@libero.it>
---
drivers/pinctrl/pinctrl-single.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 2c9c9835f375..4e7cdb9ee855 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -534,6 +534,7 @@ static int pcs_pinconf_get(struct pinctrl_dev *pctldev,
case PIN_CONFIG_DRIVE_STRENGTH:
case PIN_CONFIG_SLEW_RATE:
case PIN_CONFIG_MODE_LOW_POWER:
+ case PIN_CONFIG_INPUT_ENABLE:
default:
*config = data;
break;
@@ -572,6 +573,7 @@ static int pcs_pinconf_set(struct pinctrl_dev *pctldev,
case PIN_CONFIG_DRIVE_STRENGTH:
case PIN_CONFIG_SLEW_RATE:
case PIN_CONFIG_MODE_LOW_POWER:
+ case PIN_CONFIG_INPUT_ENABLE:
shift = ffs(func->conf[i].mask) - 1;
data &= ~func->conf[i].mask;
data |= (arg << shift) & func->conf[i].mask;
@@ -918,6 +920,7 @@ static int pcs_parse_pinconf(struct pcs_device *pcs, struct device_node *np,
static const struct pcs_conf_type prop2[] = {
{ "pinctrl-single,drive-strength", PIN_CONFIG_DRIVE_STRENGTH, },
{ "pinctrl-single,slew-rate", PIN_CONFIG_SLEW_RATE, },
+ { "pinctrl-single,input-enable", PIN_CONFIG_INPUT_ENABLE, },
{ "pinctrl-single,input-schmitt", PIN_CONFIG_INPUT_SCHMITT, },
{ "pinctrl-single,low-power-mode", PIN_CONFIG_MODE_LOW_POWER, },
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] pinctrl: single: config: enable the pin's input
2021-06-02 15:04 [RESEND PATCH] pinctrl: single: config: enable the pin's input Dario Binacchi
@ 2021-06-04 8:07 ` Tony Lindgren
2021-06-07 7:02 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2021-06-04 8:07 UTC (permalink / raw)
To: Dario Binacchi
Cc: linux-kernel, Haojian Zhuang, Linus Walleij, linux-arm-kernel,
linux-gpio, linux-omap
* Dario Binacchi <dariobin@libero.it> [210602 15:04]:
> It enables / disables the input buffer. As explained in the description
> of 'enum pin_config_param' this does not affect the pin's ability to
> drive output.
Looks OK to me:
Acked-by: Tony Lindgren <tony@atomide.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] pinctrl: single: config: enable the pin's input
2021-06-02 15:04 [RESEND PATCH] pinctrl: single: config: enable the pin's input Dario Binacchi
2021-06-04 8:07 ` Tony Lindgren
@ 2021-06-07 7:02 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-06-07 7:02 UTC (permalink / raw)
To: Dario Binacchi
Cc: linux-kernel, Haojian Zhuang, Tony Lindgren, Linux ARM,
open list:GPIO SUBSYSTEM, Linux-OMAP
On Wed, Jun 2, 2021 at 5:04 PM Dario Binacchi <dariobin@libero.it> wrote:
> It enables / disables the input buffer. As explained in the description
> of 'enum pin_config_param' this does not affect the pin's ability to
> drive output.
>
> Signed-off-by: Dario Binacchi <dariobin@libero.it>
Patch applied!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-07 7:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02 15:04 [RESEND PATCH] pinctrl: single: config: enable the pin's input Dario Binacchi
2021-06-04 8:07 ` Tony Lindgren
2021-06-07 7:02 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).