From: Tomasz Figa <tfiga@chromium.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: "kyrie.wu" <kyrie.wu@mediatek.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Bin Liu <bin.liu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, xia.jiang@mediatek.com,
maoguang.meng@mediatek.com, srv_heupstream@mediatek.com
Subject: Re: [PATCH v2,3/9] media: mtk-jpegenc: remove redundant code of irq
Date: Fri, 9 Jul 2021 18:07:11 +0900 [thread overview]
Message-ID: <YOgRv143zAfbrlXa@chromium.org> (raw)
In-Reply-To: <CA+Px+wUPX0My5+7gBBo5N0Qf4VbpK96=vS8_F6xrRt+-T9O-3g@mail.gmail.com>
On Tue, Jul 06, 2021 at 07:00:33PM +0800, Tzung-Bi Shih wrote:
> On Wed, Jun 30, 2021 at 3:28 PM kyrie.wu <kyrie.wu@mediatek.com> wrote:
> > the func of jpgenc irq handler would not compatible, remove those
> > code.
> Need more explanation about why as I believe it is non-backward compatible.
Right. And it breaks bisection, which is not acceptable.
Kyrie, please structure your series in a way that none of the patches
break any existing functionality.
Best regards,
Tomasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-09 9:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 7:27 [PATCH v2,0/9] Support jpeg encode for MT8195 kyrie.wu
2021-06-30 7:27 ` [PATCH v2, 1/9] dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible kyrie.wu
2021-06-30 7:27 ` [PATCH v2,2/9] media: mtk-jpegenc: Add MT8195 JPEG venc driver kyrie.wu
2021-07-06 11:00 ` Tzung-Bi Shih
2021-06-30 7:27 ` [PATCH v2,3/9] media: mtk-jpegenc: remove redundant code of irq kyrie.wu
2021-07-06 11:00 ` Tzung-Bi Shih
2021-07-09 9:07 ` Tomasz Figa [this message]
2021-06-30 7:27 ` [PATCH v2,4/9] media: mtk-jpegenc: Refactor jpeg clock interface kyrie.wu
2021-07-06 11:00 ` Tzung-Bi Shih
2021-07-09 9:20 ` Tomasz Figa
2021-06-30 7:27 ` [PATCH v2, 5/9] media: mtk-jpegenc: Generalize jpeg encode irq interfaces kyrie.wu
2021-07-06 11:00 ` Tzung-Bi Shih
2021-07-09 10:20 ` [PATCH v2,5/9] " Tomasz Figa
2021-06-30 7:27 ` [PATCH v2, 6/9] media: mtk-jpegenc: Generalize jpegenc HW timeout interfaces kyrie.wu
2021-07-06 11:00 ` Tzung-Bi Shih
2021-06-30 7:27 ` [PATCH v2, 7/9] media: mtk-jpegenc: Use component framework to manage each hardware information kyrie.wu
2021-07-06 11:00 ` [PATCH v2,7/9] " Tzung-Bi Shih
2021-06-30 7:27 ` [PATCH v2, 8/9] media: mtk-jpegenc: Generalize jpegenc HW operations interfaces kyrie.wu
2021-07-06 11:00 ` [PATCH v2,8/9] " Tzung-Bi Shih
2021-06-30 7:27 ` [PATCH v2, 9/9] media: mtk-jpegenc: Refactor jpegenc device run interface kyrie.wu
2021-07-06 11:01 ` Tzung-Bi Shih
2021-07-06 11:00 ` [PATCH v2,0/9] Support jpeg encode for MT8195 Tzung-Bi Shih
2021-07-09 8:27 ` Tomasz Figa
2021-07-09 10:26 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOgRv143zAfbrlXa@chromium.org \
--to=tfiga@chromium.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=bin.liu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kyrie.wu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tzungbi@chromium.org \
--cc=tzungbi@google.com \
--cc=xia.jiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).