* [PATCH] dt-bindings: microchip: atmel, at91rm9200-tcb: remove mandatory interrupts property
@ 2022-02-04 8:14 Eugen Hristev
2022-02-04 9:46 ` [PATCH] dt-bindings: microchip: atmel,at91rm9200-tcb: " Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Eugen Hristev @ 2022-02-04 8:14 UTC (permalink / raw)
To: robh+dt
Cc: devicetree, alexandre.belloni, linux-kernel, Eugen Hristev,
clement.leger, linux-arm-kernel
The timer block can be used only to be read and to measure time in a polling
fashion. This can be used by Linux like this for example, or it can be used
by different projects which do not have interrupt controllers, or do not
wish to enable them (e.g. U-boot).
As DT is ABI, the binding should relate to all possible use cases and describe
the hardware and the requirements.
The interrupt is not a hard requirement for the timer to function in a
specific way.
Thus, choose to remove the interrupts property from the mandatory list of
properties.
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
.../devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
index 597d67fba92f..27f78459b892 100644
--- a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
+++ b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
@@ -134,7 +134,6 @@ allOf:
required:
- compatible
- reg
- - interrupts
- clocks
- clock-names
- '#address-cells'
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: microchip: atmel,at91rm9200-tcb: remove mandatory interrupts property
2022-02-04 8:14 [PATCH] dt-bindings: microchip: atmel, at91rm9200-tcb: remove mandatory interrupts property Eugen Hristev
@ 2022-02-04 9:46 ` Alexandre Belloni
2022-02-04 10:28 ` Eugen.Hristev
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2022-02-04 9:46 UTC (permalink / raw)
To: Eugen Hristev
Cc: devicetree, linux-kernel, robh+dt, clement.leger, linux-arm-kernel
On 04/02/2022 10:14:46+0200, Eugen Hristev wrote:
> The timer block can be used only to be read and to measure time in a polling
> fashion. This can be used by Linux like this for example, or it can be used
> by different projects which do not have interrupt controllers, or do not
> wish to enable them (e.g. U-boot).
> As DT is ABI, the binding should relate to all possible use cases and describe
> the hardware and the requirements.
> The interrupt is not a hard requirement for the timer to function in a
> specific way.
> Thus, choose to remove the interrupts property from the mandatory list of
> properties.
>
The correct hardware description is that the interrupt is present on the
IP. Having software behave differently depending on the presence of that
property is configuration, not hardware description.
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> .../devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> index 597d67fba92f..27f78459b892 100644
> --- a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> +++ b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> @@ -134,7 +134,6 @@ allOf:
> required:
> - compatible
> - reg
> - - interrupts
> - clocks
> - clock-names
> - '#address-cells'
> --
> 2.25.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: microchip: atmel,at91rm9200-tcb: remove mandatory interrupts property
2022-02-04 9:46 ` [PATCH] dt-bindings: microchip: atmel,at91rm9200-tcb: " Alexandre Belloni
@ 2022-02-04 10:28 ` Eugen.Hristev
2022-02-04 10:36 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Eugen.Hristev @ 2022-02-04 10:28 UTC (permalink / raw)
To: alexandre.belloni
Cc: devicetree, linux-kernel, robh+dt, clement.leger, linux-arm-kernel
On 2/4/22 11:46 AM, Alexandre Belloni wrote:
> On 04/02/2022 10:14:46+0200, Eugen Hristev wrote:
>> The timer block can be used only to be read and to measure time in a polling
>> fashion. This can be used by Linux like this for example, or it can be used
>> by different projects which do not have interrupt controllers, or do not
>> wish to enable them (e.g. U-boot).
>> As DT is ABI, the binding should relate to all possible use cases and describe
>> the hardware and the requirements.
>> The interrupt is not a hard requirement for the timer to function in a
>> specific way.
>> Thus, choose to remove the interrupts property from the mandatory list of
>> properties.
>>
>
> The correct hardware description is that the interrupt is present on the
> IP. Having software behave differently depending on the presence of that
> property is configuration, not hardware description.
I agree. The interrupt is present on the IP, thus the property exists
and it's described.
However, the interrupt is not mandatory for IP operations. Thus it
should not be in the list of mandatory properties.
>
>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>> ---
>> .../devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
>> index 597d67fba92f..27f78459b892 100644
>> --- a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
>> +++ b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
>> @@ -134,7 +134,6 @@ allOf:
>> required:
>> - compatible
>> - reg
>> - - interrupts
>> - clocks
>> - clock-names
>> - '#address-cells'
>> --
>> 2.25.1
>>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: microchip: atmel,at91rm9200-tcb: remove mandatory interrupts property
2022-02-04 10:28 ` Eugen.Hristev
@ 2022-02-04 10:36 ` Alexandre Belloni
2022-02-11 14:21 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2022-02-04 10:36 UTC (permalink / raw)
To: Eugen.Hristev
Cc: devicetree, linux-kernel, robh+dt, clement.leger, linux-arm-kernel
On 04/02/2022 10:28:43+0000, Eugen.Hristev@microchip.com wrote:
> On 2/4/22 11:46 AM, Alexandre Belloni wrote:
> > On 04/02/2022 10:14:46+0200, Eugen Hristev wrote:
> >> The timer block can be used only to be read and to measure time in a polling
> >> fashion. This can be used by Linux like this for example, or it can be used
> >> by different projects which do not have interrupt controllers, or do not
> >> wish to enable them (e.g. U-boot).
> >> As DT is ABI, the binding should relate to all possible use cases and describe
> >> the hardware and the requirements.
> >> The interrupt is not a hard requirement for the timer to function in a
> >> specific way.
> >> Thus, choose to remove the interrupts property from the mandatory list of
> >> properties.
> >>
> >
> > The correct hardware description is that the interrupt is present on the
> > IP. Having software behave differently depending on the presence of that
> > property is configuration, not hardware description.
>
> I agree. The interrupt is present on the IP, thus the property exists
> and it's described.
> However, the interrupt is not mandatory for IP operations. Thus it
> should not be in the list of mandatory properties.
>
If the interrupt is always present, it is mandatory, it doesn't matter
whether is is used or necessary to get the IP to work.
> >
> >> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> >> ---
> >> .../devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> >> index 597d67fba92f..27f78459b892 100644
> >> --- a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> >> +++ b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> >> @@ -134,7 +134,6 @@ allOf:
> >> required:
> >> - compatible
> >> - reg
> >> - - interrupts
> >> - clocks
> >> - clock-names
> >> - '#address-cells'
> >> --
> >> 2.25.1
> >>
> >
> > --
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> >
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: microchip: atmel,at91rm9200-tcb: remove mandatory interrupts property
2022-02-04 10:36 ` Alexandre Belloni
@ 2022-02-11 14:21 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-02-11 14:21 UTC (permalink / raw)
To: Alexandre Belloni
Cc: devicetree, linux-kernel, Eugen.Hristev, clement.leger, linux-arm-kernel
On Fri, Feb 04, 2022 at 11:36:02AM +0100, Alexandre Belloni wrote:
> On 04/02/2022 10:28:43+0000, Eugen.Hristev@microchip.com wrote:
> > On 2/4/22 11:46 AM, Alexandre Belloni wrote:
> > > On 04/02/2022 10:14:46+0200, Eugen Hristev wrote:
> > >> The timer block can be used only to be read and to measure time in a polling
> > >> fashion. This can be used by Linux like this for example, or it can be used
> > >> by different projects which do not have interrupt controllers, or do not
> > >> wish to enable them (e.g. U-boot).
> > >> As DT is ABI, the binding should relate to all possible use cases and describe
> > >> the hardware and the requirements.
> > >> The interrupt is not a hard requirement for the timer to function in a
> > >> specific way.
> > >> Thus, choose to remove the interrupts property from the mandatory list of
> > >> properties.
> > >>
> > >
> > > The correct hardware description is that the interrupt is present on the
> > > IP. Having software behave differently depending on the presence of that
> > > property is configuration, not hardware description.
> >
> > I agree. The interrupt is present on the IP, thus the property exists
> > and it's described.
> > However, the interrupt is not mandatory for IP operations. Thus it
> > should not be in the list of mandatory properties.
> >
>
> If the interrupt is always present, it is mandatory, it doesn't matter
> whether is is used or necessary to get the IP to work.
Agreed.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-11 14:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-04 8:14 [PATCH] dt-bindings: microchip: atmel, at91rm9200-tcb: remove mandatory interrupts property Eugen Hristev
2022-02-04 9:46 ` [PATCH] dt-bindings: microchip: atmel,at91rm9200-tcb: " Alexandre Belloni
2022-02-04 10:28 ` Eugen.Hristev
2022-02-04 10:36 ` Alexandre Belloni
2022-02-11 14:21 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).