From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <michael@walle.cc>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jason Cooper <jason@lakedaemon.net>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line
Date: Fri, 19 Aug 2022 02:28:34 +0200 [thread overview]
Message-ID: <Yv7ZMhWoAk75iYEZ@lunn.ch> (raw)
In-Reply-To: <20220816001026.830127-1-michael@walle.cc>
On Tue, Aug 16, 2022 at 02:10:24AM +0200, Michael Walle wrote:
> Commit 327e15428977 ("ARM: dts: kirkwood: consolidate common pinctrl
> settings") unknowingly broke the serial output on this board. Before
> this commit, the pinmux was still configured by the bootloader and the
> kernel didn't reconfigured it again. This was an oversight by the
> initial board support where the pinmux for the serial line was never
> configured by the kernel. But with this commit, the serial line will be
> reconfigured to the wrong pins. This is especially confusing, because
> the output still works, but the input doesn't. Presumingly, the input is
> reconfigured to MPP10, but the output is connected to both MPP11 and
> MPP5.
>
> Override the pinmux in the board device tree.
>
> Fixes: 327e15428977 ("ARM: dts: kirkwood: consolidate common pinctrl settings")
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-08-19 0:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 0:10 [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line Michael Walle
2022-08-16 0:10 ` [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port Michael Walle
2022-08-19 0:24 ` Andrew Lunn
2022-09-02 14:16 ` Gregory CLEMENT
2022-08-19 0:28 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv7ZMhWoAk75iYEZ@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).