* [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line
@ 2022-08-16 0:10 Michael Walle
2022-08-16 0:10 ` [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port Michael Walle
2022-08-19 0:28 ` [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line Andrew Lunn
0 siblings, 2 replies; 5+ messages in thread
From: Michael Walle @ 2022-08-16 0:10 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth
Cc: Rob Herring, Krzysztof Kozlowski, Jason Cooper, linux-arm-kernel,
devicetree, linux-kernel, Michael Walle
Commit 327e15428977 ("ARM: dts: kirkwood: consolidate common pinctrl
settings") unknowingly broke the serial output on this board. Before
this commit, the pinmux was still configured by the bootloader and the
kernel didn't reconfigured it again. This was an oversight by the
initial board support where the pinmux for the serial line was never
configured by the kernel. But with this commit, the serial line will be
reconfigured to the wrong pins. This is especially confusing, because
the output still works, but the input doesn't. Presumingly, the input is
reconfigured to MPP10, but the output is connected to both MPP11 and
MPP5.
Override the pinmux in the board device tree.
Fixes: 327e15428977 ("ARM: dts: kirkwood: consolidate common pinctrl settings")
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm/boot/dts/kirkwood-lsxl.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
index 7b151acb9984..321a40a98ed2 100644
--- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi
+++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
@@ -10,6 +10,11 @@ chosen {
ocp@f1000000 {
pinctrl: pin-controller@10000 {
+ /* Non-default UART pins */
+ pmx_uart0: pmx-uart0 {
+ marvell,pins = "mpp4", "mpp5";
+ };
+
pmx_power_hdd: pmx-power-hdd {
marvell,pins = "mpp10";
marvell,function = "gpo";
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port
2022-08-16 0:10 [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line Michael Walle
@ 2022-08-16 0:10 ` Michael Walle
2022-08-19 0:24 ` Andrew Lunn
2022-09-02 14:16 ` Gregory CLEMENT
2022-08-19 0:28 ` [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line Andrew Lunn
1 sibling, 2 replies; 5+ messages in thread
From: Michael Walle @ 2022-08-16 0:10 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth
Cc: Rob Herring, Krzysztof Kozlowski, Jason Cooper, linux-arm-kernel,
devicetree, linux-kernel, Michael Walle
Both the Linkstation LS-CHLv2 and the LS-XHL have only one ethernet
port. This has always been wrong, i.e. the board code used to set up
both ports, but the driver will play nice and return -ENODEV if the
assiciated PHY is not found. Nevertheless, it is wrong. Remove it.
Fixes: 876e23333511 ("ARM: kirkwood: add gigabit ethernet and mvmdio device tree nodes")
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm/boot/dts/kirkwood-lsxl.dtsi | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
index 321a40a98ed2..88b70ba1c8fe 100644
--- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi
+++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
@@ -218,22 +218,11 @@ hdd_power: regulator@2 {
&mdio {
status = "okay";
- ethphy0: ethernet-phy@0 {
- reg = <0>;
- };
-
ethphy1: ethernet-phy@8 {
reg = <8>;
};
};
-ð0 {
- status = "okay";
- ethernet0-port@0 {
- phy-handle = <ðphy0>;
- };
-};
-
ð1 {
status = "okay";
ethernet1-port@0 {
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port
2022-08-16 0:10 ` [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port Michael Walle
@ 2022-08-19 0:24 ` Andrew Lunn
2022-09-02 14:16 ` Gregory CLEMENT
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2022-08-19 0:24 UTC (permalink / raw)
To: Michael Walle
Cc: Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, Jason Cooper, linux-arm-kernel, devicetree,
linux-kernel
On Tue, Aug 16, 2022 at 02:10:25AM +0200, Michael Walle wrote:
> Both the Linkstation LS-CHLv2 and the LS-XHL have only one ethernet
> port. This has always been wrong, i.e. the board code used to set up
> both ports, but the driver will play nice and return -ENODEV if the
> assiciated PHY is not found. Nevertheless, it is wrong. Remove it.
>
> Fixes: 876e23333511 ("ARM: kirkwood: add gigabit ethernet and mvmdio device tree nodes")
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port
2022-08-16 0:10 ` [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port Michael Walle
2022-08-19 0:24 ` Andrew Lunn
@ 2022-09-02 14:16 ` Gregory CLEMENT
1 sibling, 0 replies; 5+ messages in thread
From: Gregory CLEMENT @ 2022-09-02 14:16 UTC (permalink / raw)
To: Michael Walle, Andrew Lunn, Sebastian Hesselbarth
Cc: Rob Herring, Krzysztof Kozlowski, Jason Cooper, linux-arm-kernel,
devicetree, linux-kernel, Michael Walle
Michael Walle <michael@walle.cc> writes:
> Both the Linkstation LS-CHLv2 and the LS-XHL have only one ethernet
> port. This has always been wrong, i.e. the board code used to set up
> both ports, but the driver will play nice and return -ENODEV if the
> assiciated PHY is not found. Nevertheless, it is wrong. Remove it.
>
> Fixes: 876e23333511 ("ARM: kirkwood: add gigabit ethernet and mvmdio device tree nodes")
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/kirkwood-lsxl.dtsi | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> index 321a40a98ed2..88b70ba1c8fe 100644
> --- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> @@ -218,22 +218,11 @@ hdd_power: regulator@2 {
> &mdio {
> status = "okay";
>
> - ethphy0: ethernet-phy@0 {
> - reg = <0>;
> - };
> -
> ethphy1: ethernet-phy@8 {
> reg = <8>;
> };
> };
>
> -ð0 {
> - status = "okay";
> - ethernet0-port@0 {
> - phy-handle = <ðphy0>;
> - };
> -};
> -
> ð1 {
> status = "okay";
> ethernet1-port@0 {
> --
> 2.30.2
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line
2022-08-16 0:10 [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line Michael Walle
2022-08-16 0:10 ` [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port Michael Walle
@ 2022-08-19 0:28 ` Andrew Lunn
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2022-08-19 0:28 UTC (permalink / raw)
To: Michael Walle
Cc: Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, Jason Cooper, linux-arm-kernel, devicetree,
linux-kernel
On Tue, Aug 16, 2022 at 02:10:24AM +0200, Michael Walle wrote:
> Commit 327e15428977 ("ARM: dts: kirkwood: consolidate common pinctrl
> settings") unknowingly broke the serial output on this board. Before
> this commit, the pinmux was still configured by the bootloader and the
> kernel didn't reconfigured it again. This was an oversight by the
> initial board support where the pinmux for the serial line was never
> configured by the kernel. But with this commit, the serial line will be
> reconfigured to the wrong pins. This is especially confusing, because
> the output still works, but the input doesn't. Presumingly, the input is
> reconfigured to MPP10, but the output is connected to both MPP11 and
> MPP5.
>
> Override the pinmux in the board device tree.
>
> Fixes: 327e15428977 ("ARM: dts: kirkwood: consolidate common pinctrl settings")
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-02 14:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-16 0:10 [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line Michael Walle
2022-08-16 0:10 ` [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port Michael Walle
2022-08-19 0:24 ` Andrew Lunn
2022-09-02 14:16 ` Gregory CLEMENT
2022-08-19 0:28 ` [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).