* [PATCH] arm64/kexec: Fix missing extra range for crashkres_low.
@ 2022-08-03 15:12 Levi Yun
2022-08-30 4:28 ` [PATCH-RESEND] " Yun Levi
0 siblings, 1 reply; 15+ messages in thread
From: Levi Yun @ 2022-08-03 15:12 UTC (permalink / raw)
To: catalin.marinas, will, chenzhou10, nramas, thunder.leizhen
Cc: linux-arm-kernel, linux-kernel, Levi Yun
Like crashk_res, Calling crash_exclude_mem_range function with
crashk_low_res area would need extra crash_mem range too.
Add one extra crash_mem range when crashk_low_res is used.
Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
---
arch/arm64/kernel/machine_kexec_file.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c
index 889951291cc0..378aee04e7d4 100644
--- a/arch/arm64/kernel/machine_kexec_file.c
+++ b/arch/arm64/kernel/machine_kexec_file.c
@@ -51,6 +51,9 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)
for_each_mem_range(i, &start, &end)
nr_ranges++;
+ if (crashk_low_res.end)
+ nr_ranges++; /**< for exclusion of crashkernel=size,low region */
+
cmem = kmalloc(struct_size(cmem, ranges, nr_ranges), GFP_KERNEL);
if (!cmem)
return -ENOMEM;
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH-RESEND] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-03 15:12 [PATCH] arm64/kexec: Fix missing extra range for crashkres_low Levi Yun
@ 2022-08-30 4:28 ` Yun Levi
2022-08-30 7:37 ` Baoquan He
2022-08-30 9:28 ` [PATCH v2] " Levi Yun
0 siblings, 2 replies; 15+ messages in thread
From: Yun Levi @ 2022-08-30 4:28 UTC (permalink / raw)
To: will, chenzhou10, nramas, thunder.leizhen
Cc: linux-arm-kernel, Linux Kernel Mailing List, kexec
Like crashk_res, Calling crash_exclude_mem_range function with
crashk_low_res area would need extra crash_mem range too.
Add one extra crash_mem range when crashk_low_res is used.
Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
---
arch/arm64/kernel/machine_kexec_file.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/kernel/machine_kexec_file.c
b/arch/arm64/kernel/machine_kexec_file.c
index 889951291cc0..378aee04e7d4 100644
--- a/arch/arm64/kernel/machine_kexec_file.c
+++ b/arch/arm64/kernel/machine_kexec_file.c
@@ -51,6 +51,9 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)
for_each_mem_range(i, &start, &end)
nr_ranges++;
+ if (crashk_low_res.end)
+ nr_ranges++; /**< for exclusion of
crashkernel=size,low region */
+
cmem = kmalloc(struct_size(cmem, ranges, nr_ranges), GFP_KERNEL);
if (!cmem)
return -ENOMEM;
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH-RESEND] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-30 4:28 ` [PATCH-RESEND] " Yun Levi
@ 2022-08-30 7:37 ` Baoquan He
2022-08-30 8:30 ` Yun Levi
2022-08-30 9:28 ` [PATCH v2] " Levi Yun
1 sibling, 1 reply; 15+ messages in thread
From: Baoquan He @ 2022-08-30 7:37 UTC (permalink / raw)
To: Yun Levi
Cc: will, chenzhou10, nramas, thunder.leizhen, linux-arm-kernel,
Linux Kernel Mailing List, kexec
On 08/30/22 at 01:28pm, Yun Levi wrote:
> Like crashk_res, Calling crash_exclude_mem_range function with
> crashk_low_res area would need extra crash_mem range too.
> Add one extra crash_mem range when crashk_low_res is used.
>
> Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
> ---
> arch/arm64/kernel/machine_kexec_file.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/kernel/machine_kexec_file.c
> b/arch/arm64/kernel/machine_kexec_file.c
> index 889951291cc0..378aee04e7d4 100644
> --- a/arch/arm64/kernel/machine_kexec_file.c
> +++ b/arch/arm64/kernel/machine_kexec_file.c
> @@ -51,6 +51,9 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)
> for_each_mem_range(i, &start, &end)
> nr_ranges++;
>
> + if (crashk_low_res.end)
> + nr_ranges++; /**< for exclusion of
> crashkernel=size,low region */
> +
Right, excluding crashkernel region may cause memory region splitting,
so we need extra slot for that.
Meanwhile, can you fix above code comment mess? Otherwise, this looks
good to me.
Or we can add extra 2 slots like we do in x86, it just add another 16
bytes temporarily.
> cmem = kmalloc(struct_size(cmem, ranges, nr_ranges), GFP_KERNEL);
> if (!cmem)
> return -ENOMEM;
> --
> 2.35.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH-RESEND] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-30 7:37 ` Baoquan He
@ 2022-08-30 8:30 ` Yun Levi
0 siblings, 0 replies; 15+ messages in thread
From: Yun Levi @ 2022-08-30 8:30 UTC (permalink / raw)
To: Baoquan He
Cc: will, chenzhou10, nramas, thunder.leizhen, linux-arm-kernel,
Linux Kernel Mailing List, kexec
> Right, excluding crashkernel region may cause memory region splitting,
> so we need extra slot for that.
>
> Meanwhile, can you fix above code comment mess? Otherwise, this looks
> good to me.
Thanks! I'll remove the comment.
> Or we can add extra 2 slots like we do in x86, it just add another 16
> bytes temporarily.
Agree. I'll send the patch again by modifying nr_ranges' initialized value as 2.
Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-30 4:28 ` [PATCH-RESEND] " Yun Levi
2022-08-30 7:37 ` Baoquan He
@ 2022-08-30 9:28 ` Levi Yun
2022-08-30 12:46 ` Baoquan He
2022-08-30 16:40 ` Catalin Marinas
1 sibling, 2 replies; 15+ messages in thread
From: Levi Yun @ 2022-08-30 9:28 UTC (permalink / raw)
To: bhe, will, nramas, thunder.leizhen
Cc: linux-arm-kernel, linux-kernel, kexec, Levi Yun
Like crashk_res, Calling crash_exclude_mem_range function with
crashk_low_res area would need extra crash_mem range too.
Add one more extra cmem range slot in case of crashk_low_res is used.
Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
---
arch/arm64/kernel/machine_kexec_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c
index 889951291cc0..a11a6e14ba89 100644
--- a/arch/arm64/kernel/machine_kexec_file.c
+++ b/arch/arm64/kernel/machine_kexec_file.c
@@ -47,7 +47,7 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)
u64 i;
phys_addr_t start, end;
- nr_ranges = 1; /* for exclusion of crashkernel region */
+ nr_ranges = 2; /* for exclusion of crashkernel region */
for_each_mem_range(i, &start, &end)
nr_ranges++;
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v2] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-30 9:28 ` [PATCH v2] " Levi Yun
@ 2022-08-30 12:46 ` Baoquan He
2022-08-30 16:40 ` Catalin Marinas
1 sibling, 0 replies; 15+ messages in thread
From: Baoquan He @ 2022-08-30 12:46 UTC (permalink / raw)
To: Levi Yun
Cc: will, catalin.marinas, nramas, thunder.leizhen, linux-arm-kernel,
linux-kernel, kexec
On 08/30/22 at 06:28pm, Levi Yun wrote:
> Like crashk_res, Calling crash_exclude_mem_range function with
> crashk_low_res area would need extra crash_mem range too.
>
> Add one more extra cmem range slot in case of crashk_low_res is used.
~~^ should be removed.
LGTM,
Acked-by: Baoquan He <bhe@redhat.com>
>
> Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
> ---
> arch/arm64/kernel/machine_kexec_file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c
> index 889951291cc0..a11a6e14ba89 100644
> --- a/arch/arm64/kernel/machine_kexec_file.c
> +++ b/arch/arm64/kernel/machine_kexec_file.c
> @@ -47,7 +47,7 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)
> u64 i;
> phys_addr_t start, end;
>
> - nr_ranges = 1; /* for exclusion of crashkernel region */
> + nr_ranges = 2; /* for exclusion of crashkernel region */
> for_each_mem_range(i, &start, &end)
> nr_ranges++;
>
> --
> 2.35.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v2] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-30 9:28 ` [PATCH v2] " Levi Yun
2022-08-30 12:46 ` Baoquan He
@ 2022-08-30 16:40 ` Catalin Marinas
2022-08-31 0:38 ` Yun Levi
1 sibling, 1 reply; 15+ messages in thread
From: Catalin Marinas @ 2022-08-30 16:40 UTC (permalink / raw)
To: Levi Yun
Cc: bhe, will, nramas, thunder.leizhen, linux-arm-kernel,
linux-kernel, kexec
On Tue, Aug 30, 2022 at 06:28:39PM +0900, Levi Yun wrote:
> Like crashk_res, Calling crash_exclude_mem_range function with
> crashk_low_res area would need extra crash_mem range too.
>
> Add one more extra cmem range slot in case of crashk_low_res is used.
>
> Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Does this need a Fixes tag and cc stable?
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-30 16:40 ` Catalin Marinas
@ 2022-08-31 0:38 ` Yun Levi
2022-08-31 1:18 ` Baoquan He
0 siblings, 1 reply; 15+ messages in thread
From: Yun Levi @ 2022-08-31 0:38 UTC (permalink / raw)
To: Catalin Marinas
Cc: Baoquan He, will, nramas, thunder.leizhen, linux-arm-kernel,
Linux Kernel Mailing List, kexec
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
>
> Does this need a Fixes tag and cc stable?
>
> --
> Catalin
IMHO, it seems good to add two tags like:
Fixes: 3751e728cef29 ("arm64: kexec_file: add crash dump support")
Cc: stable@vger.kernel.org
BTW, To add above two tags, should I resend the patch again with
former tags (Acked-by & Reviewed-by)?
Thanks.
--
Best regards,
Levi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v2] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-31 0:38 ` Yun Levi
@ 2022-08-31 1:18 ` Baoquan He
2022-08-31 1:31 ` Yun Levi
0 siblings, 1 reply; 15+ messages in thread
From: Baoquan He @ 2022-08-31 1:18 UTC (permalink / raw)
To: Yun Levi
Cc: Catalin Marinas, will, nramas, thunder.leizhen, linux-arm-kernel,
Linux Kernel Mailing List, kexec
On 08/31/22 at 09:38am, Yun Levi wrote:
> > Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> >
> > Does this need a Fixes tag and cc stable?
> >
> > --
> > Catalin
>
> IMHO, it seems good to add two tags like:
> Fixes: 3751e728cef29 ("arm64: kexec_file: add crash dump support")
> Cc: stable@vger.kernel.org
No, I don't think the Fixes commit is right. It should fix the commit
where crashkernel,low is introduced. Before that, no issue caused.
So the tags should be:
Fixes: 944a45abfabc ("arm64: kdump: Reimplement crashkernel=X")
Cc: stable@vger.kernel.org
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v2] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-31 1:18 ` Baoquan He
@ 2022-08-31 1:31 ` Yun Levi
2022-08-31 1:49 ` [PATCH v2-RESEND] " Yun Levi
0 siblings, 1 reply; 15+ messages in thread
From: Yun Levi @ 2022-08-31 1:31 UTC (permalink / raw)
To: Baoquan He
Cc: Catalin Marinas, will, nramas, thunder.leizhen, linux-arm-kernel,
Linux Kernel Mailing List, kexec
> No, I don't think the Fixes commit is right. It should fix the commit
> where crashkernel,low is introduced. Before that, no issue caused.
> So the tags should be:
>
> Fixes: 944a45abfabc ("arm64: kdump: Reimplement crashkernel=X")
> Cc: stable@vger.kernel.org
Thanks! I'will resend the patch with fixed commit message and the tags
including Fixes, Cc, Review-By and Acked-by.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH v2-RESEND] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-31 1:31 ` Yun Levi
@ 2022-08-31 1:49 ` Yun Levi
2022-08-31 10:26 ` Catalin Marinas
2022-08-31 10:39 ` [PATCH v3] " Levi Yun
0 siblings, 2 replies; 15+ messages in thread
From: Yun Levi @ 2022-08-31 1:49 UTC (permalink / raw)
To: Baoquan He
Cc: Catalin Marinas, will, nramas, thunder.leizhen, linux-arm-kernel,
Linux Kernel Mailing List, kexec
Like crashk_res, Calling crash_exclude_mem_range function with
crashk_low_res area would need extra crash_mem range too.
Add one more extra cmem slot in case of crashk_low_res is used.
Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
Fixes: 944a45abfabc ("arm64: kdump: Reimplement crashkernel=X")
Cc: stable@vger.kernel.org
Acked-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
---
arch/arm64/kernel/machine_kexec_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/machine_kexec_file.c
b/arch/arm64/kernel/machine_kexec_file.c
index 889951291cc0..a11a6e14ba89 100644
--- a/arch/arm64/kernel/machine_kexec_file.c
+++ b/arch/arm64/kernel/machine_kexec_file.c
@@ -47,7 +47,7 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)
u64 i;
phys_addr_t start, end;
- nr_ranges = 1; /* for exclusion of crashkernel region */
+ nr_ranges = 2; /* for exclusion of crashkernel region */
for_each_mem_range(i, &start, &end)
nr_ranges++;
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v2-RESEND] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-31 1:49 ` [PATCH v2-RESEND] " Yun Levi
@ 2022-08-31 10:26 ` Catalin Marinas
2022-08-31 10:29 ` Yun Levi
2022-08-31 10:39 ` [PATCH v3] " Levi Yun
1 sibling, 1 reply; 15+ messages in thread
From: Catalin Marinas @ 2022-08-31 10:26 UTC (permalink / raw)
To: Yun Levi
Cc: Baoquan He, will, nramas, thunder.leizhen, linux-arm-kernel,
Linux Kernel Mailing List, kexec
On Wed, Aug 31, 2022 at 10:49:30AM +0900, Yun Levi wrote:
> Like crashk_res, Calling crash_exclude_mem_range function with
> crashk_low_res area would need extra crash_mem range too.
>
> Add one more extra cmem slot in case of crashk_low_res is used.
>
> Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
> Fixes: 944a45abfabc ("arm64: kdump: Reimplement crashkernel=X")
> Cc: stable@vger.kernel.org
To be even more precise, it should be:
Cc: <stable@vger.kernel.org> # 5.19.x
> Acked-by: Baoquan He <bhe@redhat.com>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
> arch/arm64/kernel/machine_kexec_file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/machine_kexec_file.c
> b/arch/arm64/kernel/machine_kexec_file.c
> index 889951291cc0..a11a6e14ba89 100644
> --- a/arch/arm64/kernel/machine_kexec_file.c
> +++ b/arch/arm64/kernel/machine_kexec_file.c
> @@ -47,7 +47,7 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)
> u64 i;
> phys_addr_t start, end;
>
> - nr_ranges = 1; /* for exclusion of crashkernel region */
> + nr_ranges = 2; /* for exclusion of crashkernel region */
> for_each_mem_range(i, &start, &end)
> nr_ranges++;
Something happened to the whitespace here, so the patch can't be
applied.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v2-RESEND] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-31 10:26 ` Catalin Marinas
@ 2022-08-31 10:29 ` Yun Levi
0 siblings, 0 replies; 15+ messages in thread
From: Yun Levi @ 2022-08-31 10:29 UTC (permalink / raw)
To: Catalin Marinas
Cc: Baoquan He, will, nramas, thunder.leizhen, linux-arm-kernel,
Linux Kernel Mailing List, kexec
>
> To be even more precise, it should be:
>
> Cc: <stable@vger.kernel.org> # 5.19.x
Thanks! I'll fix it!
> Something happened to the whitespace here, so the patch can't be
> applied.
Sorry, I'll check and send again :). Thanks!
On Wed, Aug 31, 2022 at 7:26 PM Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> On Wed, Aug 31, 2022 at 10:49:30AM +0900, Yun Levi wrote:
> > Like crashk_res, Calling crash_exclude_mem_range function with
> > crashk_low_res area would need extra crash_mem range too.
> >
> > Add one more extra cmem slot in case of crashk_low_res is used.
> >
> > Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
> > Fixes: 944a45abfabc ("arm64: kdump: Reimplement crashkernel=X")
> > Cc: stable@vger.kernel.org
>
> To be even more precise, it should be:
>
> Cc: <stable@vger.kernel.org> # 5.19.x
>
> > Acked-by: Baoquan He <bhe@redhat.com>
> > Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> > ---
> > arch/arm64/kernel/machine_kexec_file.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/kernel/machine_kexec_file.c
> > b/arch/arm64/kernel/machine_kexec_file.c
> > index 889951291cc0..a11a6e14ba89 100644
> > --- a/arch/arm64/kernel/machine_kexec_file.c
> > +++ b/arch/arm64/kernel/machine_kexec_file.c
> > @@ -47,7 +47,7 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)
> > u64 i;
> > phys_addr_t start, end;
> >
> > - nr_ranges = 1; /* for exclusion of crashkernel region */
> > + nr_ranges = 2; /* for exclusion of crashkernel region */
> > for_each_mem_range(i, &start, &end)
> > nr_ranges++;
>
> Something happened to the whitespace here, so the patch can't be
> applied.
>
> --
> Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-31 1:49 ` [PATCH v2-RESEND] " Yun Levi
2022-08-31 10:26 ` Catalin Marinas
@ 2022-08-31 10:39 ` Levi Yun
2022-09-01 13:06 ` Will Deacon
1 sibling, 1 reply; 15+ messages in thread
From: Levi Yun @ 2022-08-31 10:39 UTC (permalink / raw)
To: catalin.marinas, bhe
Cc: will, nramas, thunder.leizhen, linux-arm-kernel, linux-kernel,
kexec, Levi Yun, stable
Like crashk_res, Calling crash_exclude_mem_range function with
crashk_low_res area would need extra crash_mem range too.
Add one more extra cmem slot in case of crashk_low_res is used.
Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
Fixes: 944a45abfabc ("arm64: kdump: Reimplement crashkernel=X")
Cc: <stable@vger.kernel.org> # 5.19.x
Acked-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
---
arch/arm64/kernel/machine_kexec_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c
index 889951291cc0..a11a6e14ba89 100644
--- a/arch/arm64/kernel/machine_kexec_file.c
+++ b/arch/arm64/kernel/machine_kexec_file.c
@@ -47,7 +47,7 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)
u64 i;
phys_addr_t start, end;
- nr_ranges = 1; /* for exclusion of crashkernel region */
+ nr_ranges = 2; /* for exclusion of crashkernel region */
for_each_mem_range(i, &start, &end)
nr_ranges++;
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v3] arm64/kexec: Fix missing extra range for crashkres_low.
2022-08-31 10:39 ` [PATCH v3] " Levi Yun
@ 2022-09-01 13:06 ` Will Deacon
0 siblings, 0 replies; 15+ messages in thread
From: Will Deacon @ 2022-09-01 13:06 UTC (permalink / raw)
To: Levi Yun, catalin.marinas, bhe
Cc: kernel-team, Will Deacon, nramas, stable, linux-arm-kernel,
kexec, thunder.leizhen, linux-kernel
On Wed, 31 Aug 2022 19:39:13 +0900, Levi Yun wrote:
> Like crashk_res, Calling crash_exclude_mem_range function with
> crashk_low_res area would need extra crash_mem range too.
>
> Add one more extra cmem slot in case of crashk_low_res is used.
>
>
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64/kexec: Fix missing extra range for crashkres_low.
https://git.kernel.org/arm64/c/4831be702b95
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-09-01 13:15 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-03 15:12 [PATCH] arm64/kexec: Fix missing extra range for crashkres_low Levi Yun
2022-08-30 4:28 ` [PATCH-RESEND] " Yun Levi
2022-08-30 7:37 ` Baoquan He
2022-08-30 8:30 ` Yun Levi
2022-08-30 9:28 ` [PATCH v2] " Levi Yun
2022-08-30 12:46 ` Baoquan He
2022-08-30 16:40 ` Catalin Marinas
2022-08-31 0:38 ` Yun Levi
2022-08-31 1:18 ` Baoquan He
2022-08-31 1:31 ` Yun Levi
2022-08-31 1:49 ` [PATCH v2-RESEND] " Yun Levi
2022-08-31 10:26 ` Catalin Marinas
2022-08-31 10:29 ` Yun Levi
2022-08-31 10:39 ` [PATCH v3] " Levi Yun
2022-09-01 13:06 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).