From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org, kernel test robot <lkp@intel.com>,
Ard Biesheuvel <ardb@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: hcd: remove unused hcd_name variables
Date: Thu, 1 Sep 2022 15:53:32 +0200 [thread overview]
Message-ID: <YxC5XCnJaYQPWAMP@kroah.com> (raw)
In-Reply-To: <Yw9ucDxO7huIl/2W@rowland.harvard.edu>
On Wed, Aug 31, 2022 at 10:21:36AM -0400, Alan Stern wrote:
> On Wed, Aug 31, 2022 at 09:30:32AM +0200, Greg Kroah-Hartman wrote:
> > In the commit 10174220f55a ("usb: reduce kernel log spam on driver
> > registration") a lot of unneeded kernel log messages were removed, but
> > that caused a few build warnings to show up where the variable
> > `hcd_name` was being set but never used anymore.
> >
> > Resolve this by just removing these variables as they are not needed
> > anymore
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Cc: Ard Biesheuvel <ardb@kernel.org>
> > Cc: Alan Stern <stern@rowland.harvard.edu>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Cc: Alim Akhtar <alim.akhtar@samsung.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: linux-usb@vger.kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-samsung-soc@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Fixes: 10174220f55a ("usb: reduce kernel log spam on driver registration")
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > drivers/usb/host/ehci-exynos.c | 1 -
> > drivers/usb/host/ehci-platform.c | 2 --
> > drivers/usb/host/ohci-platform.c | 2 --
> > 3 files changed, 5 deletions(-)
>
> This isn't enough, as you can see from this kernel test robot excerpt:
>
> clang_recent_errors
> |-- arm-s5pv210_defconfig
> | |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
> | `-- drivers-usb-host-ohci-exynos.c:warning:unused-variable-hcd_name
> |-- hexagon-randconfig-r024-20220830
> | |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ehci-orion.c:warning:unused-variable-hcd_name
> | |--
> drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ehci-spear.c:warning:unused-variable-hcd_name
> | `--
> drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
> |-- hexagon-randconfig-r036-20220830
> | |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ehci-npcm7xx.c:warning:unused-variable-hcd_name
> | |--
> drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ehci-st.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ohci-at91.c:warning:unused-variable-hcd_name
> | |--
> drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ohci-s3c2410.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ohci-spear.c:warning:unused-variable-hcd_name
> | `-- drivers-usb-host-ohci-st.c:warning:unused-variable-hcd_name
>
> Yes, it has duplicates and your patch handles some of these. But there
> are others that still need to be fixed. Also, this list is missing
> ohci-pxa27x.c.
Ick, ok, I went off of a different kbuild report. Let me fix this up
later today...
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-01 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 7:30 [PATCH] USB: hcd: remove unused hcd_name variables Greg Kroah-Hartman
2022-08-31 14:21 ` Alan Stern
2022-09-01 13:53 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxC5XCnJaYQPWAMP@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alim.akhtar@samsung.com \
--cc=ardb@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=robh@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).