From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v6 5/6] media: sun6i-csi: Detect the availability of the ISP
Date: Thu, 1 Sep 2022 21:14:49 +0300 [thread overview]
Message-ID: <YxD2maSZhkotqMiL@pendragon.ideasonboard.com> (raw)
In-Reply-To: <YxDLhPMibhXO1oU/@aptenodytes>
Hi Paul,
On Thu, Sep 01, 2022 at 05:11:00PM +0200, Paul Kocialkowski wrote:
> On Sat 27 Aug 22, 01:39, Laurent Pinchart wrote:
> > On Fri, Aug 26, 2022 at 08:41:43PM +0200, Paul Kocialkowski wrote:
> > > Add a helper to detect whether the ISP is available and connected
> > > and store the indication in a driver-wide variable.
> >
> > This sounds like it would be a global variable, while it's stored in the
> > driver-specific device structure.
>
> Okay I can clarify the commit message here.
>
> > >
> > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > > ---
> > > .../platform/sunxi/sun6i-csi/sun6i_csi.c | 33 +++++++++++++++++++
> > > .../platform/sunxi/sun6i-csi/sun6i_csi.h | 3 ++
> > > 2 files changed, 36 insertions(+)
> > >
> > > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> > > index 00521f966cee..b16166cba2ef 100644
> > > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> > > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> > > @@ -24,6 +24,35 @@
> > > #include "sun6i_csi_capture.h"
> > > #include "sun6i_csi_reg.h"
> > >
> > > +/* ISP */
> > > +
> > > +static bool sun6i_csi_isp_detect(struct sun6i_csi_device *csi_dev)
> > > +{
> > > + struct device *dev = csi_dev->dev;
> > > + struct fwnode_handle *handle = NULL;
> >
> > No need to initialize this to NULL.
>
> Indeed.
>
> > > +
> > > + /* ISP is not available if disabled in kernel config. */
> > > + if (!IS_ENABLED(CONFIG_VIDEO_SUN6I_ISP))
> > > + return 0;
> >
> > Hmmm... The ISP driver may be disabled when compiling the sun6i-csi
> > driver, but later enabled and deployed. Disabling ISP support silently
> > like this could be confusing. Could it be better to move this check
> > after the graph check, and print a warning message in this case ?
>
> Yeah I'm not too surprised corner cases like this can exist.
> Agreed that printing a warning message would be good, but I don't follow the
> point of moving the check later on. Do you have something in mind there?
I meant that the warning should only be printed of there's an endpoint
connected to the ISP, so I'd first check if the endpoint is present,
return 0 if it isn't, and then check if the ISP driver is enabled and
print a warning if it isn't.
> > > +
> > > + /*
> > > + * ISP is not available if not connected via fwnode graph.
> > > + * This weill also check that the remote parent node is available.
> >
> > s/weill/will/
>
> Good catch, thanks!
>
> > * ISP is not available if not connected via fwnode graph. This will
> > * also check that the remote parent node is available.
> >
> > > + */
> > > + handle = fwnode_graph_get_endpoint_by_id(dev_fwnode(dev),
> > > + SUN6I_CSI_PORT_ISP, 0,
> > > + FWNODE_GRAPH_ENDPOINT_NEXT);
> > > + if (!handle)
> > > + return 0;
> > > +
> > > + fwnode_handle_put(handle);
> > > +
> > > + dev_info(dev, "ISP link is available\n");
> >
> > You could make that a debug message, it's not crucial information that
> > needs to be printed when the driver is loaded. If you prefer keeping an
> > info message, then I'd move it to the probe function and print that the
> > CSI has been probed, and indicate in that message if the ISP is
> > available.
>
> You're right, let's make this debug. It's more the opposite case that is worth
> a warning message.
>
> > > + csi_dev->isp_available = true;
> > > +
> > > + return 0;
> > > +}
> > > +
> > > /* Media */
> > >
> > > static const struct media_device_ops sun6i_csi_media_ops = {
> > > @@ -290,6 +319,10 @@ static int sun6i_csi_probe(struct platform_device *platform_dev)
> > > if (ret)
> > > return ret;
> > >
> > > + ret = sun6i_csi_isp_detect(csi_dev);
> > > + if (ret)
> > > + goto error_resources;
> > > +
> > > ret = sun6i_csi_v4l2_setup(csi_dev);
> > > if (ret)
> > > goto error_resources;
> > > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h
> > > index e611bdd6e9b2..8e232cd91ebe 100644
> > > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h
> > > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h
> > > @@ -21,6 +21,7 @@
> > > enum sun6i_csi_port {
> > > SUN6I_CSI_PORT_PARALLEL = 0,
> > > SUN6I_CSI_PORT_MIPI_CSI2 = 1,
> > > + SUN6I_CSI_PORT_ISP = 2,
> > > };
> > >
> > > struct sun6i_csi_buffer {
> > > @@ -44,6 +45,8 @@ struct sun6i_csi_device {
> > > struct clk *clock_mod;
> > > struct clk *clock_ram;
> > > struct reset_control *reset;
> > > +
> > > + bool isp_available;
> > > };
> > >
> > > struct sun6i_csi_variant {
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-01 18:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 18:41 [PATCH v6 0/6] Allwinner A31/A83T MIPI CSI-2 and A31 ISP / ISP Driver Paul Kocialkowski
2022-08-26 18:41 ` [PATCH v6 1/6] dt-bindings: media: Add Allwinner A31 ISP bindings documentation Paul Kocialkowski
2022-08-26 21:12 ` Laurent Pinchart
2022-09-01 15:03 ` Paul Kocialkowski
2022-09-01 18:12 ` Laurent Pinchart
2022-08-26 18:41 ` [PATCH v6 2/6] dt-bindings: media: sun6i-a31-csi: Add ISP output port Paul Kocialkowski
2022-08-26 22:29 ` Laurent Pinchart
2022-09-01 14:57 ` Paul Kocialkowski
2022-08-26 18:41 ` [PATCH v6 3/6] staging: media: Add support for the Allwinner A31 ISP Paul Kocialkowski
2022-08-26 18:41 ` [PATCH v6 4/6] MAINTAINERS: Add entry for the Allwinner A31 ISP driver Paul Kocialkowski
2022-08-26 22:30 ` Laurent Pinchart
2022-08-26 18:41 ` [PATCH v6 5/6] media: sun6i-csi: Detect the availability of the ISP Paul Kocialkowski
2022-08-26 22:39 ` Laurent Pinchart
2022-09-01 15:11 ` Paul Kocialkowski
2022-09-01 18:14 ` Laurent Pinchart [this message]
2022-08-26 18:41 ` [PATCH v6 6/6] media: sun6i-csi: Add support for hooking to the isp devices Paul Kocialkowski
2022-08-26 22:44 ` Laurent Pinchart
2022-09-01 14:55 ` Paul Kocialkowski
2022-09-01 18:17 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxD2maSZhkotqMiL@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=samuel@sholland.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).