linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml
@ 2022-08-30  9:11 matthias.bgg
  2022-09-06 16:41 ` Rob Herring
  2022-09-08 10:37 ` Lee Jones
  0 siblings, 2 replies; 5+ messages in thread
From: matthias.bgg @ 2022-08-30  9:11 UTC (permalink / raw)
  To: matthias.bgg, lee, robh+dt, angelogioacchino.delregno
  Cc: devicetree, linux-kernel, linux-mediatek, krzysztof.kozlowski+dt,
	matthias.bgg, mandyjh.liu, linux-arm-kernel, Matthias Brugger

From: Matthias Brugger <mbrugger@suse.com>

The file describes the scpsys node for all SoCs and not only the mt8195.
Rename it to reflect this fact.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

---

Changes in v2:
- Fix id

 .../mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml}   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename Documentation/devicetree/bindings/mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} (96%)

diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
similarity index 96%
rename from Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml
rename to Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
index 3737207d8504..1a5901ca90f5 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/mfd/mediatek,mt8195-scpsys.yaml#
+$id: http://devicetree.org/schemas/mfd/mediatek,scpsys.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: MediaTek System Control Processor System
-- 
2.37.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml
  2022-08-30  9:11 [PATCH v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml matthias.bgg
@ 2022-09-06 16:41 ` Rob Herring
  2022-09-08 10:37 ` Lee Jones
  1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-09-06 16:41 UTC (permalink / raw)
  To: matthias.bgg
  Cc: Matthias Brugger, mandyjh.liu, krzysztof.kozlowski+dt,
	matthias.bgg, angelogioacchino.delregno, robh+dt, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek, lee

On Tue, 30 Aug 2022 11:11:10 +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
> 
> The file describes the scpsys node for all SoCs and not only the mt8195.
> Rename it to reflect this fact.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
> ---
> 
> Changes in v2:
> - Fix id
> 
>  .../mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml}   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  rename Documentation/devicetree/bindings/mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} (96%)
> 

Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml
  2022-08-30  9:11 [PATCH v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml matthias.bgg
  2022-09-06 16:41 ` Rob Herring
@ 2022-09-08 10:37 ` Lee Jones
  2022-09-13 11:51   ` Matthias Brugger
  1 sibling, 1 reply; 5+ messages in thread
From: Lee Jones @ 2022-09-08 10:37 UTC (permalink / raw)
  To: matthias.bgg
  Cc: robh+dt, angelogioacchino.delregno, devicetree, linux-kernel,
	linux-mediatek, krzysztof.kozlowski+dt, matthias.bgg,
	mandyjh.liu, linux-arm-kernel, Matthias Brugger

On Tue, 30 Aug 2022, matthias.bgg@kernel.org wrote:

> From: Matthias Brugger <mbrugger@suse.com>
> 
> The file describes the scpsys node for all SoCs and not only the mt8195.
> Rename it to reflect this fact.

Actually, this is fairly typical.  Same with actual drivers.

Both tend to adopt the name of the module first supported.

> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
> ---
> 
> Changes in v2:
> - Fix id
> 
>  .../mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml}   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  rename Documentation/devicetree/bindings/mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} (96%)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
> similarity index 96%
> rename from Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml
> rename to Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
> index 3737207d8504..1a5901ca90f5 100644
> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/mfd/mediatek,mt8195-scpsys.yaml#
> +$id: http://devicetree.org/schemas/mfd/mediatek,scpsys.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
>  title: MediaTek System Control Processor System

-- 
Lee Jones [李琼斯]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml
  2022-09-08 10:37 ` Lee Jones
@ 2022-09-13 11:51   ` Matthias Brugger
  2022-09-20  9:10     ` Lee Jones
  0 siblings, 1 reply; 5+ messages in thread
From: Matthias Brugger @ 2022-09-13 11:51 UTC (permalink / raw)
  To: Lee Jones, matthias.bgg
  Cc: robh+dt, angelogioacchino.delregno, devicetree, linux-kernel,
	linux-mediatek, krzysztof.kozlowski+dt, matthias.bgg,
	mandyjh.liu, linux-arm-kernel



On 08/09/2022 12:37, Lee Jones wrote:
> On Tue, 30 Aug 2022, matthias.bgg@kernel.org wrote:
> 
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> The file describes the scpsys node for all SoCs and not only the mt8195.
>> Rename it to reflect this fact.
> 
> Actually, this is fairly typical.  Same with actual drivers.
> 
> Both tend to adopt the name of the module first supported.
> 

Well I think that's unfortunate as it can create confusion for people searching 
for the binding as well as people adding a new compatible as they might think 
each SoC should have a independent yaml file. For that I reason I think it makes 
sense to fix the naming.

Regards,
Matthias

>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>
>> ---
>>
>> Changes in v2:
>> - Fix id
>>
>>   .../mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml}   | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>   rename Documentation/devicetree/bindings/mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} (96%)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
>> similarity index 96%
>> rename from Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml
>> rename to Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
>> index 3737207d8504..1a5901ca90f5 100644
>> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
>> @@ -1,7 +1,7 @@
>>   # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>   %YAML 1.2
>>   ---
>> -$id: http://devicetree.org/schemas/mfd/mediatek,mt8195-scpsys.yaml#
>> +$id: http://devicetree.org/schemas/mfd/mediatek,scpsys.yaml#
>>   $schema: http://devicetree.org/meta-schemas/core.yaml#
>>   
>>   title: MediaTek System Control Processor System
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml
  2022-09-13 11:51   ` Matthias Brugger
@ 2022-09-20  9:10     ` Lee Jones
  0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2022-09-20  9:10 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: matthias.bgg, robh+dt, angelogioacchino.delregno, devicetree,
	linux-kernel, linux-mediatek, krzysztof.kozlowski+dt,
	matthias.bgg, mandyjh.liu, linux-arm-kernel

On Tue, 13 Sep 2022, Matthias Brugger wrote:
> On 08/09/2022 12:37, Lee Jones wrote:
> > On Tue, 30 Aug 2022, matthias.bgg@kernel.org wrote:
> > 
> > > From: Matthias Brugger <mbrugger@suse.com>
> > > 
> > > The file describes the scpsys node for all SoCs and not only the mt8195.
> > > Rename it to reflect this fact.
> > 
> > Actually, this is fairly typical.  Same with actual drivers.
> > 
> > Both tend to adopt the name of the module first supported.
> > 
> 
> Well I think that's unfortunate as it can create confusion for people
> searching for the binding as well as people adding a new compatible as they
> might think each SoC should have a independent yaml file. For that I reason
> I think it makes sense to fix the naming.

I'm not keen to open those flood-gates right now, sorry.

-- 
Lee Jones [李琼斯]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-09-20  9:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-30  9:11 [PATCH v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml matthias.bgg
2022-09-06 16:41 ` Rob Herring
2022-09-08 10:37 ` Lee Jones
2022-09-13 11:51   ` Matthias Brugger
2022-09-20  9:10     ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).