* [PATCH] ARM: dts: turris-omnia: Add switch port 6 node
@ 2022-08-25 12:21 Pali Rohár
2022-08-27 18:41 ` Andrew Lunn
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Pali Rohár @ 2022-08-25 12:21 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-kernel, devicetree, linux-kernel, Marek Behún
Switch port 6 is connected to eth0, so add appropriate device tree node for it.
Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
Signed-off-by: Pali Rohár <pali@kernel.org>
---
arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
index f655e9229d68..8215ffb6a795 100644
--- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
@@ -463,7 +463,17 @@
};
};
- /* port 6 is connected to eth0 */
+ ports@6 {
+ reg = <6>;
+ label = "cpu";
+ ethernet = <ð0>;
+ phy-mode = "rgmii-id";
+
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
};
};
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node
2022-08-25 12:21 [PATCH] ARM: dts: turris-omnia: Add switch port 6 node Pali Rohár
@ 2022-08-27 18:41 ` Andrew Lunn
2022-08-27 18:45 ` Pali Rohár
2022-09-24 12:14 ` Pali Rohár
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Andrew Lunn @ 2022-08-27 18:41 UTC (permalink / raw)
To: Pali Rohár
Cc: Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel,
Marek Behún
On Thu, Aug 25, 2022 at 02:21:02PM +0200, Pali Rohár wrote:
> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
> };
> };
>
> - /* port 6 is connected to eth0 */
> + ports@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <ð0>;
> + phy-mode = "rgmii-id";
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
Hi Pali
I've not been following Vladimirs work on multiple CPU ports. Is it
clearly defined, both for old and new kernels, what happens where
there are multiple CPU ports defined?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node
2022-08-27 18:41 ` Andrew Lunn
@ 2022-08-27 18:45 ` Pali Rohár
2022-08-27 18:55 ` Andrew Lunn
0 siblings, 1 reply; 8+ messages in thread
From: Pali Rohár @ 2022-08-27 18:45 UTC (permalink / raw)
To: Andrew Lunn
Cc: Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel,
Marek Behún
On Saturday 27 August 2022 20:41:59 Andrew Lunn wrote:
> On Thu, Aug 25, 2022 at 02:21:02PM +0200, Pali Rohár wrote:
> > Switch port 6 is connected to eth0, so add appropriate device tree node for it.
> >
> > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> > arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > index f655e9229d68..8215ffb6a795 100644
> > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > @@ -463,7 +463,17 @@
> > };
> > };
> >
> > - /* port 6 is connected to eth0 */
> > + ports@6 {
> > + reg = <6>;
> > + label = "cpu";
> > + ethernet = <ð0>;
> > + phy-mode = "rgmii-id";
> > +
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + };
> > + };
>
> Hi Pali
>
> I've not been following Vladimirs work on multiple CPU ports. Is it
> clearly defined, both for old and new kernels, what happens where
> there are multiple CPU ports defined?
>
> Andrew
Hello!
On older kernel kernel versions just the first one cpu port works. Like
if second node is not defined at all. So I sent this patch to have
complete HW definition in DTS, even when kernel does not support all
features yet.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node
2022-08-27 18:45 ` Pali Rohár
@ 2022-08-27 18:55 ` Andrew Lunn
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2022-08-27 18:55 UTC (permalink / raw)
To: Pali Rohár
Cc: Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel,
Marek Behún
> > Hi Pali
> >
> > I've not been following Vladimirs work on multiple CPU ports. Is it
> > clearly defined, both for old and new kernels, what happens where
> > there are multiple CPU ports defined?
> >
> > Andrew
>
> Hello!
>
> On older kernel kernel versions just the first one cpu port works.
O.K, i was worried it might use the last "cpu" port found, and so
change things.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node
2022-08-25 12:21 [PATCH] ARM: dts: turris-omnia: Add switch port 6 node Pali Rohár
2022-08-27 18:41 ` Andrew Lunn
@ 2022-09-24 12:14 ` Pali Rohár
2022-09-24 14:43 ` Andrew Lunn
2022-11-01 22:41 ` Pali Rohár
2022-11-28 0:01 ` Gregory CLEMENT
3 siblings, 1 reply; 8+ messages in thread
From: Pali Rohár @ 2022-09-24 12:14 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-kernel, devicetree, linux-kernel, Marek Behún
PING?
On Thursday 25 August 2022 14:21:02 Pali Rohár wrote:
> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
> };
> };
>
> - /* port 6 is connected to eth0 */
> + ports@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <ð0>;
> + phy-mode = "rgmii-id";
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> };
> };
> };
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node
2022-09-24 12:14 ` Pali Rohár
@ 2022-09-24 14:43 ` Andrew Lunn
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2022-09-24 14:43 UTC (permalink / raw)
To: Pali Rohár
Cc: Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel,
Marek Behún
On Sat, Sep 24, 2022 at 02:14:00PM +0200, Pali Rohár wrote:
> PING?
You would do better reposting, adding my Reviewed-by:.
My _guess_ would be, any patch which Gregory receives which already
has a reviewed-by: on it, will get picked up immediately.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node
2022-08-25 12:21 [PATCH] ARM: dts: turris-omnia: Add switch port 6 node Pali Rohár
2022-08-27 18:41 ` Andrew Lunn
2022-09-24 12:14 ` Pali Rohár
@ 2022-11-01 22:41 ` Pali Rohár
2022-11-28 0:01 ` Gregory CLEMENT
3 siblings, 0 replies; 8+ messages in thread
From: Pali Rohár @ 2022-11-01 22:41 UTC (permalink / raw)
To: Gregory Clement; +Cc: linux-arm-kernel, devicetree, linux-kernel
PING?
On Thursday 25 August 2022 14:21:02 Pali Rohár wrote:
> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
> };
> };
>
> - /* port 6 is connected to eth0 */
> + ports@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <ð0>;
> + phy-mode = "rgmii-id";
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> };
> };
> };
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node
2022-08-25 12:21 [PATCH] ARM: dts: turris-omnia: Add switch port 6 node Pali Rohár
` (2 preceding siblings ...)
2022-11-01 22:41 ` Pali Rohár
@ 2022-11-28 0:01 ` Gregory CLEMENT
3 siblings, 0 replies; 8+ messages in thread
From: Gregory CLEMENT @ 2022-11-28 0:01 UTC (permalink / raw)
To: Pali Rohár, Andrew Lunn, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-kernel, devicetree, linux-kernel, Marek Behún
Pali Rohár <pali@kernel.org> writes:
> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
> };
> };
>
> - /* port 6 is connected to eth0 */
> + ports@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <ð0>;
> + phy-mode = "rgmii-id";
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> };
> };
> };
> --
> 2.20.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-28 0:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-25 12:21 [PATCH] ARM: dts: turris-omnia: Add switch port 6 node Pali Rohár
2022-08-27 18:41 ` Andrew Lunn
2022-08-27 18:45 ` Pali Rohár
2022-08-27 18:55 ` Andrew Lunn
2022-09-24 12:14 ` Pali Rohár
2022-09-24 14:43 ` Andrew Lunn
2022-11-01 22:41 ` Pali Rohár
2022-11-28 0:01 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).