linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Mauri Sandberg <maukka@ext.kapsi.fi>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	arnd@arndb.de, olof@lixom.net, sebastian.hesselbarth@gmail.com,
	gregory.clement@bootlin.com, linux@armlinux.org.uk,
	pali@kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] ARM: dts: orion5x: Add D-Link DNS-323 Device Tree
Date: Thu, 22 Sep 2022 22:45:47 +0200	[thread overview]
Message-ID: <YyzJe9+S83vByosb@lunn.ch> (raw)
In-Reply-To: <20220922202458.7592-3-maukka@ext.kapsi.fi>

> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +		bootargs = "console=ttyS0,115200n8 earlyprintk";

bootargs is generally not liked. Since you have stdout-path do you
need console=ttyS0,115200n8? earlyprintk should not be needed now you
have something which boots.

> +&mdio {
> +	status = "okay";
> +
> +	ethphy: ethernet-phy {
> +		reg = <8>;

Since you have a reg value, this should be ethernet-phy@9

      Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-09-22 20:47 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 16:21 [RFC RFT PATCH v1 0/1] ARM: orion5x: convert D-Link DNS-323 to the Device Tree Mauri Sandberg
2022-04-27 16:21 ` [RFC RFT PATCH v1 1/1] " Mauri Sandberg
2022-04-27 18:12   ` Arnd Bergmann
2022-04-28 20:06     ` Mauri Sandberg
2022-04-28 20:47       ` Arnd Bergmann
2022-04-28  7:13   ` Krzysztof Kozlowski
2022-04-28 20:09     ` Mauri Sandberg
2022-04-27 18:10 ` [RFC RFT PATCH v1 0/1] " Arnd Bergmann
2022-04-28  0:18   ` Andrew Lunn
2022-04-28 20:25     ` Mauri Sandberg
2022-04-28 23:26       ` Andrew Lunn
2022-05-03  8:20         ` Mauri Sandberg
2022-04-28 20:01   ` Mauri Sandberg
2022-04-28 20:56     ` Arnd Bergmann
2022-05-08 14:06       ` Mauri Sandberg
2022-05-08 15:02         ` Arnd Bergmann
2022-05-08 15:22           ` Pali Rohár
2022-05-08 15:41             ` Pali Rohár
2022-05-09  7:21               ` Arnd Bergmann
2022-05-09 10:48               ` Mauri Sandberg
2022-05-09 11:03                 ` Pali Rohár
2022-05-08 19:34             ` Mauri Sandberg
2022-05-08 20:10               ` Pali Rohár
2022-05-09 10:52                 ` Mauri Sandberg
2022-04-28  0:29 ` Andrew Lunn
2022-09-22 20:24 ` [PATCH v2 0/3] ARM: orion5x: add D-Link DNS323 based on device treee Mauri Sandberg
2022-09-22 20:24   ` [PATCH v2 1/3] dt-bindings: arm: add DT binding for D-Link DNS-323 Mauri Sandberg
2022-09-22 20:36     ` Andrew Lunn
2022-09-23  9:18     ` Krzysztof Kozlowski
2022-09-22 20:24   ` [PATCH v2 2/3] ARM: dts: orion5x: Add D-Link DNS-323 Device Tree Mauri Sandberg
2022-09-22 20:45     ` Andrew Lunn [this message]
2022-09-22 21:14       ` Pali Rohár
2022-09-22 21:32         ` Andrew Lunn
2022-09-23  9:19     ` Krzysztof Kozlowski
2022-09-22 20:24   ` [PATCH v2 3/3] ARM: orion5x: Add D-Link DNS-323 based on " Mauri Sandberg
2022-09-22 21:10     ` Andrew Lunn
2022-09-23  9:03       ` maukka
2022-09-23 12:12         ` Andrew Lunn
2022-09-23 18:02           ` Pali Rohár
2022-09-26 11:56             ` maukka
2022-09-22 21:39     ` Arnd Bergmann
2022-09-23  9:13       ` maukka
2022-09-23  9:24         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyzJe9+S83vByosb@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maukka@ext.kapsi.fi \
    --cc=olof@lixom.net \
    --cc=pali@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).