From: Mauri Sandberg <maukka@ext.kapsi.fi>
To: Arnd Bergmann <arnd@arndb.de>
Cc: SoC Team <soc@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
DTML <devicetree@vger.kernel.org>,
Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
maukka@ext.kapsi.fi
Subject: Re: [RFC RFT PATCH v1 1/1] ARM: orion5x: convert D-Link DNS-323 to the Device Tree
Date: Thu, 28 Apr 2022 23:06:32 +0300 [thread overview]
Message-ID: <d8ab7986-c0a8-e11f-3599-a09c2938d936@ext.kapsi.fi> (raw)
In-Reply-To: <CAK8P3a2renoWK+rUYBAyUb10v-TKfv6gLTQUiGFRroFgLCv+9w@mail.gmail.com>
On 27.4.2022 21.12, Arnd Bergmann wrote:
> On Wed, Apr 27, 2022 at 6:21 PM Mauri Sandberg <maukka@ext.kapsi.fi> wrote:
>>
>> Convert D-Link DNS-323 to use the device tree and remove associated
>> mach file.
>>
>> Signed-off-by: Mauri Sandberg <maukka@ext.kapsi.fi>
>> ---
>> arch/arm/boot/dts/Makefile | 3 +
>> arch/arm/boot/dts/orion5x-dlink-dns323.dtsi | 217 ++++++
>> arch/arm/boot/dts/orion5x-dlink-dns323a1.dts | 59 ++
>> arch/arm/boot/dts/orion5x-dlink-dns323b1.dts | 38 +
>> arch/arm/boot/dts/orion5x-dlink-dns323c1.dts | 80 ++
>> arch/arm/mach-orion5x/Kconfig | 6 +-
>> arch/arm/mach-orion5x/Makefile | 2 +-
>> arch/arm/mach-orion5x/board-dns323.c | 118 +++
>> arch/arm/mach-orion5x/board-dt.c | 3 +
>> arch/arm/mach-orion5x/common.h | 6 +
>> arch/arm/mach-orion5x/dns323-setup.c | 724 -------------------
>> 11 files changed, 528 insertions(+), 728 deletions(-)
>> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323.dtsi
>> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323a1.dts
>> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323b1.dts
>> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323c1.dts
>> create mode 100644 arch/arm/mach-orion5x/board-dns323.c
>> delete mode 100644 arch/arm/mach-orion5x/dns323-setup.c
>
> Having the combined patch is generally fine for review, but for actually
> merging it, I would prefer splitting the new DT from the code removal,
> as I send these through different trees to Linus.
You know, I had them initially in separate patches but then I looked at
the existing commit history and at least a few ones were in a single
commit so I merged them. :)
Will split this in two in the next iteration.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-28 20:07 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 16:21 [RFC RFT PATCH v1 0/1] ARM: orion5x: convert D-Link DNS-323 to the Device Tree Mauri Sandberg
2022-04-27 16:21 ` [RFC RFT PATCH v1 1/1] " Mauri Sandberg
2022-04-27 18:12 ` Arnd Bergmann
2022-04-28 20:06 ` Mauri Sandberg [this message]
2022-04-28 20:47 ` Arnd Bergmann
2022-04-28 7:13 ` Krzysztof Kozlowski
2022-04-28 20:09 ` Mauri Sandberg
2022-04-27 18:10 ` [RFC RFT PATCH v1 0/1] " Arnd Bergmann
2022-04-28 0:18 ` Andrew Lunn
2022-04-28 20:25 ` Mauri Sandberg
2022-04-28 23:26 ` Andrew Lunn
2022-05-03 8:20 ` Mauri Sandberg
2022-04-28 20:01 ` Mauri Sandberg
2022-04-28 20:56 ` Arnd Bergmann
2022-05-08 14:06 ` Mauri Sandberg
2022-05-08 15:02 ` Arnd Bergmann
2022-05-08 15:22 ` Pali Rohár
2022-05-08 15:41 ` Pali Rohár
2022-05-09 7:21 ` Arnd Bergmann
2022-05-09 10:48 ` Mauri Sandberg
2022-05-09 11:03 ` Pali Rohár
2022-05-08 19:34 ` Mauri Sandberg
2022-05-08 20:10 ` Pali Rohár
2022-05-09 10:52 ` Mauri Sandberg
2022-04-28 0:29 ` Andrew Lunn
2022-09-22 20:24 ` [PATCH v2 0/3] ARM: orion5x: add D-Link DNS323 based on device treee Mauri Sandberg
2022-09-22 20:24 ` [PATCH v2 1/3] dt-bindings: arm: add DT binding for D-Link DNS-323 Mauri Sandberg
2022-09-22 20:36 ` Andrew Lunn
2022-09-23 9:18 ` Krzysztof Kozlowski
2022-09-22 20:24 ` [PATCH v2 2/3] ARM: dts: orion5x: Add D-Link DNS-323 Device Tree Mauri Sandberg
2022-09-22 20:45 ` Andrew Lunn
2022-09-22 21:14 ` Pali Rohár
2022-09-22 21:32 ` Andrew Lunn
2022-09-23 9:19 ` Krzysztof Kozlowski
2022-09-22 20:24 ` [PATCH v2 3/3] ARM: orion5x: Add D-Link DNS-323 based on " Mauri Sandberg
2022-09-22 21:10 ` Andrew Lunn
2022-09-23 9:03 ` maukka
2022-09-23 12:12 ` Andrew Lunn
2022-09-23 18:02 ` Pali Rohár
2022-09-26 11:56 ` maukka
2022-09-22 21:39 ` Arnd Bergmann
2022-09-23 9:13 ` maukka
2022-09-23 9:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8ab7986-c0a8-e11f-3599-a09c2938d936@ext.kapsi.fi \
--to=maukka@ext.kapsi.fi \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).