linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: kirkwood: Add drivetemp thermal zone in Ctera C200V1
@ 2022-09-29  8:02 Pawel Dembicki
  2022-09-29 12:54 ` Andrew Lunn
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Pawel Dembicki @ 2022-09-29  8:02 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, Gregory Clement, Andrew Lunn
  Cc: Pawel Dembicki, Linus Walleij

Ctera C200 V1 have two SATA bays, but thermal zone is handled for only one.
For some reason thermal zone works only with first disk.
It was reported one year ago [1].

[1] https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg56599.html

Suggested-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
---
 arch/arm/boot/dts/kirkwood-c200-v1.dts | 37 ++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/arch/arm/boot/dts/kirkwood-c200-v1.dts b/arch/arm/boot/dts/kirkwood-c200-v1.dts
index f59ff7578dfc..ffe60150a67a 100644
--- a/arch/arm/boot/dts/kirkwood-c200-v1.dts
+++ b/arch/arm/boot/dts/kirkwood-c200-v1.dts
@@ -156,6 +156,31 @@ led-12 {
 			trigger-sources = <&hub_port1>;
 		};
 	};
+
+	thermal-zones {
+		/* Thermal zone works only with first disk */
+
+		disk0-thermal {
+			polling-delay = <20000>;
+			polling-delay-passive = <2000>;
+
+			thermal-sensors = <&hdd0_temp>;
+
+			/* Tripping points from the fan.script in the rootfs */
+			trips {
+				disk0_alert: disk0-alert {
+					temperature = <40000>;
+					hysteresis = <5000>;
+					type = "active";
+				};
+				disk0_crit: disk0-crit {
+					temperature = <60000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+	};
 };
 
 &eth0 {
@@ -280,6 +305,18 @@ &rtc {
 &sata {
 	status = "okay";
 	nr-ports = <2>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	hdd0_temp: sata-port@0 {
+		reg = <0>;
+		#thermal-sensor-cells = <0>;
+	};
+
+	hdd1_temp: sata-port@1 {
+		reg = <1>;
+		#thermal-sensor-cells = <0>;
+	};
 };
 
 &uart0 {
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: kirkwood: Add drivetemp thermal zone in Ctera C200V1
  2022-09-29  8:02 [PATCH] ARM: dts: kirkwood: Add drivetemp thermal zone in Ctera C200V1 Pawel Dembicki
@ 2022-09-29 12:54 ` Andrew Lunn
  2022-10-04  8:02 ` Linus Walleij
  2022-11-29 22:23 ` Paweł Dembicki
  2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2022-09-29 12:54 UTC (permalink / raw)
  To: Pawel Dembicki
  Cc: devicetree, linux-arm-kernel, Gregory Clement, Linus Walleij

On Thu, Sep 29, 2022 at 10:02:10AM +0200, Pawel Dembicki wrote:
> Ctera C200 V1 have two SATA bays, but thermal zone is handled for only one.
> For some reason thermal zone works only with first disk.
> It was reported one year ago [1].
> 
> [1] https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg56599.html
> 
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: kirkwood: Add drivetemp thermal zone in Ctera C200V1
  2022-09-29  8:02 [PATCH] ARM: dts: kirkwood: Add drivetemp thermal zone in Ctera C200V1 Pawel Dembicki
  2022-09-29 12:54 ` Andrew Lunn
@ 2022-10-04  8:02 ` Linus Walleij
  2022-11-29 22:23 ` Paweł Dembicki
  2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2022-10-04  8:02 UTC (permalink / raw)
  To: Pawel Dembicki, Gregory Clement, Sebastian Hesselbarth, Andrew Lunn
  Cc: devicetree, linux-arm-kernel

On Thu, Sep 29, 2022 at 10:02 AM Pawel Dembicki <paweldembicki@gmail.com> wrote:

> Ctera C200 V1 have two SATA bays, but thermal zone is handled for only one.
> For some reason thermal zone works only with first disk.
> It was reported one year ago [1].
>
> [1] https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg56599.html
>
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>

Excellent patch!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: kirkwood: Add drivetemp thermal zone in Ctera C200V1
  2022-09-29  8:02 [PATCH] ARM: dts: kirkwood: Add drivetemp thermal zone in Ctera C200V1 Pawel Dembicki
  2022-09-29 12:54 ` Andrew Lunn
  2022-10-04  8:02 ` Linus Walleij
@ 2022-11-29 22:23 ` Paweł Dembicki
  2 siblings, 0 replies; 4+ messages in thread
From: Paweł Dembicki @ 2022-11-29 22:23 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, Gregory Clement, Andrew Lunn; +Cc: Linus Walleij

czw., 29 wrz 2022 o 10:02 Pawel Dembicki <paweldembicki@gmail.com> napisał(a):
>
> Ctera C200 V1 have two SATA bays, but thermal zone is handled for only one.
> For some reason thermal zone works only with first disk.
> It was reported one year ago [1].
>
> [1] https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg56599.html
>
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>

Hi all,

Gentle reminder for this patch. Is something blocking it?

Best Regards,
Paweł Dembicki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-11-29 22:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29  8:02 [PATCH] ARM: dts: kirkwood: Add drivetemp thermal zone in Ctera C200V1 Pawel Dembicki
2022-09-29 12:54 ` Andrew Lunn
2022-10-04  8:02 ` Linus Walleij
2022-11-29 22:23 ` Paweł Dembicki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).