* [PATCH] RM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port
@ 2022-09-29 19:13 Dmitry Torokhov
2022-09-30 6:30 ` Patrice CHOTARD
2022-09-30 11:22 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2022-09-29 19:13 UTC (permalink / raw)
To: Patrice Chotard
Cc: Rob Herring, Krzysztof Kozlowski, Alain Volmat, linux-arm-kernel,
devicetree, linux-kernel
According to c8sectpfe driver code we first drive reset line low and
then high to reset the port, therefore the reset line is supposed to
be annotated as "active low". This will be important when we convert
the driver to gpiod API.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
index 2aa94605d3d4..d52a7aaa1074 100644
--- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
+++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
@@ -178,7 +178,7 @@ tsin0: port {
tsin-num = <0>;
serial-not-parallel;
i2c-bus = <&ssc2>;
- reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>;
dvb-card = <STV0367_TDA18212_NIMA_1>;
};
};
--
2.38.0.rc1.362.ged0d419d3c-goog
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port
2022-09-29 19:13 [PATCH] RM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port Dmitry Torokhov
@ 2022-09-30 6:30 ` Patrice CHOTARD
2022-09-30 11:22 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Patrice CHOTARD @ 2022-09-30 6:30 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Rob Herring, Krzysztof Kozlowski, Alain Volmat, linux-arm-kernel,
devicetree, linux-kernel
Hi Dmitry
On 9/29/22 21:13, Dmitry Torokhov wrote:
> According to c8sectpfe driver code we first drive reset line low and
> then high to reset the port, therefore the reset line is supposed to
> be annotated as "active low". This will be important when we convert
> the driver to gpiod API.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> index 2aa94605d3d4..d52a7aaa1074 100644
> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> @@ -178,7 +178,7 @@ tsin0: port {
> tsin-num = <0>;
> serial-not-parallel;
> i2c-bus = <&ssc2>;
> - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>;
> dvb-card = <STV0367_TDA18212_NIMA_1>;
> };
> };
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port
2022-09-29 19:13 [PATCH] RM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port Dmitry Torokhov
2022-09-30 6:30 ` Patrice CHOTARD
@ 2022-09-30 11:22 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-30 11:22 UTC (permalink / raw)
To: Dmitry Torokhov, Patrice Chotard
Cc: Rob Herring, Krzysztof Kozlowski, Alain Volmat, linux-arm-kernel,
devicetree, linux-kernel
On 29/09/2022 21:13, Dmitry Torokhov wrote:
> According to c8sectpfe driver code we first drive reset line low and
> then high to reset the port, therefore the reset line is supposed to
> be annotated as "active low". This will be important when we convert
> the driver to gpiod API.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Typo in subject - s/RM/ARM/
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-30 11:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29 19:13 [PATCH] RM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port Dmitry Torokhov
2022-09-30 6:30 ` Patrice CHOTARD
2022-09-30 11:22 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).