* [PATCH] ARM: dts: vf610-zii-dev-rev-c: fix polarity of at86rf233 reset line
@ 2022-09-30 18:23 Dmitry Torokhov
2022-10-24 2:04 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2022-09-30 18:23 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer
Cc: Pengutronix Kernel Team, Stefan Agner, Rob Herring,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel
at86rf230 driver starts with having reset line high, and then drives it
low and then high again, and even calls it "rstn" internally, therefore
it needs to be annotated as "active low" in the DTS.
This will make difference when at86rf230 driver will be converted to
gpiod API that respects declared line polarity.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
index de79dcfd32e6..f892977da9e4 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
@@ -259,7 +259,7 @@ atzb-rf-233@1 {
xtal-trim = /bits/ 8 <0x06>;
sleep-gpio = <&gpio0 24 GPIO_ACTIVE_HIGH>;
- reset-gpio = <&gpio6 10 GPIO_ACTIVE_HIGH>;
+ reset-gpio = <&gpio6 10 GPIO_ACTIVE_LOW>;
fsl,spi-cs-sck-delay = <180>;
fsl,spi-sck-cs-delay = <250>;
--
2.38.0.rc1.362.ged0d419d3c-goog
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-dev-rev-c: fix polarity of at86rf233 reset line
2022-09-30 18:23 [PATCH] ARM: dts: vf610-zii-dev-rev-c: fix polarity of at86rf233 reset line Dmitry Torokhov
@ 2022-10-24 2:04 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2022-10-24 2:04 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Sascha Hauer, Pengutronix Kernel Team, Stefan Agner, Rob Herring,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel
On Fri, Sep 30, 2022 at 11:23:03AM -0700, Dmitry Torokhov wrote:
> at86rf230 driver starts with having reset line high, and then drives it
> low and then high again, and even calls it "rstn" internally, therefore
> it needs to be annotated as "active low" in the DTS.
>
> This will make difference when at86rf230 driver will be converted to
> gpiod API that respects declared line polarity.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-24 2:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-30 18:23 [PATCH] ARM: dts: vf610-zii-dev-rev-c: fix polarity of at86rf233 reset line Dmitry Torokhov
2022-10-24 2:04 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).