* [PATCH] ARM: davinci: fix kconfig dependency warning when !GPIOLIB
@ 2020-09-14 14:19 Necip Fazil Yildiran
2020-09-28 18:13 ` Sekhar Nori
0 siblings, 1 reply; 2+ messages in thread
From: Necip Fazil Yildiran @ 2020-09-14 14:19 UTC (permalink / raw)
To: nsekhar
Cc: geert+renesas, arnd, paul, Necip Fazil Yildiran, linux-kernel,
bgolaszewski, jeho, linux-arm-kernel
When MACH_DAVINCI_DA830_EVM is enabled and GPIOLIB is disabled, it results
in the following Kbuild warning:
WARNING: unmet direct dependencies detected for GPIO_PCF857X
Depends on [n]: GPIOLIB [=n] && I2C [=y]
Selected by [y]:
- MACH_DAVINCI_DA830_EVM [=y] && ARCH_DAVINCI [=y] && ARCH_DAVINCI_DA830 [=y] && I2C [=y]
The reason is that MACH_DAVINCI_DA830_EVM selects GPIO_PCF857X without
depending on or selecting GPIOLIB while GPIO_PCF857X is subordinate to
GPIOLIB.
Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
Fixes: 77316f057526 ("davinci: DA830/OMAP-L137 EVM: use runtime detection for UI card")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
---
arch/arm/mach-davinci/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index e0cbcda6f087..3a6307d85828 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -130,6 +130,7 @@ config MACH_DAVINCI_DA830_EVM
bool "TI DA830/OMAP-L137/AM17x Reference Platform"
default ARCH_DAVINCI_DA830
depends on ARCH_DAVINCI_DA830
+ select GPIOLIB if I2C
select GPIO_PCF857X if I2C
help
Say Y here to select the TI DA830/OMAP-L137/AM17x Evaluation Module.
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: davinci: fix kconfig dependency warning when !GPIOLIB
2020-09-14 14:19 [PATCH] ARM: davinci: fix kconfig dependency warning when !GPIOLIB Necip Fazil Yildiran
@ 2020-09-28 18:13 ` Sekhar Nori
0 siblings, 0 replies; 2+ messages in thread
From: Sekhar Nori @ 2020-09-28 18:13 UTC (permalink / raw)
To: Necip Fazil Yildiran
Cc: geert+renesas, arnd, paul, linux-kernel, bgolaszewski, jeho,
linux-arm-kernel
On 14/09/20 7:49 PM, Necip Fazil Yildiran wrote:
> When MACH_DAVINCI_DA830_EVM is enabled and GPIOLIB is disabled, it results
> in the following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for GPIO_PCF857X
> Depends on [n]: GPIOLIB [=n] && I2C [=y]
> Selected by [y]:
> - MACH_DAVINCI_DA830_EVM [=y] && ARCH_DAVINCI [=y] && ARCH_DAVINCI_DA830 [=y] && I2C [=y]
>
> The reason is that MACH_DAVINCI_DA830_EVM selects GPIO_PCF857X without
> depending on or selecting GPIOLIB while GPIO_PCF857X is subordinate to
> GPIOLIB.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: 77316f057526 ("davinci: DA830/OMAP-L137 EVM: use runtime detection for UI card")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Here too, I think changing to "imply GPIO_PCF857X if I2C" is better.
Thanks,
Sekhar
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-28 18:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 14:19 [PATCH] ARM: davinci: fix kconfig dependency warning when !GPIOLIB Necip Fazil Yildiran
2020-09-28 18:13 ` Sekhar Nori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).