From: Marc Zyngier <maz@kernel.org>
To: Jianyong Wu <jianyong.wu@arm.com>
Cc: mark.rutland@arm.com, justin.he@arm.com, kvm@vger.kernel.org,
suzuki.poulose@arm.com, netdev@vger.kernel.org,
richardcochran@gmail.com, steve.capper@arm.com,
linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com,
kaly.xin@arm.com, john.stultz@linaro.org, yangbo.lu@nxp.com,
pbonzini@redhat.com, tglx@linutronix.de, nd@arm.com,
will@kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v8 3/8] ptp: Reorganize ptp_kvm modules to make it arch-independent.
Date: Mon, 25 Nov 2019 15:47:40 +0000 [thread overview]
Message-ID: <a13a4f9554f36a46781308358fc63519@www.loen.fr> (raw)
In-Reply-To: <20191125104506.36850-4-jianyong.wu@arm.com>
On 2019-11-25 10:45, Jianyong Wu wrote:
> Currently, ptp_kvm modules implementation is only for x86 which
> includs
> large part of arch-specific code. This patch move all of those code
> into new arch related file in the same directory.
>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> ---
> drivers/ptp/Makefile | 1 +
> drivers/ptp/{ptp_kvm.c => ptp_kvm_common.c} | 77 +++++-------------
> drivers/ptp/ptp_kvm_x86.c | 87
> +++++++++++++++++++++
> include/asm-generic/ptp_kvm.h | 12 +++
> 4 files changed, 118 insertions(+), 59 deletions(-)
> rename drivers/ptp/{ptp_kvm.c => ptp_kvm_common.c} (63%)
> create mode 100644 drivers/ptp/ptp_kvm_x86.c
> create mode 100644 include/asm-generic/ptp_kvm.h
[...]
> diff --git a/include/asm-generic/ptp_kvm.h
> b/include/asm-generic/ptp_kvm.h
> new file mode 100644
> index 000000000000..e5dd386f6664
> --- /dev/null
> +++ b/include/asm-generic/ptp_kvm.h
> @@ -0,0 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Virtual PTP 1588 clock for use with KVM guests
> + *
> + * Copyright (C) 2019 ARM Ltd.
I think you should live the original copyright assignment here.
This really isn't anything new.
> + * All Rights Reserved
> + */
> +
> +int kvm_arch_ptp_init(void);
> +int kvm_arch_ptp_get_clock(struct timespec64 *ts);
> +int kvm_arch_ptp_get_crosststamp(unsigned long *cycle,
> + struct timespec64 *tspec, void *cs);
Why is this include file in asm-generic? This isn't a kernel-wide API.
I think it should be sitting in drivers/ptp, as it is only shared
between
the generic and arch-specific stuff.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-25 15:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 10:44 [RFC PATCH v8 0/7] Enable ptp_kvm for arm64 Jianyong Wu
2019-11-25 10:44 ` [RFC PATCH v8 1/8] arm/arm64: smccc/psci: add arm_smccc_1_1_get_conduit() Jianyong Wu
2019-11-25 10:45 ` [RFC PATCH v8 2/8] psci: let arm_smccc_1_1_invoke available by modules Jianyong Wu
2019-11-25 10:45 ` [RFC PATCH v8 3/8] ptp: Reorganize ptp_kvm modules to make it arch-independent Jianyong Wu
2019-11-25 15:47 ` Marc Zyngier [this message]
2019-11-26 8:30 ` Jianyong Wu (Arm Technology China)
2019-11-25 10:45 ` [RFC PATCH v8 4/8] time: Add mechanism to recognize clocksource in time_get_snapshot Jianyong Wu
2019-11-25 10:45 ` [RFC PATCH v8 5/8] clocksource: Add clocksource id for arm arch counter Jianyong Wu
2019-11-25 10:45 ` [RFC PATCH v8 6/8] psci: Add hvc call service for ptp_kvm Jianyong Wu
2019-11-25 10:45 ` [RFC PATCH v8 7/8] ptp: arm64: Enable ptp_kvm for arm64 Jianyong Wu
2019-11-25 10:45 ` [RFC PATCH v8 8/8] kvm: arm64: Add capability check extension for ptp_kvm Jianyong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a13a4f9554f36a46781308358fc63519@www.loen.fr \
--to=maz@kernel.org \
--cc=jianyong.wu@arm.com \
--cc=john.stultz@linaro.org \
--cc=justin.he@arm.com \
--cc=kaly.xin@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nd@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sean.j.christopherson@intel.com \
--cc=steve.capper@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).