* [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen
@ 2019-12-12 16:02 Sjoerd Simons
2019-12-12 16:07 ` Marco Felsch
0 siblings, 1 reply; 6+ messages in thread
From: Sjoerd Simons @ 2019-12-12 16:02 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Mark Rutland, devicetree, Shawn Guo, Sascha Hauer, linux-kernel,
Rob Herring, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam
Sabrelite boards can have an lvds screen attached with a built-in i2c touch
screen. Enable this in the dtsi.
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
index 8468216dae9b..382b127b2251 100644
--- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
@@ -416,6 +416,14 @@ &i2c3 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c3>;
status = "okay";
+
+ touchscreen@4 {
+ compatible = "eeti,egalax_ts";
+ reg = <0x04>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
+ wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
+ };
};
&iomuxc {
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen
2019-12-12 16:02 [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen Sjoerd Simons
@ 2019-12-12 16:07 ` Marco Felsch
2019-12-12 16:22 ` Sjoerd Simons
2019-12-12 16:23 ` Marco Felsch
0 siblings, 2 replies; 6+ messages in thread
From: Marco Felsch @ 2019-12-12 16:07 UTC (permalink / raw)
To: Sjoerd Simons
Cc: Mark Rutland, devicetree, Fabio Estevam, Sascha Hauer,
linux-kernel, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Shawn Guo, linux-arm-kernel
Hi Sjoerd,
On 19-12-12 17:02, Sjoerd Simons wrote:
> Sabrelite boards can have an lvds screen attached with a built-in i2c touch
> screen. Enable this in the dtsi.
Can this be any screen available on the market?
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>
> arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> index 8468216dae9b..382b127b2251 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> @@ -416,6 +416,14 @@ &i2c3 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_i2c3>;
> status = "okay";
> +
> + touchscreen@4 {
> + compatible = "eeti,egalax_ts";
> + reg = <0x04>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> + wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
The wakeup-gpio and the irq-line are sharing the same gpio line?
Regards,
Marco
> + };
> };
>
> &iomuxc {
> --
> 2.24.0
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen
2019-12-12 16:07 ` Marco Felsch
@ 2019-12-12 16:22 ` Sjoerd Simons
2019-12-12 16:25 ` Marco Felsch
2019-12-12 16:23 ` Marco Felsch
1 sibling, 1 reply; 6+ messages in thread
From: Sjoerd Simons @ 2019-12-12 16:22 UTC (permalink / raw)
To: Marco Felsch
Cc: Mark Rutland, devicetree, Fabio Estevam, Sascha Hauer,
linux-kernel, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Shawn Guo, linux-arm-kernel
On Thu, 2019-12-12 at 17:07 +0100, Marco Felsch wrote:
> Hi Sjoerd,
>
> On 19-12-12 17:02, Sjoerd Simons wrote:
> > Sabrelite boards can have an lvds screen attached with a built-in
> > i2c touch
> > screen. Enable this in the dtsi.
>
> Can this be any screen available on the market?
I guess i should have been more clear here; This is the touchscreen in
the hannstar display (already part of the dts) that was sold as an
accessoiry to the sabrelite.
Same as the screen that can be used on the boundary nitrogen6 boards
(which do have the touch part already enabled in the dts)
>
> > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> > ---
> >
> > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > index 8468216dae9b..382b127b2251 100644
> > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > @@ -416,6 +416,14 @@ &i2c3 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_i2c3>;
> > status = "okay";
> > +
> > + touchscreen@4 {
> > + compatible = "eeti,egalax_ts";
> > + reg = <0x04>;
> > + interrupt-parent = <&gpio1>;
> > + interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> > + wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
>
> The wakeup-gpio and the irq-line are sharing the same gpio line?
>
> Regards,
> Marco
>
> > + };
> > };
> >
> > &iomuxc {
> > --
> > 2.24.0
> >
> >
> >
--
Sjoerd Simons
Collabora Ltd.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen
2019-12-12 16:07 ` Marco Felsch
2019-12-12 16:22 ` Sjoerd Simons
@ 2019-12-12 16:23 ` Marco Felsch
1 sibling, 0 replies; 6+ messages in thread
From: Marco Felsch @ 2019-12-12 16:23 UTC (permalink / raw)
To: Sjoerd Simons
Cc: Mark Rutland, devicetree, Shawn Guo, Sascha Hauer, linux-kernel,
Rob Herring, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, linux-arm-kernel
On 19-12-12 17:07, Marco Felsch wrote:
> Hi Sjoerd,
>
> On 19-12-12 17:02, Sjoerd Simons wrote:
> > Sabrelite boards can have an lvds screen attached with a built-in i2c touch
> > screen. Enable this in the dtsi.
>
> Can this be any screen available on the market?
At least you should adapt the title to: "ARM: dts: imx6qdl-sabrelite: ..."
Regards,
Marco
>
> > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> > ---
> >
> > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > index 8468216dae9b..382b127b2251 100644
> > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > @@ -416,6 +416,14 @@ &i2c3 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_i2c3>;
> > status = "okay";
> > +
> > + touchscreen@4 {
> > + compatible = "eeti,egalax_ts";
> > + reg = <0x04>;
> > + interrupt-parent = <&gpio1>;
> > + interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> > + wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
>
> The wakeup-gpio and the irq-line are sharing the same gpio line?
>
> Regards,
> Marco
>
> > + };
> > };
> >
> > &iomuxc {
> > --
> > 2.24.0
> >
> >
> >
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen
2019-12-12 16:22 ` Sjoerd Simons
@ 2019-12-12 16:25 ` Marco Felsch
2019-12-13 9:03 ` Sjoerd Simons
0 siblings, 1 reply; 6+ messages in thread
From: Marco Felsch @ 2019-12-12 16:25 UTC (permalink / raw)
To: Sjoerd Simons
Cc: Mark Rutland, devicetree, Fabio Estevam, Sascha Hauer,
linux-kernel, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Shawn Guo, linux-arm-kernel
On 19-12-12 17:22, Sjoerd Simons wrote:
> On Thu, 2019-12-12 at 17:07 +0100, Marco Felsch wrote:
> > Hi Sjoerd,
> >
> > On 19-12-12 17:02, Sjoerd Simons wrote:
> > > Sabrelite boards can have an lvds screen attached with a built-in
> > > i2c touch
> > > screen. Enable this in the dtsi.
> >
> > Can this be any screen available on the market?
>
> I guess i should have been more clear here; This is the touchscreen in
> the hannstar display (already part of the dts) that was sold as an
> accessoiry to the sabrelite.
That is more clear =) Pls can you add this to the commit message?
>
> Same as the screen that can be used on the boundary nitrogen6 boards
> (which do have the touch part already enabled in the dts)
>
> >
> > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> > > ---
> > >
> > > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > > b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > > index 8468216dae9b..382b127b2251 100644
> > > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > > @@ -416,6 +416,14 @@ &i2c3 {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&pinctrl_i2c3>;
> > > status = "okay";
> > > +
> > > + touchscreen@4 {
> > > + compatible = "eeti,egalax_ts";
> > > + reg = <0x04>;
> > > + interrupt-parent = <&gpio1>;
> > > + interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> > > + wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
> >
> > The wakeup-gpio and the irq-line are sharing the same gpio line?
Lastly should we add a own pinctrl entry for the touchscreen?
Regards,
Marco
> >
> > Regards,
> > Marco
> >
> > > + };
> > > };
> > >
> > > &iomuxc {
> > > --
> > > 2.24.0
> > >
> > >
> > >
> --
> Sjoerd Simons
> Collabora Ltd.
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen
2019-12-12 16:25 ` Marco Felsch
@ 2019-12-13 9:03 ` Sjoerd Simons
0 siblings, 0 replies; 6+ messages in thread
From: Sjoerd Simons @ 2019-12-13 9:03 UTC (permalink / raw)
To: Marco Felsch
Cc: Mark Rutland, devicetree, Fabio Estevam, Sascha Hauer,
linux-kernel, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Shawn Guo, linux-arm-kernel
On Thu, 2019-12-12 at 17:25 +0100, Marco Felsch wrote:
> On 19-12-12 17:22, Sjoerd Simons wrote:
> > On Thu, 2019-12-12 at 17:07 +0100, Marco Felsch wrote:
> > > Hi Sjoerd,
> > >
> > > On 19-12-12 17:02, Sjoerd Simons wrote:
> > > > Sabrelite boards can have an lvds screen attached with a built-
> > > > in
> > > > i2c touch
> > > > screen. Enable this in the dtsi.
> > >
> > > Can this be any screen available on the market?
> >
> > I guess i should have been more clear here; This is the touchscreen
> > in
> > the hannstar display (already part of the dts) that was sold as an
> > accessoiry to the sabrelite.
>
> That is more clear =) Pls can you add this to the commit message?
Ofcourse will do; You also made me dig up the model number etc so i'll
include that information.
> > Same as the screen that can be used on the boundary nitrogen6
> > boards
> > (which do have the touch part already enabled in the dts)
> >
> > > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> > > > ---
> > > >
> > > > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++
> > > > 1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > > > b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > > > index 8468216dae9b..382b127b2251 100644
> > > > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > > > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > > > @@ -416,6 +416,14 @@ &i2c3 {
> > > > pinctrl-names = "default";
> > > > pinctrl-0 = <&pinctrl_i2c3>;
> > > > status = "okay";
> > > > +
> > > > + touchscreen@4 {
> > > > + compatible = "eeti,egalax_ts";
> > > > + reg = <0x04>;
> > > > + interrupt-parent = <&gpio1>;
> > > > + interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> > > > + wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
> > >
> > > The wakeup-gpio and the irq-line are sharing the same gpio line?
>
> Lastly should we add a own pinctrl entry for the touchscreen?
Would probably make sense to do that indeed; Will have a look
Thanks for the review!
--
Sjoerd Simons
Collabora Ltd.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-13 9:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 16:02 [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen Sjoerd Simons
2019-12-12 16:07 ` Marco Felsch
2019-12-12 16:22 ` Sjoerd Simons
2019-12-12 16:25 ` Marco Felsch
2019-12-13 9:03 ` Sjoerd Simons
2019-12-12 16:23 ` Marco Felsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).