From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tim Harvey <tharvey@gateworks.com>, Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH 1/2] dt-bindings: arm: Add i.MX8M Mini Gateworks GW7904 board
Date: Fri, 9 Sep 2022 10:02:53 +0200 [thread overview]
Message-ID: <a24f920b-60e2-f32b-96e5-9bafee6be8e6@kernel.org> (raw)
In-Reply-To: <CAJ+vNU1NEYWvev3s=1rPPNCRovBqa0p=JTXLHLpV7fOWf-dFLg@mail.gmail.com>
On 08/09/2022 23:44, Tim Harvey wrote:
> On Thu, Sep 8, 2022 at 2:19 PM Rob Herring <robh@kernel.org> wrote:
>>
>> On Fri, Sep 02, 2022 at 04:04:59PM -0700, Tim Harvey wrote:
>>> Add DT compatible string for i.MX8M Mini based Gateworks GW7904 board.
>>>
>>> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>> Cc: Shawn Guo <shawnguo@kernel.org>
>>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>>> Cc: Fabio Estevam <festevam@gmail.com>
>>> Cc: NXP Linux Team <linux-imx@nxp.com>
>>> ---
>>> Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> index 7431579ab0e8..ce89fac1898e 100644
>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> @@ -831,6 +831,7 @@ properties:
>>> - gw,imx8mm-gw7901 # i.MX8MM Gateworks Board
>>> - gw,imx8mm-gw7902 # i.MX8MM Gateworks Board
>>> - gw,imx8mm-gw7903 # i.MX8MM Gateworks Board
>>> + - gateworks,imx8mm-gw7904 # i.MX8MM Gateworks Board
>>
>> A useful comment would be ones that distuiguish these boards. It's
>> obvious from the compatible it's a i.MX8MM board from Gateworks.
>
> But isn't it clear that you need to go to the device-tree itself to
> understand the details?
>
> As far as basic features go sometimes there is very little difference
> in these board models. It would be a struggle to list all the board
> details (which I do in the dts commit) in a way that doesn't take up
> too much space in fsl.yaml.
>
But then the comment you added is useless. So either add useful comment
or no comment. :)
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-09 8:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 23:04 [PATCH 1/2] dt-bindings: arm: Add i.MX8M Mini Gateworks GW7904 board Tim Harvey
2022-09-02 23:05 ` [PATCH 2/2] arm64: dts: imx: Add i.mx8mm Gateworks gw7904 dts support Tim Harvey
2022-09-12 8:54 ` Shawn Guo
2022-09-12 18:16 ` Tim Harvey
2022-09-05 6:41 ` [PATCH 1/2] dt-bindings: arm: Add i.MX8M Mini Gateworks GW7904 board Krzysztof Kozlowski
2022-09-06 19:08 ` Tim Harvey
2022-09-08 21:19 ` Rob Herring
2022-09-08 21:44 ` Tim Harvey
2022-09-09 8:02 ` Krzysztof Kozlowski [this message]
2022-09-09 15:25 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a24f920b-60e2-f32b-96e5-9bafee6be8e6@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).