* [PATCH][next] i2c: xiic: fix indentation issue
@ 2020-01-26 15:42 Colin King
2020-01-27 7:43 ` Michal Simek
0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2020-01-26 15:42 UTC (permalink / raw)
To: Michal Simek, linux-arm-kernel, linux-i2c; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a statment that is indented one level too deeply, remove
the extraneous tab.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/i2c/busses/i2c-xiic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index b17d30c9ab40..90c1c362394d 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c)
xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET);
if (time_after(jiffies, timeout)) {
dev_err(i2c->dev, "Failed to clear rx fifo\n");
- return -ETIMEDOUT;
+ return -ETIMEDOUT;
}
}
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][next] i2c: xiic: fix indentation issue
2020-01-26 15:42 [PATCH][next] i2c: xiic: fix indentation issue Colin King
@ 2020-01-27 7:43 ` Michal Simek
2020-01-27 9:26 ` Colin Ian King
0 siblings, 1 reply; 4+ messages in thread
From: Michal Simek @ 2020-01-27 7:43 UTC (permalink / raw)
To: Colin King, Michal Simek, linux-arm-kernel, linux-i2c
Cc: kernel-janitors, linux-kernel
On 26. 01. 20 16:42, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a statment that is indented one level too deeply, remove
typo ^
> the extraneous tab.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/i2c/busses/i2c-xiic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index b17d30c9ab40..90c1c362394d 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c)
> xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET);
> if (time_after(jiffies, timeout)) {
> dev_err(i2c->dev, "Failed to clear rx fifo\n");
> - return -ETIMEDOUT;
> + return -ETIMEDOUT;
> }
> }
When fixed.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] i2c: xiic: fix indentation issue
2020-01-27 7:43 ` Michal Simek
@ 2020-01-27 9:26 ` Colin Ian King
2020-01-27 10:08 ` Peter Rosin
0 siblings, 1 reply; 4+ messages in thread
From: Colin Ian King @ 2020-01-27 9:26 UTC (permalink / raw)
To: Michal Simek, linux-arm-kernel, linux-i2c; +Cc: kernel-janitors, linux-kernel
On 27/01/2020 07:43, Michal Simek wrote:
> On 26. 01. 20 16:42, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is a statment that is indented one level too deeply, remove
>
> typo ^
Can this be fixed when the patch is applied rather than sending a V2?
Colin
>
>> the extraneous tab.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/i2c/busses/i2c-xiic.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
>> index b17d30c9ab40..90c1c362394d 100644
>> --- a/drivers/i2c/busses/i2c-xiic.c
>> +++ b/drivers/i2c/busses/i2c-xiic.c
>> @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c)
>> xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET);
>> if (time_after(jiffies, timeout)) {
>> dev_err(i2c->dev, "Failed to clear rx fifo\n");
>> - return -ETIMEDOUT;
>> + return -ETIMEDOUT;
>> }
>> }
>
> When fixed.
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Thanks,
> Michal
>
>
>
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] i2c: xiic: fix indentation issue
2020-01-27 9:26 ` Colin Ian King
@ 2020-01-27 10:08 ` Peter Rosin
0 siblings, 0 replies; 4+ messages in thread
From: Peter Rosin @ 2020-01-27 10:08 UTC (permalink / raw)
To: Colin Ian King, Michal Simek, linux-arm-kernel, linux-i2c
Cc: kernel-janitors, linux-kernel
On 2020-01-27 10:26, Colin Ian King wrote:
> On 27/01/2020 07:43, Michal Simek wrote:
>> On 26. 01. 20 16:42, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> There is a statment that is indented one level too deeply, remove
>>
>> typo ^
>
> Can this be fixed when the patch is applied rather than sending a V2?
It can, but I think you will make it easier for Wolfram if you send a v2.
Which is the right thing to do anyway since you are missing a Fixes tag.
I think you should have one, since it is borderline if this patch is going
to make it before 5.6.
Cheers,
Peter
> Colin
>
>>
>>> the extraneous tab.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/i2c/busses/i2c-xiic.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
>>> index b17d30c9ab40..90c1c362394d 100644
>>> --- a/drivers/i2c/busses/i2c-xiic.c
>>> +++ b/drivers/i2c/busses/i2c-xiic.c
>>> @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c)
>>> xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET);
>>> if (time_after(jiffies, timeout)) {
>>> dev_err(i2c->dev, "Failed to clear rx fifo\n");
>>> - return -ETIMEDOUT;
>>> + return -ETIMEDOUT;
>>> }
>>> }
>>
>> When fixed.
>>
>> Acked-by: Michal Simek <michal.simek@xilinx.com>
>>
>> Thanks,
>> Michal
>>
>>
>>
>>
>>
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-27 10:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-26 15:42 [PATCH][next] i2c: xiic: fix indentation issue Colin King
2020-01-27 7:43 ` Michal Simek
2020-01-27 9:26 ` Colin Ian King
2020-01-27 10:08 ` Peter Rosin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).