From: atull@opensource.altera.com (atull)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] socfpga: hotplug: put cpu1 in wfi
Date: Tue, 7 Oct 2014 09:19:00 -0500 [thread overview]
Message-ID: <alpine.DEB.2.02.1410070918000.9610@atx-linux-37> (raw)
In-Reply-To: <20141007111052.GA6904@amd>
On Tue, 7 Oct 2014, Pavel Machek wrote:
> On Wed 2014-10-01 14:38:23, atull at opensource.altera.com wrote:
> > From: Alan Tull <atull@opensource.altera.com>
> >
> > Use WFI when putting CPU1 to sleep. Don't hold CPU1 in reset
> > since that results in increased power consumption.
> >
> > Reset CPU1 briefly during CPU1 bootup.
> >
> > This has been tested for hotplug and suspend/resume and results
> > in no increased power consumption.
> >
> > Signed-off-by: Alan Tull <atull@opensource.altera.com>
>
> It is nice to Cc people who commented ont the patch before.
HI Pavel,
OK, adding you and others who commented.
>
> > if (cpu1start_addr) {
> > + /* This will put CPU #1 into reset. */
> > + __raw_writel(RSTMGR_MPUMODRST_CPU1,
> > + rst_manager_base_addr + SOCFPGA_RSTMGR_MODMPURST);
> > +
>
> I thought conclusion was to use writel (not __raw variant) here?
Yes it was. Fixed in v3, soon.
Alan
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2014-10-07 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 19:38 [PATCH v2 0/2] socfpga: fix hotplug/add suspend to ram atull at opensource.altera.com
2014-10-01 19:38 ` [PATCH v2 1/2] socfpga: hotplug: put cpu1 in wfi atull at opensource.altera.com
2014-10-07 11:10 ` Pavel Machek
2014-10-07 14:19 ` atull [this message]
2014-10-01 19:38 ` [PATCH v2 2/2] socfpga: support suspend to ram atull at opensource.altera.com
2014-10-02 21:16 ` atull
2014-10-07 11:17 ` Pavel Machek
2014-10-07 14:17 ` atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1410070918000.9610@atx-linux-37 \
--to=atull@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).