* [RFC PATCH 0/3] arm64: dts: ti: am6: Add gpio nodes
@ 2019-06-05 6:08 Keerthy
2019-06-05 6:08 ` [RFC PATCH 1/3] arm64: dts: ti: am6-wakeup: Add gpio node Keerthy
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Keerthy @ 2019-06-05 6:08 UTC (permalink / raw)
To: t-kristo, nm, robh+dt
Cc: lokeshvutla, j-keerthy, linux-kernel, linux-arm-kernel, devicetree
K3 AM6 platform has 2 instances of gpio banks on main domain
and 1 instance on wakeup domin. All are capable of generating
banked interrupts.
This series also adds 2 goio_keys nodes connected to SW6 SW5
switches and tested for gpio_keys interrupts.
The series depends on:
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=112791
Posting as RFC as it has dependencies to be merged.
Keerthy (3):
arm64: dts: ti: am6-wakeup: Add gpio node
arm64: dts: ti: am6-main: Add gpio nodes
arm64: dts: ti: am654-base-board: Add gpio_keys node
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 32 +++++++++++++++++++
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 15 +++++++++
.../arm64/boot/dts/ti/k3-am654-base-board.dts | 27 ++++++++++++++++
3 files changed, 74 insertions(+)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH 1/3] arm64: dts: ti: am6-wakeup: Add gpio node
2019-06-05 6:08 [RFC PATCH 0/3] arm64: dts: ti: am6: Add gpio nodes Keerthy
@ 2019-06-05 6:08 ` Keerthy
2019-06-05 6:16 ` Lokesh Vutla
2019-06-05 6:08 ` [RFC PATCH 2/3] arm64: dts: ti: am6-main: Add gpio nodes Keerthy
2019-06-05 6:08 ` [RFC PATCH 3/3] arm64: dts: ti: am654-base-board: Add gpio_keys node Keerthy
2 siblings, 1 reply; 6+ messages in thread
From: Keerthy @ 2019-06-05 6:08 UTC (permalink / raw)
To: t-kristo, nm, robh+dt
Cc: lokeshvutla, j-keerthy, linux-kernel, linux-arm-kernel, devicetree
Add gpio0 node under wakeup domain. This has 56 gpios
and all are capable of generating banked interrupts.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
index f1ca171abdf8..8c6c99e7c6ed 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
@@ -74,4 +74,19 @@
ti,sci-dst-id = <56>;
ti,sci-rm-range-girq = <0x4>;
};
+
+ wkup_gpio0: wkup_gpio0@42110000 {
+ compatible = "ti,k2g-gpio", "ti,keystone-gpio";
+ reg = <0x42110000 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&intr_wkup_gpio>;
+ interrupts = <59 128>, <59 129>, <59 130>, <59 131>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <56>;
+ ti,davinci-gpio-unbanked = <0>;
+ clocks = <&k3_clks 59 0>;
+ clock-names = "gpio";
+ };
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFC PATCH 2/3] arm64: dts: ti: am6-main: Add gpio nodes
2019-06-05 6:08 [RFC PATCH 0/3] arm64: dts: ti: am6: Add gpio nodes Keerthy
2019-06-05 6:08 ` [RFC PATCH 1/3] arm64: dts: ti: am6-wakeup: Add gpio node Keerthy
@ 2019-06-05 6:08 ` Keerthy
2019-06-05 6:08 ` [RFC PATCH 3/3] arm64: dts: ti: am654-base-board: Add gpio_keys node Keerthy
2 siblings, 0 replies; 6+ messages in thread
From: Keerthy @ 2019-06-05 6:08 UTC (permalink / raw)
To: t-kristo, nm, robh+dt
Cc: lokeshvutla, j-keerthy, linux-kernel, linux-arm-kernel, devicetree
Add gpio0/1 nodes under main domain. They have 96 and 90 gpios
respectively and all are capable of generating banked interrupts.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 32 ++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 22154f401930..24cd9005118c 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -350,4 +350,36 @@
ti,sci-rm-range-global-event = <0x1>;
};
};
+
+ main_gpio0: main_gpio0@600000 {
+ compatible = "ti,k2g-gpio", "ti,keystone-gpio";
+ reg = <0x0 0x600000 0x0 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&intr_main_gpio>;
+ interrupts = <57 256>, <57 257>, <57 258>, <57 259>, <57 260>,
+ <57 261>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <96>;
+ ti,davinci-gpio-unbanked = <0>;
+ clocks = <&k3_clks 57 0>;
+ clock-names = "gpio";
+ };
+
+ main_gpio1: main_gpio1@601000 {
+ compatible = "ti,k2g-gpio", "ti,keystone-gpio";
+ reg = <0x0 0x601000 0x0 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&intr_main_gpio>;
+ interrupts = <58 256>, <58 257>, <58 258>, <58 259>, <58 260>,
+ <58 261>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <90>;
+ ti,davinci-gpio-unbanked = <0>;
+ clocks = <&k3_clks 58 0>;
+ clock-names = "gpio";
+ };
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFC PATCH 3/3] arm64: dts: ti: am654-base-board: Add gpio_keys node
2019-06-05 6:08 [RFC PATCH 0/3] arm64: dts: ti: am6: Add gpio nodes Keerthy
2019-06-05 6:08 ` [RFC PATCH 1/3] arm64: dts: ti: am6-wakeup: Add gpio node Keerthy
2019-06-05 6:08 ` [RFC PATCH 2/3] arm64: dts: ti: am6-main: Add gpio nodes Keerthy
@ 2019-06-05 6:08 ` Keerthy
2 siblings, 0 replies; 6+ messages in thread
From: Keerthy @ 2019-06-05 6:08 UTC (permalink / raw)
To: t-kristo, nm, robh+dt
Cc: lokeshvutla, j-keerthy, linux-kernel, linux-arm-kernel, devicetree
There are 2 push buttons: SW5 and SW6 that are basically connected to
WKUP_GPIO0_24 and WKUP_GPIO0_27 respectively. Add the respective
nodes and the pinctrl data to set the mode to GPIO and Input.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
.../arm64/boot/dts/ti/k3-am654-base-board.dts | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index cf1aa276a1ea..ea50b6e36eff 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -6,6 +6,7 @@
/dts-v1/;
#include "k3-am654.dtsi"
+#include <dt-bindings/input/input.h>
/ {
compatible = "ti,am654-evm", "ti,am654";
@@ -33,6 +34,25 @@
no-map;
};
};
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ autorepeat;
+ pinctrl-names = "default";
+ pinctrl-0 = <&push_button_pins_default>;
+
+ sw5 {
+ label = "GPIO Key USER1";
+ linux,code = <BTN_0>;
+ gpios = <&wkup_gpio0 24 GPIO_ACTIVE_LOW>;
+ };
+
+ sw6 {
+ label = "GPIO Key USER2";
+ linux,code = <BTN_1>;
+ gpios = <&wkup_gpio0 27 GPIO_ACTIVE_LOW>;
+ };
+ };
};
&wkup_pmx0 {
@@ -42,6 +62,13 @@
AM65X_WKUP_IOPAD(0x00e4, PIN_INPUT, 0) /* (AD6) WKUP_I2C0_SDA */
>;
};
+
+ push_button_pins_default: push_button__pins_default {
+ pinctrl-single,pins = <
+ AM65X_WKUP_IOPAD(0x0030, PIN_INPUT, 7) /* (R5) WKUP_GPIO0_24 */
+ AM65X_WKUP_IOPAD(0x003c, PIN_INPUT, 7) /* (P2) WKUP_GPIO0_27 */
+ >;
+ };
};
&main_pmx0 {
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 1/3] arm64: dts: ti: am6-wakeup: Add gpio node
2019-06-05 6:08 ` [RFC PATCH 1/3] arm64: dts: ti: am6-wakeup: Add gpio node Keerthy
@ 2019-06-05 6:16 ` Lokesh Vutla
2019-06-05 6:31 ` Keerthy
0 siblings, 1 reply; 6+ messages in thread
From: Lokesh Vutla @ 2019-06-05 6:16 UTC (permalink / raw)
To: Keerthy, t-kristo, nm, robh+dt; +Cc: devicetree, linux-kernel, linux-arm-kernel
On 05/06/19 11:38 AM, Keerthy wrote:
> Add gpio0 node under wakeup domain. This has 56 gpios
> and all are capable of generating banked interrupts.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> index f1ca171abdf8..8c6c99e7c6ed 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> @@ -74,4 +74,19 @@
> ti,sci-dst-id = <56>;
> ti,sci-rm-range-girq = <0x4>;
> };
> +
> + wkup_gpio0: wkup_gpio0@42110000 {
> + compatible = "ti,k2g-gpio", "ti,keystone-gpio";
This is not k2g. Can you either create a am6 specific compatible or just use
ti,keystone-gpio.
Thanks and regards,
Lokesh
> + reg = <0x42110000 0x100>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-parent = <&intr_wkup_gpio>;
> + interrupts = <59 128>, <59 129>, <59 130>, <59 131>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + ti,ngpio = <56>;
> + ti,davinci-gpio-unbanked = <0>;
> + clocks = <&k3_clks 59 0>;
> + clock-names = "gpio";
> + };
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 1/3] arm64: dts: ti: am6-wakeup: Add gpio node
2019-06-05 6:16 ` Lokesh Vutla
@ 2019-06-05 6:31 ` Keerthy
0 siblings, 0 replies; 6+ messages in thread
From: Keerthy @ 2019-06-05 6:31 UTC (permalink / raw)
To: Lokesh Vutla, t-kristo, nm, robh+dt
Cc: devicetree, linux-kernel, linux-arm-kernel
On 05/06/19 11:46 AM, Lokesh Vutla wrote:
>
>
> On 05/06/19 11:38 AM, Keerthy wrote:
>> Add gpio0 node under wakeup domain. This has 56 gpios
>> and all are capable of generating banked interrupts.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
>> index f1ca171abdf8..8c6c99e7c6ed 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
>> @@ -74,4 +74,19 @@
>> ti,sci-dst-id = <56>;
>> ti,sci-rm-range-girq = <0x4>;
>> };
>> +
>> + wkup_gpio0: wkup_gpio0@42110000 {
>> + compatible = "ti,k2g-gpio", "ti,keystone-gpio";
>
> This is not k2g. Can you either create a am6 specific compatible or just use
> ti,keystone-gpio.
It seems practice is now to have separate compatible. I will add am6
specific compatible.
>
> Thanks and regards,
> Lokesh
>
>> + reg = <0x42110000 0x100>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + interrupt-parent = <&intr_wkup_gpio>;
>> + interrupts = <59 128>, <59 129>, <59 130>, <59 131>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + ti,ngpio = <56>;
>> + ti,davinci-gpio-unbanked = <0>;
>> + clocks = <&k3_clks 59 0>;
>> + clock-names = "gpio";
>> + };
>> };
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-05 6:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 6:08 [RFC PATCH 0/3] arm64: dts: ti: am6: Add gpio nodes Keerthy
2019-06-05 6:08 ` [RFC PATCH 1/3] arm64: dts: ti: am6-wakeup: Add gpio node Keerthy
2019-06-05 6:16 ` Lokesh Vutla
2019-06-05 6:31 ` Keerthy
2019-06-05 6:08 ` [RFC PATCH 2/3] arm64: dts: ti: am6-main: Add gpio nodes Keerthy
2019-06-05 6:08 ` [RFC PATCH 3/3] arm64: dts: ti: am654-base-board: Add gpio_keys node Keerthy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).