* [PATCH] ARM: DTS: r8a7794: alt: Fix PCF names for DU
@ 2016-11-03 13:42 Jacopo Mondi
2016-11-03 16:57 ` Sergei Shtylyov
2016-11-03 19:34 ` [PATCH v2] ARM: DTS: r8a7794: alt: Fix PFC " Jacopo Mondi
0 siblings, 2 replies; 6+ messages in thread
From: Jacopo Mondi @ 2016-11-03 13:42 UTC (permalink / raw)
To: linux-arm-kernel
Update the PCF pin groups and function names of DU interface for
r8a7794 ALT board.
The currently specified pin groups and function names prevented PCF and
DU interfaces from being correctly configured:
sh-pfc e6060000.pin-controller: function 'du' not supported
sh-pfc e6060000.pin-controller: invalid function du in map table
sh-pfc e6060000.pin-controller: function 'du' not supported
sh-pfc e6060000.pin-controller: invalid function du in map table
sh-pfc e6060000.pin-controller: function 'du' not supported
sh-pfc e6060000.pin-controller: invalid function du in map table
sh-pfc e6060000.pin-controller: function 'du' not supported
sh-pfc e6060000.pin-controller: invalid function du in map table
rcar-du: probe of feb00000.display failed with error -22
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
Patch applied against Simon Horman's renesas/master branch.
The PCF pin groups and function renaming was introduced by commit 56ed4bb9 and
DTS for ALT board has never been update accordingly.
Tested displaying frames on VGA interface: the rcar-du driver loads correctly.
arch/arm/boot/dts/r8a7794-alt.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
index 8d1b35a..9d65fb3 100644
--- a/arch/arm/boot/dts/r8a7794-alt.dts
+++ b/arch/arm/boot/dts/r8a7794-alt.dts
@@ -165,8 +165,8 @@
pinctrl-names = "default";
du_pins: du {
- groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_dotclkout0";
- function = "du";
+ groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_clk0_out";
+ function = "du1";
};
scif2_pins: scif2 {
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: DTS: r8a7794: alt: Fix PCF names for DU
2016-11-03 13:42 [PATCH] ARM: DTS: r8a7794: alt: Fix PCF names for DU Jacopo Mondi
@ 2016-11-03 16:57 ` Sergei Shtylyov
2016-11-03 19:34 ` [PATCH v2] ARM: DTS: r8a7794: alt: Fix PFC " Jacopo Mondi
1 sibling, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2016-11-03 16:57 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 11/03/2016 04:42 PM, Jacopo Mondi wrote:
> Update the PCF pin groups and function names of DU interface for
PFC maybe?
> r8a7794 ALT board.
>
> The currently specified pin groups and function names prevented PCF and
> DU interfaces from being correctly configured:
>
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> rcar-du: probe of feb00000.display failed with error -22
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>
> Patch applied against Simon Horman's renesas/master branch.
> The PCF pin groups and function renaming was introduced by commit 56ed4bb9 and
> DTS for ALT board has never been update accordingly.
We didn't care about Alt at the time, the patch was done in the interests
of the SILK board. I didn't realize the DU pin groups were used for Alt before
the actual support was added for them. Thank you for finally fixing this!
> Tested displaying frames on VGA interface: the rcar-du driver loads correctly.
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: DTS: r8a7794: alt: Fix PFC names for DU
2016-11-03 13:42 [PATCH] ARM: DTS: r8a7794: alt: Fix PCF names for DU Jacopo Mondi
2016-11-03 16:57 ` Sergei Shtylyov
@ 2016-11-03 19:34 ` Jacopo Mondi
2016-11-04 9:02 ` Simon Horman
2016-11-04 11:43 ` Sergei Shtylyov
1 sibling, 2 replies; 6+ messages in thread
From: Jacopo Mondi @ 2016-11-03 19:34 UTC (permalink / raw)
To: linux-arm-kernel
Update the PFC pin groups and function names of DU interface for
r8a7794 ALT board.
The currently specified pin groups and function names prevented PFC and
DU interfaces from being correctly configured:
sh-pfc e6060000.pin-controller: function 'du' not supported
sh-pfc e6060000.pin-controller: invalid function du in map table
sh-pfc e6060000.pin-controller: function 'du' not supported
sh-pfc e6060000.pin-controller: invalid function du in map table
sh-pfc e6060000.pin-controller: function 'du' not supported
sh-pfc e6060000.pin-controller: invalid function du in map table
sh-pfc e6060000.pin-controller: function 'du' not supported
sh-pfc e6060000.pin-controller: invalid function du in map table
rcar-du: probe of feb00000.display failed with error -22
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
v1->v2:
- s/PCF/PFC/ in commit message according to Sergei Shtylyov's comment
Patch applied against Simon Horman's renesas/master branch.
The PCF pin groups and function renaming was introduced by commit 56ed4bb9 and
DTS for ALT board has never been update accordingly.
Tested displaying frames on VGA interface: the rcar-du driver loads correctly.
arch/arm/boot/dts/r8a7794-alt.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
index 8d1b35a..9d65fb3 100644
--- a/arch/arm/boot/dts/r8a7794-alt.dts
+++ b/arch/arm/boot/dts/r8a7794-alt.dts
@@ -165,8 +165,8 @@
pinctrl-names = "default";
du_pins: du {
- groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_dotclkout0";
- function = "du";
+ groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_clk0_out";
+ function = "du1";
};
scif2_pins: scif2 {
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: DTS: r8a7794: alt: Fix PFC names for DU
2016-11-03 19:34 ` [PATCH v2] ARM: DTS: r8a7794: alt: Fix PFC " Jacopo Mondi
@ 2016-11-04 9:02 ` Simon Horman
2016-11-04 11:43 ` Sergei Shtylyov
1 sibling, 0 replies; 6+ messages in thread
From: Simon Horman @ 2016-11-04 9:02 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Thu, Nov 03, 2016 at 08:34:46PM +0100, Jacopo Mondi wrote:
> Update the PFC pin groups and function names of DU interface for
> r8a7794 ALT board.
>
> The currently specified pin groups and function names prevented PFC and
> DU interfaces from being correctly configured:
>
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> rcar-du: probe of feb00000.display failed with error -22
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>
> v1->v2:
> - s/PCF/PFC/ in commit message according to Sergei Shtylyov's comment
>
> Patch applied against Simon Horman's renesas/master branch.
> The PCF pin groups and function renaming was introduced by commit 56ed4bb9 and
> DTS for ALT board has never been update accordingly.
> Tested displaying frames on VGA interface: the rcar-du driver loads correctly.
Thanks for noticing this.
There is no need to repost to update the subject, but for reference I would
prefer the prefix to be "ARM: dts: alt:". Assuming there are no other
changes I can fix that up when queuing up this change.
I am wondering if this should be queued up as a fix for v4.9 and in turn
v4.8-stable. Or if it should just be queued up for v4.10.
In the case of the former I'd advocate adding the following tag
(again no need to repost just to update this):
Fixes: 56ed4bb984ac ("pinctrl: sh-pfc: r8a7794: Add DU pin groups")
> arch/arm/boot/dts/r8a7794-alt.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
> index 8d1b35a..9d65fb3 100644
> --- a/arch/arm/boot/dts/r8a7794-alt.dts
> +++ b/arch/arm/boot/dts/r8a7794-alt.dts
> @@ -165,8 +165,8 @@
> pinctrl-names = "default";
>
> du_pins: du {
> - groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_dotclkout0";
> - function = "du";
> + groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_clk0_out";
> + function = "du1";
> };
>
> scif2_pins: scif2 {
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: DTS: r8a7794: alt: Fix PFC names for DU
2016-11-03 19:34 ` [PATCH v2] ARM: DTS: r8a7794: alt: Fix PFC " Jacopo Mondi
2016-11-04 9:02 ` Simon Horman
@ 2016-11-04 11:43 ` Sergei Shtylyov
2016-11-07 12:40 ` Simon Horman
1 sibling, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2016-11-04 11:43 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 11/3/2016 10:34 PM, Jacopo Mondi wrote:
> Update the PFC pin groups and function names of DU interface for
> r8a7794 ALT board.
>
> The currently specified pin groups and function names prevented PFC and
> DU interfaces from being correctly configured:
>
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> sh-pfc e6060000.pin-controller: function 'du' not supported
> sh-pfc e6060000.pin-controller: invalid function du in map table
> rcar-du: probe of feb00000.display failed with error -22
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: DTS: r8a7794: alt: Fix PFC names for DU
2016-11-04 11:43 ` Sergei Shtylyov
@ 2016-11-07 12:40 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2016-11-07 12:40 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 04, 2016 at 02:43:18PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 11/3/2016 10:34 PM, Jacopo Mondi wrote:
>
> >Update the PFC pin groups and function names of DU interface for
> >r8a7794 ALT board.
> >
> >The currently specified pin groups and function names prevented PFC and
> >DU interfaces from being correctly configured:
> >
> >sh-pfc e6060000.pin-controller: function 'du' not supported
> >sh-pfc e6060000.pin-controller: invalid function du in map table
> >sh-pfc e6060000.pin-controller: function 'du' not supported
> >sh-pfc e6060000.pin-controller: invalid function du in map table
> >sh-pfc e6060000.pin-controller: function 'du' not supported
> >sh-pfc e6060000.pin-controller: invalid function du in map table
> >sh-pfc e6060000.pin-controller: function 'du' not supported
> >sh-pfc e6060000.pin-controller: invalid function du in map table
> >rcar-du: probe of feb00000.display failed with error -22
> >
> >Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks, I have queued this up.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-07 12:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-03 13:42 [PATCH] ARM: DTS: r8a7794: alt: Fix PCF names for DU Jacopo Mondi
2016-11-03 16:57 ` Sergei Shtylyov
2016-11-03 19:34 ` [PATCH v2] ARM: DTS: r8a7794: alt: Fix PFC " Jacopo Mondi
2016-11-04 9:02 ` Simon Horman
2016-11-04 11:43 ` Sergei Shtylyov
2016-11-07 12:40 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).