[PATCH 0/5] clocksource/drivers/imx: several updates

[PATCH 0/5] clocksource/drivers/imx: several updates

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

This patchset includes several update of i.MX sysctr and tpm driver.

Peng Fan (5):
  clocksource/drivers/imx-sysctr: drop IRQF_IRQPOLL
  clocksource/drivers/imx-tpm: drop IRQF_IRQPOLL
  clocksource/drivers/imx-tpm: mark two variable with __ro_after_init
  clocksource/drivers/imx-tpm: add CLOCK_EVT_FEAT_DYNIRQ
  clocksource/drivers/imx-tpm: update name of clkevt

 drivers/clocksource/timer-imx-sysctr.c |  2 +-
 drivers/clocksource/timer-imx-tpm.c    | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/5] clocksource/drivers/imx-sysctr: drop IRQF_IRQPOLL

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

Per the Documentation,
IRQF_IRQPOLL is used for polling (only the interrupt that is registered
first in a shared interrupt is considered for performance reasons)
But this timer is not sharing interrupt line with others, and
actually irqpoll not work with this timer with IRQF_IRQPOLL set, so
drop the flag.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/clocksource/timer-imx-sysctr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-imx-sysctr.c b/drivers/clocksource/timer-imx-sysctr.c
index 18b90fc56bfc..31ff8e06c9d1 100644
--- a/drivers/clocksource/timer-imx-sysctr.c
+++ b/drivers/clocksource/timer-imx-sysctr.c
@@ -110,7 +110,7 @@ static struct timer_of to_sysctr = {
 	},
 	.of_irq = {
 		.handler		= sysctr_timer_interrupt,
-		.flags			= IRQF_TIMER | IRQF_IRQPOLL,
+		.flags			= IRQF_TIMER,
 	},
 	.of_clk = {
 		.name = "per",
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/5] clocksource/drivers/imx-tpm: drop IRQF_IRQPOLL

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

Per the Documentation,
IRQF_IRQPOLL is used for polling (only the interrupt that is registered
first in a shared interrupt is considered for performance reasons)
The TPM timer is not sharing interrupt with others, and pass irqpoll
not make sense for i.MX platform.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/clocksource/timer-imx-tpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-imx-tpm.c b/drivers/clocksource/timer-imx-tpm.c
index 2cdc077a39f5..2c0b0d4eba9e 100644
--- a/drivers/clocksource/timer-imx-tpm.c
+++ b/drivers/clocksource/timer-imx-tpm.c
@@ -137,7 +137,7 @@ static struct timer_of to_tpm = {
 	},
 	.of_irq = {
 		.handler		= tpm_timer_interrupt,
-		.flags			= IRQF_TIMER | IRQF_IRQPOLL,
+		.flags			= IRQF_TIMER,
 	},
 	.of_clk = {
 		.name = "per",
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 3/5] clocksource/drivers/imx-tpm: mark two variable with __ro_after_init

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

counter_width and timer_base will not be updated after init, so mark
as __ro_after_init.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/clocksource/timer-imx-tpm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/timer-imx-tpm.c b/drivers/clocksource/timer-imx-tpm.c
index 2c0b0d4eba9e..3afd9b0a668a 100644
--- a/drivers/clocksource/timer-imx-tpm.c
+++ b/drivers/clocksource/timer-imx-tpm.c
@@ -32,8 +32,8 @@
 #define TPM_C0SC_CHF_MASK		(0x1 << 7)
 #define TPM_C0V				0x24
 
-static int counter_width;
-static void __iomem *timer_base;
+static int counter_width __ro_after_init;
+static void __iomem *timer_base __ro_after_init;
 
 static inline void tpm_timer_disable(void)
 {
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 4/5] clocksource/drivers/imx-tpm: add CLOCK_EVT_FEAT_DYNIRQ

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

Add CLOCK_EVT_FEAT_DYNIRQ to allow the IRQ could be runtime set affinity
to the cores that needs wake up, otherwise saying core0 has to send
IPI to wakeup core1. With CLOCK_EVT_FEAT_DYNIRQ set, when broadcast
timer could wake up the cores, IPI is not needed.

Acked-by: Jacky Bai <ping.bai@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/clocksource/timer-imx-tpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-imx-tpm.c b/drivers/clocksource/timer-imx-tpm.c
index 3afd9b0a668a..578fe162fd99 100644
--- a/drivers/clocksource/timer-imx-tpm.c
+++ b/drivers/clocksource/timer-imx-tpm.c
@@ -129,7 +129,7 @@ static struct timer_of to_tpm = {
 	.clkevt = {
 		.name			= "i.MX7ULP TPM Timer",
 		.rating			= 200,
-		.features		= CLOCK_EVT_FEAT_ONESHOT,
+		.features		= CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_DYNIRQ,
 		.set_state_shutdown	= tpm_set_state_shutdown,
 		.set_state_oneshot	= tpm_set_state_oneshot,
 		.set_next_event		= tpm_set_next_event,
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 5/5] clocksource/drivers/imx-tpm: update name of clkevt

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

The tpm driver is not only for i.MX7ULP now, i.MX8ULP also use it. It
maybe also used by other i.MX variants, so update name to reflect it.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/clocksource/timer-imx-tpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-imx-tpm.c b/drivers/clocksource/timer-imx-tpm.c
index 578fe162fd99..df8064122b10 100644
--- a/drivers/clocksource/timer-imx-tpm.c
+++ b/drivers/clocksource/timer-imx-tpm.c
@@ -127,7 +127,7 @@ static irqreturn_t tpm_timer_interrupt(int irq, void *dev_id)
 static struct timer_of to_tpm = {
 	.flags = TIMER_OF_IRQ | TIMER_OF_BASE | TIMER_OF_CLOCK,
 	.clkevt = {
-		.name			= "i.MX7ULP TPM Timer",
+		.name			= "i.MX TPM Timer",
 		.rating			= 200,
 		.features		= CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_DYNIRQ,
 		.set_state_shutdown	= tpm_set_state_shutdown,
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH 0/5] clocksource/drivers/imx: several updates

[Peng Fan]

> Subject: [PATCH 0/5] clocksource/drivers/imx: several updates
> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> This patchset includes several update of i.MX sysctr and tpm driver.

Ping..

Thanks,
Peng.

> 
> Peng Fan (5):
>   clocksource/drivers/imx-sysctr: drop IRQF_IRQPOLL
>   clocksource/drivers/imx-tpm: drop IRQF_IRQPOLL
>   clocksource/drivers/imx-tpm: mark two variable with __ro_after_init
>   clocksource/drivers/imx-tpm: add CLOCK_EVT_FEAT_DYNIRQ
>   clocksource/drivers/imx-tpm: update name of clkevt
> 
>  drivers/clocksource/timer-imx-sysctr.c |  2 +-
>  drivers/clocksource/timer-imx-tpm.c    | 10 +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> --
> 2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH 0/5] clocksource/drivers/imx: several updates

[Peng Fan]

Daniel,

> Subject: RE: [PATCH 0/5] clocksource/drivers/imx: several updates

Do you have time to give a look?

Thanks,
Peng.

> 
> > Subject: [PATCH 0/5] clocksource/drivers/imx: several updates
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > This patchset includes several update of i.MX sysctr and tpm driver.
> 
> Ping..
> 
> Thanks,
> Peng.
> 
> >
> > Peng Fan (5):
> >   clocksource/drivers/imx-sysctr: drop IRQF_IRQPOLL
> >   clocksource/drivers/imx-tpm: drop IRQF_IRQPOLL
> >   clocksource/drivers/imx-tpm: mark two variable with __ro_after_init
> >   clocksource/drivers/imx-tpm: add CLOCK_EVT_FEAT_DYNIRQ
> >   clocksource/drivers/imx-tpm: update name of clkevt
> >
> >  drivers/clocksource/timer-imx-sysctr.c |  2 +-
> >  drivers/clocksource/timer-imx-tpm.c    | 10 +++++-----
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > --
> > 2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/5] clocksource/drivers/imx: several updates

[Daniel Lezcano]

On 26/01/2022 09:24, Peng Fan wrote:
> Daniel,
> 
>> Subject: RE: [PATCH 0/5] clocksource/drivers/imx: several updates
> 
> Do you have time to give a look?

Yeah, sorry for the delay

They sounds good, I'll pick them up

Thanks

  -- Daniel


>>> Subject: [PATCH 0/5] clocksource/drivers/imx: several updates
>>>
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> This patchset includes several update of i.MX sysctr and tpm driver.
>>
>> Ping..
>>
>> Thanks,
>> Peng.
>>
>>>
>>> Peng Fan (5):
>>>   clocksource/drivers/imx-sysctr: drop IRQF_IRQPOLL
>>>   clocksource/drivers/imx-tpm: drop IRQF_IRQPOLL
>>>   clocksource/drivers/imx-tpm: mark two variable with __ro_after_init
>>>   clocksource/drivers/imx-tpm: add CLOCK_EVT_FEAT_DYNIRQ
>>>   clocksource/drivers/imx-tpm: update name of clkevt
>>>
>>>  drivers/clocksource/timer-imx-sysctr.c |  2 +-
>>>  drivers/clocksource/timer-imx-tpm.c    | 10 +++++-----
>>>  2 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>> --
>>> 2.25.1
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH 0/5] clocksource/drivers/imx: several updates

[Peng Fan]

> Subject: Re: [PATCH 0/5] clocksource/drivers/imx: several updates
> 
> 
> On 26/01/2022 09:24, Peng Fan wrote:
> > Daniel,
> >
> >> Subject: RE: [PATCH 0/5] clocksource/drivers/imx: several updates
> >
> > Do you have time to give a look?
> 
> Yeah, sorry for the delay
> 
> They sounds good, I'll pick them up

Still not in your tree? Or later?

Thanks,
Peng.

> 
> Thanks
> 
>   -- Daniel
> 
> 
> >>> Subject: [PATCH 0/5] clocksource/drivers/imx: several updates
> >>>
> >>> From: Peng Fan <peng.fan@nxp.com>
> >>>
> >>> This patchset includes several update of i.MX sysctr and tpm driver.
> >>
> >> Ping..
> >>
> >> Thanks,
> >> Peng.
> >>
> >>>
> >>> Peng Fan (5):
> >>>   clocksource/drivers/imx-sysctr: drop IRQF_IRQPOLL
> >>>   clocksource/drivers/imx-tpm: drop IRQF_IRQPOLL
> >>>   clocksource/drivers/imx-tpm: mark two variable with __ro_after_init
> >>>   clocksource/drivers/imx-tpm: add CLOCK_EVT_FEAT_DYNIRQ
> >>>   clocksource/drivers/imx-tpm: update name of clkevt
> >>>
> >>>  drivers/clocksource/timer-imx-sysctr.c |  2 +-
> >>>  drivers/clocksource/timer-imx-tpm.c    | 10 +++++-----
> >>>  2 files changed, 6 insertions(+), 6 deletions(-)
> >>>
> >>> --
> >>> 2.25.1
> >
> 
> 
> --
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.l
> inaro.org%2F&amp;data=04%7C01%7Cpeng.fan%40nxp.com%7Ccb71984b85
> 4c4bd16f2708d9e0aa295e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%
> 7C0%7C637787843705684549%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC
> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&
> amp;sdata=op5BIq2UuUmYonbEV0U27tVbLPTfxnkASmS52eABSJ8%3D&amp;
> reserved=0> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.f
> acebook.com%2Fpages%2FLinaro&amp;data=04%7C01%7Cpeng.fan%40nxp.
> com%7Ccb71984b854c4bd16f2708d9e0aa295e%7C686ea1d3bc2b4c6fa92cd
> 99c5c301635%7C0%7C0%7C637787843705684549%7CUnknown%7CTWFpb
> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
> 6Mn0%3D%7C3000&amp;sdata=7weozdfeg9ykj8wObv1d1G5UYCExNepqhFv
> a%2BNwo9cE%3D&amp;reserved=0> Facebook |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitter
> .com%2F%23!%2Flinaroorg&amp;data=04%7C01%7Cpeng.fan%40nxp.com%
> 7Ccb71984b854c4bd16f2708d9e0aa295e%7C686ea1d3bc2b4c6fa92cd99c5c
> 301635%7C0%7C0%7C637787843705684549%7CUnknown%7CTWFpbGZsb3
> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
> %3D%7C3000&amp;sdata=8QScPZeVas%2Fpb%2F8YuUJMBjO83eeD%2BP9Sz
> S3yfdKbid0%3D&amp;reserved=0> Twitter |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.l
> inaro.org%2Flinaro-blog%2F&amp;data=04%7C01%7Cpeng.fan%40nxp.com%
> 7Ccb71984b854c4bd16f2708d9e0aa295e%7C686ea1d3bc2b4c6fa92cd99c5c
> 301635%7C0%7C0%7C637787843705684549%7CUnknown%7CTWFpbGZsb3
> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
> %3D%7C3000&amp;sdata=L90xtQflnMHRmrZVvmvXVfAY7npcLPM4%2FKITN
> bxgY1c%3D&amp;reserved=0> Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/5] clocksource/drivers/imx: several updates

[Daniel Lezcano]

On 14/02/2022 00:46, Peng Fan wrote:
>> Subject: Re: [PATCH 0/5] clocksource/drivers/imx: several updates
>>
>>
>> On 26/01/2022 09:24, Peng Fan wrote:
>>> Daniel,
>>>
>>>> Subject: RE: [PATCH 0/5] clocksource/drivers/imx: several updates
>>>
>>> Do you have time to give a look?
>>
>> Yeah, sorry for the delay
>>
>> They sounds good, I'll pick them up
> 
> Still not in your tree? Or later?

Just pushed my branch

https://git.linaro.org/people/daniel.lezcano/linux.git/log/?h=timers/drivers/next

It will land in linux-next


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel