* [PATCH] iio: adc: fix return error variable
@ 2022-05-09 7:24 cgel.zte
2022-05-09 7:34 ` Michal Simek
0 siblings, 1 reply; 3+ messages in thread
From: cgel.zte @ 2022-05-09 7:24 UTC (permalink / raw)
To: jic23, lars
Cc: anand.ashok.dumbre, michal.simek, manish.narani, linux-iio,
linux-arm-kernel, linux-kernel, Lv Ruyi, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
Return irq instead of ret which always equals to zero here.
Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
drivers/iio/adc/xilinx-ams.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
index a55396c1f8b2..a7687706012d 100644
--- a/drivers/iio/adc/xilinx-ams.c
+++ b/drivers/iio/adc/xilinx-ams.c
@@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0)
- return ret;
+ return irq;
ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq",
indio_dev);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: fix return error variable
2022-05-09 7:24 [PATCH] iio: adc: fix return error variable cgel.zte
@ 2022-05-09 7:34 ` Michal Simek
2022-05-14 13:49 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2022-05-09 7:34 UTC (permalink / raw)
To: cgel.zte, jic23, lars
Cc: anand.ashok.dumbre, michal.simek, manish.narani, linux-iio,
linux-arm-kernel, linux-kernel, Lv Ruyi, Zeal Robot
On 5/9/22 09:24, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> Return irq instead of ret which always equals to zero here.
>
> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> drivers/iio/adc/xilinx-ams.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
> index a55396c1f8b2..a7687706012d 100644
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> - return ret;
> + return irq;
>
> ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq",
> indio_dev);
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: fix return error variable
2022-05-09 7:34 ` Michal Simek
@ 2022-05-14 13:49 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2022-05-14 13:49 UTC (permalink / raw)
To: Michal Simek
Cc: cgel.zte, lars, anand.ashok.dumbre, manish.narani, linux-iio,
linux-arm-kernel, linux-kernel, Lv Ruyi, Zeal Robot
On Mon, 9 May 2022 09:34:57 +0200
Michal Simek <michal.simek@xilinx.com> wrote:
> On 5/9/22 09:24, cgel.zte@gmail.com wrote:
> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
Applied, with modified patch title. There are a lot of ADC drivers
so you should include the name of the driver in the patch description.
iio: adc: xilinx-ams: fix return error variable
> >
> > Return irq instead of ret which always equals to zero here.
> >
> > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> > ---
> > drivers/iio/adc/xilinx-ams.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
> > index a55396c1f8b2..a7687706012d 100644
> > --- a/drivers/iio/adc/xilinx-ams.c
> > +++ b/drivers/iio/adc/xilinx-ams.c
> > @@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev)
> >
> > irq = platform_get_irq(pdev, 0);
> > if (irq < 0)
> > - return ret;
> > + return irq;
> >
> > ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq",
> > indio_dev);
>
> Reviewed-by: Michal Simek <michal.simek@amd.com>
>
> Thanks,
> Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-14 13:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 7:24 [PATCH] iio: adc: fix return error variable cgel.zte
2022-05-09 7:34 ` Michal Simek
2022-05-14 13:49 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).