From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: kyrie.wu <kyrie.wu@mediatek.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tzung-Bi Shih <tzungbi@chromium.org>
Cc: <Project_Global_Chrome_Upstream_Group@mediatek.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Tomasz Figa <tfiga@chromium.org>, <xia.jiang@mediatek.com>,
<maoguang.meng@mediatek.com>, <srv_heupstream@mediatek.com>
Subject: Re: [V2: 1/1] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186
Date: Wed, 16 Mar 2022 20:52:12 +0800 [thread overview]
Message-ID: <c462f887246cf9eca46fea24a2704ed5d7aec7b8.camel@mediatek.com> (raw)
In-Reply-To: <9b4deaeb6ab6baaaf771e817f9c2163111796bb9.camel@mediatek.com>
On Wed, 2022-03-16 at 18:41 +0800, Rex-BC Chen wrote:
> On Wed, 2022-03-16 at 15:40 +0800, kyrie.wu wrote:
> > From: kyrie wu <kyrie.wu@mediatek.com>
> >
> > Adds encoder dt-bindings for mt8186.
> >
> > Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> > ---
> > .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml |
> > 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > index e7b65a91c92c..6d52947f30a5 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt8183-vcodec-enc
> > - mediatek,mt8192-vcodec-enc
> > - mediatek,mt8195-vcodec-enc
> > + - mediatek,mt8186-vcodec-enc
> >
>
> Hello Kyrie,
>
> As metioned in v1, I think it's better to move the 8186 below 8183.
>
> BRs,
> Rex
> > reg:
> > maxItems: 1
>
>
Hello Kyrie,
By the way, I see you re-use 8183 data in v1.
I think the binding should be somthing like this:
Before you send next patch, make sure you run the binding check.
compatible:
oneOf:
-items:
- enum:
- mediatek,mt8173-vcodec-enc-vp8
- mediatek,mt8173-vcodec-enc
- mediatek,mt8183-vcodec-enc
- mediatek,mt8192-vcodec-enc
- mediatek,mt8195-vcodec-enc
-items:
- enum:
- mediatek,mt8186-vcodec-enc
- const: mediatek,mt8183-vcodec-enc
BRs,
Rex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-03-16 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 7:40 [V2: 0/1] support mt8186 encoder kyrie.wu
2022-03-16 7:40 ` [V2: 1/1] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186 kyrie.wu
2022-03-16 10:41 ` Rex-BC Chen
2022-03-16 12:52 ` Rex-BC Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c462f887246cf9eca46fea24a2704ed5d7aec7b8.camel@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kyrie.wu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=tzungbi@chromium.org \
--cc=xia.jiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).