From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Rob Herring <robh@kernel.org>, Jesse Taube <mr.bossman075@gmail.com>
Cc: linux-imx@nxp.com, mturquette@baylibre.com, sboyd@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch,
linus.walleij@linaro.org, gregkh@linuxfoundation.org,
arnd@arndb.de, olof@lixom.net, soc@kernel.org,
linux@armlinux.org.uk, abel.vesa@nxp.com,
adrian.hunter@intel.com, jirislaby@kernel.org,
nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 12/13] ARM: dts: imx: add i.MXRT1050-EVK support
Date: Fri, 3 Dec 2021 01:20:51 +0100 [thread overview]
Message-ID: <c488ed94-ad0e-a326-adda-c4d782dbd6ef@benettiengineering.com> (raw)
In-Reply-To: <YaOxu441l41qPvTj@robh.at.kernel.org>
Hi Rob, Jesse,
On 28/11/21 17:43, Rob Herring wrote:
[SNIP]
>> diff --git a/arch/arm/boot/dts/imxrt1050.dtsi b/arch/arm/boot/dts/imxrt1050.dtsi
>> new file mode 100644
>> index 000000000000..35943a6896fa
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imxrt1050.dtsi
>> @@ -0,0 +1,165 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (C) 2019
>> + * Author(s): Giulio Benetti <giulio.benetti@benettiengineering.com>
>> + */
>> +
>> +#include "armv7-m.dtsi"
>> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>> +#include <dt-bindings/clock/imxrt1050-clock.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> +/ {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + clocks {
>> + osc: osc {
>> + compatible = "fsl,imx-osc", "fixed-clock";
>
> fsl,imx-osc is not documented. IMO, just drop it.
Regarding this ^^^, you're right, so we avoid to add "fsl,imx-osc", but
at this point, does it make sense we create a patchset to remove it from
the other .dts(i) files that use it? And same goes for "fsl,imx-ckil",
"fsl,imx-ckih1", "fsl,imx-ckih2"?
I see that those try to repeat the name of the node itself so they are
useless. If you say so I send a patchset for that.
Thank you
Best regards
--
Giulio Benetti
Benetti Engineering sas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-03 0:23 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 21:14 [PATCH v3 00/13] add initial support for the i.MXRTxxxx SoC family starting from i.IMXRT1050 SoC Jesse Taube
2021-11-25 21:14 ` [PATCH v3 01/13] ARM: imx: add initial support for i.MXRT10xx family Jesse Taube
2021-11-25 21:14 ` [PATCH v3 02/13] dt-bindings: pinctrl: add i.MXRT1050 pinctrl binding doc Jesse Taube
2021-11-29 1:04 ` Rob Herring
2021-12-02 1:28 ` Linus Walleij
2021-11-25 21:14 ` [PATCH v3 03/13] ARM: dts: imxrt1050-pinfunc: Add pinctrl binding header Jesse Taube
2021-11-29 1:06 ` Rob Herring
2021-12-02 1:31 ` Linus Walleij
2021-11-25 21:14 ` [PATCH v3 04/13] pinctrl: freescale: Add i.MXRT1050 pinctrl driver support Jesse Taube
2021-11-27 1:43 ` Linus Walleij
2021-11-27 12:48 ` Fabio Estevam
2021-12-02 1:31 ` Linus Walleij
2021-11-25 21:14 ` [PATCH v3 05/13] dt-bindings: imx: Add clock binding for i.MXRT1050 Jesse Taube
2021-11-28 16:28 ` Rob Herring
2021-11-25 21:14 ` [PATCH v3 06/13] dt-bindings: clock: imx: Add documentation for i.MXRT clock Jesse Taube
2021-11-28 16:32 ` Rob Herring
2021-11-25 21:14 ` [PATCH v3 07/13] clk: imx: Add initial support for i.MXRT clock driver Jesse Taube
2021-11-28 20:50 ` Fabio Estevam
2021-11-28 20:52 ` Jesse Taube
2021-11-28 20:54 ` Fabio Estevam
2021-11-28 20:59 ` Jesse Taube
2021-11-28 21:01 ` Fabio Estevam
2021-11-28 22:17 ` Giulio Benetti
2021-11-25 21:14 ` [PATCH v3 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible Jesse Taube
2021-11-28 16:31 ` Rob Herring
2021-11-25 21:14 ` [PATCH v3 09/13] tty: serial: fsl_lpuart: add i.MXRT support Jesse Taube
2021-11-28 20:47 ` Fabio Estevam
2021-11-25 21:14 ` [PATCH v3 10/13] dt-bindings: mmc: fsl-imx-esdhc: add i.MXRT compatible string Jesse Taube
2021-11-28 16:32 ` Rob Herring
2021-11-30 15:41 ` Ulf Hansson
2021-11-25 21:14 ` [PATCH v3 11/13] mmc: sdhci-esdhc-imx: Add sdhc support for i.MXRT series Jesse Taube
2021-11-28 20:51 ` Fabio Estevam
2021-11-30 15:41 ` Ulf Hansson
2021-11-25 21:14 ` [PATCH v3 12/13] ARM: dts: imx: add i.MXRT1050-EVK support Jesse Taube
2021-11-28 16:43 ` Rob Herring
2021-11-28 17:00 ` Jesse Taube
2021-12-03 0:20 ` Giulio Benetti [this message]
2021-11-25 21:14 ` [PATCH v3 13/13] ARM: imxrt_defconfig: add i.MXRT family defconfig Jesse Taube
2021-11-25 21:42 ` Arnd Bergmann
2021-11-25 22:19 ` Jesse Taube
2021-11-29 1:21 ` Giulio Benetti
2021-11-29 1:54 ` Jesse Taube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c488ed94-ad0e-a326-adda-c4d782dbd6ef@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=abel.vesa@nxp.com \
--cc=adrian.hunter@intel.com \
--cc=aisheng.dong@nxp.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mr.bossman075@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
--cc=stefan@agner.ch \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).