From: Arnd Bergmann <arnd@arndb.de>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Dong Aisheng <aisheng.dong@nxp.com>,
Stefan Agner <stefan@agner.ch>,
Linus Walleij <linus.walleij@linaro.org>,
gregkh <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
SoC Team <soc@kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Abel Vesa <abel.vesa@nxp.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Jiri Slaby <jirislaby@kernel.org>,
giulio.benetti@benettiengineering.com,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
linux-clk <linux-clk@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH v3 13/13] ARM: imxrt_defconfig: add i.MXRT family defconfig
Date: Thu, 25 Nov 2021 22:42:58 +0100 [thread overview]
Message-ID: <CAK8P3a3dwwBt21o7LDY-CLDdVmOknxDF7sgO_dfiTj8_u4Tx=A@mail.gmail.com> (raw)
In-Reply-To: <20211125211443.1150135-14-Mr.Bossman075@gmail.com>
On Thu, Nov 25, 2021 at 10:14 PM Jesse Taube <mr.bossman075@gmail.com> wrote:
>
> From: Giulio Benetti <giulio.benetti@benettiengineering.com>
>
> Add generic i.MXRT family defconfig.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
I see a lot of things in here that probably should not be part of the kernel,
either because they are rather obscure, or they take valuable memory:
> ---
> arch/arm/configs/imxrt_defconfig | 157 +++++++++++++++++++++++++++++++
> 1 file changed, 157 insertions(+)
> create mode 100644 arch/arm/configs/imxrt_defconfig
>
> diff --git a/arch/arm/configs/imxrt_defconfig b/arch/arm/configs/imxrt_defconfig
> new file mode 100644
> index 000000000000..d673745a5462
> --- /dev/null
> +++ b/arch/arm/configs/imxrt_defconfig
> @@ -0,0 +1,157 @@
> +# CONFIG_LOCALVERSION_AUTO is not set
> +CONFIG_SYSVIPC=y
> +CONFIG_USELIB=y
You almost certainly won't want USELIB, and SYSVIPC support
would only be useful for certain applications that you probably
won't run.
> +CONFIG_BSD_PROCESS_ACCT=y
> +CONFIG_BSD_PROCESS_ACCT_V3=y
> +CONFIG_PSI=y
> +CONFIG_IKCONFIG=y
> +CONFIG_IKCONFIG_PROC=y
Probably nonen of these are helpful here.
> +CONFIG_MEMCG=y
> +CONFIG_BLK_CGROUP=y
> +CONFIG_CFS_BANDWIDTH=y
> +CONFIG_CGROUP_PIDS=y
> +CONFIG_CGROUP_RDMA=y
> +CONFIG_CGROUP_FREEZER=y
> +CONFIG_CGROUP_DEVICE=y
> +CONFIG_CGROUP_CPUACCT=y
> +CONFIG_CGROUP_PERF=y
> +CONFIG_CGROUP_BPF=y
> +CONFIG_NAMESPACES=y
> +CONFIG_USER_NS=y
> +CONFIG_CHECKPOINT_RESTORE=y
Same for control groups overall as well as checkpoint_restore
> +CONFIG_RELAY=y
There are a few drivers using CONFIG_RELAY, but I don't see you enable
any of them,
so this is not actually used.
> +CONFIG_EXPERT=y
Are you losing anything without EXPERT? If not, remove that
> +CONFIG_SGETMASK_SYSCALL=y
> +# CONFIG_FUTEX is not set
Futex is probably one of the things you /do/ want.
> +CONFIG_KALLSYMS_ALL=y
> +CONFIG_PC104=y
Turning off KALLSYMS_ALL may save a noticeable amount of RAM.
PC104 isn't actually that big, but it seems unlikely that you have
that hardware.
> +CONFIG_PARAVIRT=y
You don't seem to enable XEN, so I don't think PARAVIRT is useful by itself.
> +# CONFIG_ATAGS is not set
> +CONFIG_CMDLINE="console=ttyS0 root=/dev/mmcblk0p2 rw earlycon rootwait"
The command line should come from the boot loader, users probably have
a different root device.
> +CONFIG_BLK_DEV_BSGLIB=y
> +CONFIG_BLK_DEV_INTEGRITY=y
> +CONFIG_BLK_DEV_ZONED=y
> +CONFIG_BLK_DEV_THROTTLING=y
> +CONFIG_BLK_WBT=y
> +CONFIG_BLK_SED_OPAL=y
> +CONFIG_PARTITION_ADVANCED=y
> +CONFIG_BSD_DISKLABEL=y
> +CONFIG_MINIX_SUBPARTITION=y
> +CONFIG_SOLARIS_X86_PARTITION=y
> +CONFIG_UNIXWARE_DISKLABEL=y
> +CONFIG_LDM_PARTITION=y
I don't see you using OPAL or any of the 1990's partition formats.
ot set
> +CONFIG_BINFMT_FLAT=y
For the defconfig, you should probably have ELF_FDPIC enabled,
not just FLAT.
> +CONFIG_CLEANCACHE=y
> +CONFIG_ZPOOL=y
> +CONFIG_ZBUD=y
> +CONFIG_Z3FOLD=y
Do these work as expected on NOMMU?
> +CONFIG_BLK_DEV_LOOP=y
> +CONFIG_BLK_DEV_RAM=y
> +CONFIG_BLK_DEV_RAM_COUNT=1
> +CONFIG_BLK_DEV_RAM_SIZE=65536
I don't think you can have a ramdisk larger than RAM ;-)
> +CONFIG_MEMORY=y
No need to enable the subsystem when you don't enable any
of its drivers.
> +CONFIG_EXT2_FS=y
> +CONFIG_EXT2_FS_XATTR=y
> +CONFIG_EXT2_FS_POSIX_ACL=y
> +CONFIG_EXT2_FS_SECURITY=y
> +CONFIG_EXT3_FS=y
> +CONFIG_EXT3_FS_POSIX_ACL=y
> +CONFIG_EXT3_FS_SECURITY=y
Never use EXT3 on eMMC, just use EXT4 instead to make
the device actually live longer. You probably don't need to enable
EXT2 support separately.
> +# CONFIG_FILE_LOCKING is not set
> +# CONFIG_DNOTIFY is not set
> +CONFIG_QUOTA=y
dnotify and locking seem more useful than quota here
> +# CONFIG_PRINT_QUOTA_WARNING is not set
> +CONFIG_AUTOFS4_FS=y
> +CONFIG_CONFIGFS_FS=y
I don't see anything using configfs
> +CONFIG_LSM="yama,loadpin,integrity,apparmor"
None of these are actually enabled as far as I can tell.
> +CONFIG_DEBUG_INFO=y
> +CONFIG_DEBUG_INFO_DWARF4=y
If you use DWARF4, you probably want DEBUG_INFO_SPLIT as well,
to reduce the vmlinux size.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-25 21:44 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 21:14 [PATCH v3 00/13] add initial support for the i.MXRTxxxx SoC family starting from i.IMXRT1050 SoC Jesse Taube
2021-11-25 21:14 ` [PATCH v3 01/13] ARM: imx: add initial support for i.MXRT10xx family Jesse Taube
2021-11-25 21:14 ` [PATCH v3 02/13] dt-bindings: pinctrl: add i.MXRT1050 pinctrl binding doc Jesse Taube
2021-11-29 1:04 ` Rob Herring
2021-12-02 1:28 ` Linus Walleij
2021-11-25 21:14 ` [PATCH v3 03/13] ARM: dts: imxrt1050-pinfunc: Add pinctrl binding header Jesse Taube
2021-11-29 1:06 ` Rob Herring
2021-12-02 1:31 ` Linus Walleij
2021-11-25 21:14 ` [PATCH v3 04/13] pinctrl: freescale: Add i.MXRT1050 pinctrl driver support Jesse Taube
2021-11-27 1:43 ` Linus Walleij
2021-11-27 12:48 ` Fabio Estevam
2021-12-02 1:31 ` Linus Walleij
2021-11-25 21:14 ` [PATCH v3 05/13] dt-bindings: imx: Add clock binding for i.MXRT1050 Jesse Taube
2021-11-28 16:28 ` Rob Herring
2021-11-25 21:14 ` [PATCH v3 06/13] dt-bindings: clock: imx: Add documentation for i.MXRT clock Jesse Taube
2021-11-28 16:32 ` Rob Herring
2021-11-25 21:14 ` [PATCH v3 07/13] clk: imx: Add initial support for i.MXRT clock driver Jesse Taube
2021-11-28 20:50 ` Fabio Estevam
2021-11-28 20:52 ` Jesse Taube
2021-11-28 20:54 ` Fabio Estevam
2021-11-28 20:59 ` Jesse Taube
2021-11-28 21:01 ` Fabio Estevam
2021-11-28 22:17 ` Giulio Benetti
2021-11-25 21:14 ` [PATCH v3 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible Jesse Taube
2021-11-28 16:31 ` Rob Herring
2021-11-25 21:14 ` [PATCH v3 09/13] tty: serial: fsl_lpuart: add i.MXRT support Jesse Taube
2021-11-28 20:47 ` Fabio Estevam
2021-11-25 21:14 ` [PATCH v3 10/13] dt-bindings: mmc: fsl-imx-esdhc: add i.MXRT compatible string Jesse Taube
2021-11-28 16:32 ` Rob Herring
2021-11-30 15:41 ` Ulf Hansson
2021-11-25 21:14 ` [PATCH v3 11/13] mmc: sdhci-esdhc-imx: Add sdhc support for i.MXRT series Jesse Taube
2021-11-28 20:51 ` Fabio Estevam
2021-11-30 15:41 ` Ulf Hansson
2021-11-25 21:14 ` [PATCH v3 12/13] ARM: dts: imx: add i.MXRT1050-EVK support Jesse Taube
2021-11-28 16:43 ` Rob Herring
2021-11-28 17:00 ` Jesse Taube
2021-12-03 0:20 ` Giulio Benetti
2021-11-25 21:14 ` [PATCH v3 13/13] ARM: imxrt_defconfig: add i.MXRT family defconfig Jesse Taube
2021-11-25 21:42 ` Arnd Bergmann [this message]
2021-11-25 22:19 ` Jesse Taube
2021-11-29 1:21 ` Giulio Benetti
2021-11-29 1:54 ` Jesse Taube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3dwwBt21o7LDY-CLDdVmOknxDF7sgO_dfiTj8_u4Tx=A@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=abel.vesa@nxp.com \
--cc=adrian.hunter@intel.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mr.bossman075@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
--cc=stefan@agner.ch \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).