* [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property
@ 2022-09-27 10:41 Marek Vasut
2022-09-27 12:04 ` Arnd Bergmann
2022-09-27 12:18 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Marek Vasut @ 2022-09-27 10:41 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Yann Gautier, Alexandre Torgue, Linus Walleij,
Rob Herring, Ulf Hansson, devicetree, linux-mmc, linux-stm32
Document interrupt-names property with "cmd_irq" interrupt name.
This fixes dtbs_check warnings when building current Linux DTs:
"
arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dtb: mmc@58007000: Unevaluated properties are not allowed ('interrupt-names' was unexpected)
"
Reviewed-by: Yann Gautier <yann.gautier@foss.st.com>
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Yann Gautier <yann.gautier@foss.st.com>
Cc: devicetree@vger.kernel.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
V2: - Fix copy-paste error from similar patch for I2C bus bindings
- Add RB from Yann
---
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
index 1e69a5a42439b..5f7eae8d57ab9 100644
--- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
+++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
@@ -99,6 +99,9 @@ properties:
minItems: 1
maxItems: 2
+ interrupt-names:
+ const: cmd_irq
+
st,sig-dir-dat0:
$ref: /schemas/types.yaml#/definitions/flag
description: ST Micro-specific property, bus signal direction pins used for
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property
2022-09-27 10:41 [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property Marek Vasut
@ 2022-09-27 12:04 ` Arnd Bergmann
2022-09-27 12:18 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2022-09-27 12:04 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Yann Gautier, Alexandre Torgue, Linus Walleij, Rob Herring,
Ulf Hansson, devicetree, linux-mmc @ vger . kernel . org,
linux-stm32
On Tue, Sep 27, 2022, at 12:41 PM, Marek Vasut wrote:
> Document interrupt-names property with "cmd_irq" interrupt name.
> This fixes dtbs_check warnings when building current Linux DTs:
>
> "
> arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dtb: mmc@58007000:
> Unevaluated properties are not allowed ('interrupt-names' was
> unexpected)
> "
I don't think that anything relies on the name here. Should
it just be removed from the dts files then? The name does
not follow the usual conventions with the "_irq" postfix.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property
2022-09-27 10:41 [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property Marek Vasut
2022-09-27 12:04 ` Arnd Bergmann
@ 2022-09-27 12:18 ` Linus Walleij
2022-09-27 19:18 ` Marek Vasut
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2022-09-27 12:18 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Yann Gautier, Alexandre Torgue, Rob Herring,
Ulf Hansson, devicetree, linux-mmc, linux-stm32
On Tue, Sep 27, 2022 at 12:41 PM Marek Vasut <marex@denx.de> wrote:
> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -99,6 +99,9 @@ properties:
> minItems: 1
> maxItems: 2
>
> + interrupt-names:
> + const: cmd_irq
This hardware come in variants with one or two IRQs.
Either two: "cmd_irq", "data_irq"
Or one combined IRQ (logic OR between those two!)
I don't know what that should be called, perhaps
"cmd_data_irq".
Since all DTS:es then have to be patched an alternative
is as Arnd says to just delete the names. We should however
at the very least patch the bindings description: for the IRQs
to make the above situation clear.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property
2022-09-27 12:18 ` Linus Walleij
@ 2022-09-27 19:18 ` Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2022-09-27 19:18 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-arm-kernel, Yann Gautier, Alexandre Torgue, Rob Herring,
Ulf Hansson, devicetree, linux-mmc, linux-stm32
On 9/27/22 14:18, Linus Walleij wrote:
> On Tue, Sep 27, 2022 at 12:41 PM Marek Vasut <marex@denx.de> wrote:
>
>> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
>> @@ -99,6 +99,9 @@ properties:
>> minItems: 1
>> maxItems: 2
>>
>> + interrupt-names:
>> + const: cmd_irq
>
> This hardware come in variants with one or two IRQs.
>
> Either two: "cmd_irq", "data_irq"
>
> Or one combined IRQ (logic OR between those two!)
> I don't know what that should be called, perhaps
> "cmd_data_irq".
>
> Since all DTS:es then have to be patched an alternative
> is as Arnd says to just delete the names. We should however
> at the very least patch the bindings description: for the IRQs
> to make the above situation clear.
Done, bindings updated and stm32/qcom DTs cleaned up.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-27 19:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 10:41 [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property Marek Vasut
2022-09-27 12:04 ` Arnd Bergmann
2022-09-27 12:18 ` Linus Walleij
2022-09-27 19:18 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).