* [PATCHv5 0/2] coresight: Do not default to CPU0 for missing CPU phandle
@ 2019-06-27 18:15 Sai Prakash Ranjan
2019-06-27 18:15 ` [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property Sai Prakash Ranjan
2019-06-27 18:15 ` [PATCHv5 2/2] coresight: Do not default to CPU0 for missing CPU phandle Sai Prakash Ranjan
0 siblings, 2 replies; 12+ messages in thread
From: Sai Prakash Ranjan @ 2019-06-27 18:15 UTC (permalink / raw)
To: Mathieu Poirier, Suzuki K Poulose, Rob Herring, devicetree,
Leo Yan, Alexander Shishkin, David Brown, Mark Rutland
Cc: Sai Prakash Ranjan, Rajendra Nayak, linux-arm-msm, linux-kernel,
Sibi Sankar, Vivek Gautam, linux-arm-kernel
In case of missing CPU phandle, the affinity is set default to
CPU0 which is not a correct assumption. Fix this in coresight
platform to set affinity to invalid and abort the probe in drivers.
Also update the dt-bindings accordingly.
v5:
* Separate out the dt-bindings patch.
v4:
* Fix return for !CONFIG_ACPI and !CONFIG_OF.
v3:
* Addressed review comments from Suzuki and updated
acpi_coresight_get_cpu.
* Removed patch 2 which had invalid check for online
cpus.
v2:
* Addressed review comments from Suzuki and Mathieu.
* Allows the probe of etm and cpu-debug to abort earlier
in case of unavailability of respective cpus.
Sai Prakash Ranjan (2):
dt-bindings: coresight: Change CPU phandle to required property
coresight: Do not default to CPU0 for missing CPU phandle
.../bindings/arm/coresight-cpu-debug.txt | 4 ++--
.../devicetree/bindings/arm/coresight.txt | 8 +++++---
.../hwtracing/coresight/coresight-cpu-debug.c | 3 +++
drivers/hwtracing/coresight/coresight-etm3x.c | 3 +++
drivers/hwtracing/coresight/coresight-etm4x.c | 3 +++
.../hwtracing/coresight/coresight-platform.c | 20 +++++++++----------
6 files changed, 26 insertions(+), 15 deletions(-)
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property
2019-06-27 18:15 [PATCHv5 0/2] coresight: Do not default to CPU0 for missing CPU phandle Sai Prakash Ranjan
@ 2019-06-27 18:15 ` Sai Prakash Ranjan
2019-07-03 20:02 ` Mathieu Poirier
2019-06-27 18:15 ` [PATCHv5 2/2] coresight: Do not default to CPU0 for missing CPU phandle Sai Prakash Ranjan
1 sibling, 1 reply; 12+ messages in thread
From: Sai Prakash Ranjan @ 2019-06-27 18:15 UTC (permalink / raw)
To: Mathieu Poirier, Suzuki K Poulose, Rob Herring, devicetree,
Leo Yan, Alexander Shishkin, David Brown, Mark Rutland
Cc: Sai Prakash Ranjan, Rajendra Nayak, linux-arm-msm, linux-kernel,
Sibi Sankar, Vivek Gautam, linux-arm-kernel
Do not assume the affinity to CPU0 if cpu phandle is omitted.
Update the DT binding rules to reflect the same by changing it
to a required property.
Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
.../devicetree/bindings/arm/coresight-cpu-debug.txt | 4 ++--
Documentation/devicetree/bindings/arm/coresight.txt | 8 +++++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt b/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
index 298291211ea4..f1de3247c1b7 100644
--- a/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
+++ b/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
@@ -26,8 +26,8 @@ Required properties:
processor core is clocked by the internal CPU clock, so it
is enabled with CPU clock by default.
-- cpu : the CPU phandle the debug module is affined to. When omitted
- the module is considered to belong to CPU0.
+- cpu : the CPU phandle the debug module is affined to. Do not assume it
+ to default to CPU0 if omitted.
Optional properties:
diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
index 8a88ddebc1a2..fcc3bacfd8bc 100644
--- a/Documentation/devicetree/bindings/arm/coresight.txt
+++ b/Documentation/devicetree/bindings/arm/coresight.txt
@@ -59,6 +59,11 @@ its hardware characteristcs.
* port or ports: see "Graph bindings for Coresight" below.
+* Additional required property for Embedded Trace Macrocell (version 3.x and
+ version 4.x):
+ * cpu: the cpu phandle this ETM/PTM is affined to. Do not
+ assume it to default to CPU0 if omitted.
+
* Additional required properties for System Trace Macrocells (STM):
* reg: along with the physical base address and length of the register
set as described above, another entry is required to describe the
@@ -87,9 +92,6 @@ its hardware characteristcs.
* arm,cp14: must be present if the system accesses ETM/PTM management
registers via co-processor 14.
- * cpu: the cpu phandle this ETM/PTM is affined to. When omitted the
- source is considered to belong to CPU0.
-
* Optional property for TMC:
* arm,buffer-size: size of contiguous buffer space for TMC ETR
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCHv5 2/2] coresight: Do not default to CPU0 for missing CPU phandle
2019-06-27 18:15 [PATCHv5 0/2] coresight: Do not default to CPU0 for missing CPU phandle Sai Prakash Ranjan
2019-06-27 18:15 ` [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property Sai Prakash Ranjan
@ 2019-06-27 18:15 ` Sai Prakash Ranjan
2019-07-03 20:03 ` Mathieu Poirier
1 sibling, 1 reply; 12+ messages in thread
From: Sai Prakash Ranjan @ 2019-06-27 18:15 UTC (permalink / raw)
To: Mathieu Poirier, Suzuki K Poulose, Rob Herring, devicetree,
Leo Yan, Alexander Shishkin, David Brown, Mark Rutland
Cc: Sai Prakash Ranjan, Rajendra Nayak, linux-arm-msm, linux-kernel,
Sibi Sankar, Vivek Gautam, linux-arm-kernel
Coresight platform support assumes that a missing "cpu" phandle
defaults to CPU0. This could be problematic and unnecessarily binds
components to CPU0, where they may not be. In coresight etm and
cpu-debug drivers, abort the probe for such cases.
Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
.../hwtracing/coresight/coresight-cpu-debug.c | 3 +++
drivers/hwtracing/coresight/coresight-etm3x.c | 3 +++
drivers/hwtracing/coresight/coresight-etm4x.c | 3 +++
.../hwtracing/coresight/coresight-platform.c | 20 +++++++++----------
4 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
index 07a1367c733f..58bfd6319f65 100644
--- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
+++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
@@ -579,6 +579,9 @@ static int debug_probe(struct amba_device *adev, const struct amba_id *id)
return -ENOMEM;
drvdata->cpu = coresight_get_cpu(dev);
+ if (drvdata->cpu < 0)
+ return drvdata->cpu;
+
if (per_cpu(debug_drvdata, drvdata->cpu)) {
dev_err(dev, "CPU%d drvdata has already been initialized\n",
drvdata->cpu);
diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c
index 225c2982e4fe..e2cb6873c3f2 100644
--- a/drivers/hwtracing/coresight/coresight-etm3x.c
+++ b/drivers/hwtracing/coresight/coresight-etm3x.c
@@ -816,6 +816,9 @@ static int etm_probe(struct amba_device *adev, const struct amba_id *id)
}
drvdata->cpu = coresight_get_cpu(dev);
+ if (drvdata->cpu < 0)
+ return drvdata->cpu;
+
desc.name = devm_kasprintf(dev, GFP_KERNEL, "etm%d", drvdata->cpu);
if (!desc.name)
return -ENOMEM;
diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
index 7fe266194ab5..7bcac8896fc1 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x.c
@@ -1101,6 +1101,9 @@ static int etm4_probe(struct amba_device *adev, const struct amba_id *id)
spin_lock_init(&drvdata->spinlock);
drvdata->cpu = coresight_get_cpu(dev);
+ if (drvdata->cpu < 0)
+ return drvdata->cpu;
+
desc.name = devm_kasprintf(dev, GFP_KERNEL, "etm%d", drvdata->cpu);
if (!desc.name)
return -ENOMEM;
diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
index 3c5ceda8db24..cf580ffbc27c 100644
--- a/drivers/hwtracing/coresight/coresight-platform.c
+++ b/drivers/hwtracing/coresight/coresight-platform.c
@@ -159,16 +159,16 @@ static int of_coresight_get_cpu(struct device *dev)
struct device_node *dn;
if (!dev->of_node)
- return 0;
+ return -ENODEV;
+
dn = of_parse_phandle(dev->of_node, "cpu", 0);
- /* Affinity defaults to CPU0 */
if (!dn)
- return 0;
+ return -ENODEV;
+
cpu = of_cpu_node_to_id(dn);
of_node_put(dn);
- /* Affinity to CPU0 if no cpu nodes are found */
- return (cpu < 0) ? 0 : cpu;
+ return cpu;
}
/*
@@ -310,7 +310,7 @@ of_get_coresight_platform_data(struct device *dev,
static inline int of_coresight_get_cpu(struct device *dev)
{
- return 0;
+ return -ENODEV;
}
#endif
@@ -734,14 +734,14 @@ static int acpi_coresight_get_cpu(struct device *dev)
struct acpi_device *adev = ACPI_COMPANION(dev);
if (!adev)
- return 0;
+ return -ENODEV;
status = acpi_get_parent(adev->handle, &cpu_handle);
if (ACPI_FAILURE(status))
- return 0;
+ return -ENODEV;
cpu = acpi_handle_to_logical_cpuid(cpu_handle);
if (cpu >= nr_cpu_ids)
- return 0;
+ return -ENODEV;
return cpu;
}
@@ -769,7 +769,7 @@ acpi_get_coresight_platform_data(struct device *dev,
static inline int acpi_coresight_get_cpu(struct device *dev)
{
- return 0;
+ return -ENODEV;
}
#endif
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property
2019-06-27 18:15 ` [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property Sai Prakash Ranjan
@ 2019-07-03 20:02 ` Mathieu Poirier
2019-07-04 6:43 ` Sai Prakash Ranjan
0 siblings, 1 reply; 12+ messages in thread
From: Mathieu Poirier @ 2019-07-03 20:02 UTC (permalink / raw)
To: Sai Prakash Ranjan
Cc: Mark Rutland, devicetree, Rajendra Nayak, Suzuki K Poulose,
Alexander Shishkin, linux-arm-msm, Linux Kernel Mailing List,
David Brown, Rob Herring, Sibi Sankar, Vivek Gautam, Leo Yan,
linux-arm-kernel
Hi Greg,
On Thu, 27 Jun 2019 at 12:15, Sai Prakash Ranjan
<saiprakash.ranjan@codeaurora.org> wrote:
>
> Do not assume the affinity to CPU0 if cpu phandle is omitted.
> Update the DT binding rules to reflect the same by changing it
> to a required property.
>
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
I'm all good with this patch - can you pick this up for the coming
merge window? If not I'll simply keep it in my tree for 5.4.
Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> .../devicetree/bindings/arm/coresight-cpu-debug.txt | 4 ++--
> Documentation/devicetree/bindings/arm/coresight.txt | 8 +++++---
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt b/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
> index 298291211ea4..f1de3247c1b7 100644
> --- a/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
> @@ -26,8 +26,8 @@ Required properties:
> processor core is clocked by the internal CPU clock, so it
> is enabled with CPU clock by default.
>
> -- cpu : the CPU phandle the debug module is affined to. When omitted
> - the module is considered to belong to CPU0.
> +- cpu : the CPU phandle the debug module is affined to. Do not assume it
> + to default to CPU0 if omitted.
>
> Optional properties:
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index 8a88ddebc1a2..fcc3bacfd8bc 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -59,6 +59,11 @@ its hardware characteristcs.
>
> * port or ports: see "Graph bindings for Coresight" below.
>
> +* Additional required property for Embedded Trace Macrocell (version 3.x and
> + version 4.x):
> + * cpu: the cpu phandle this ETM/PTM is affined to. Do not
> + assume it to default to CPU0 if omitted.
> +
> * Additional required properties for System Trace Macrocells (STM):
> * reg: along with the physical base address and length of the register
> set as described above, another entry is required to describe the
> @@ -87,9 +92,6 @@ its hardware characteristcs.
> * arm,cp14: must be present if the system accesses ETM/PTM management
> registers via co-processor 14.
>
> - * cpu: the cpu phandle this ETM/PTM is affined to. When omitted the
> - source is considered to belong to CPU0.
> -
> * Optional property for TMC:
>
> * arm,buffer-size: size of contiguous buffer space for TMC ETR
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv5 2/2] coresight: Do not default to CPU0 for missing CPU phandle
2019-06-27 18:15 ` [PATCHv5 2/2] coresight: Do not default to CPU0 for missing CPU phandle Sai Prakash Ranjan
@ 2019-07-03 20:03 ` Mathieu Poirier
0 siblings, 0 replies; 12+ messages in thread
From: Mathieu Poirier @ 2019-07-03 20:03 UTC (permalink / raw)
To: Sai Prakash Ranjan
Cc: Mark Rutland, devicetree, Rajendra Nayak, Suzuki K Poulose,
Alexander Shishkin, linux-arm-msm, Linux Kernel Mailing List,
David Brown, Rob Herring, Sibi Sankar, Vivek Gautam, Leo Yan,
linux-arm-kernel
On Thu, 27 Jun 2019 at 12:16, Sai Prakash Ranjan
<saiprakash.ranjan@codeaurora.org> wrote:
>
> Coresight platform support assumes that a missing "cpu" phandle
> defaults to CPU0. This could be problematic and unnecessarily binds
> components to CPU0, where they may not be. In coresight etm and
> cpu-debug drivers, abort the probe for such cases.
>
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Same with this one:
Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> .../hwtracing/coresight/coresight-cpu-debug.c | 3 +++
> drivers/hwtracing/coresight/coresight-etm3x.c | 3 +++
> drivers/hwtracing/coresight/coresight-etm4x.c | 3 +++
> .../hwtracing/coresight/coresight-platform.c | 20 +++++++++----------
> 4 files changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> index 07a1367c733f..58bfd6319f65 100644
> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> @@ -579,6 +579,9 @@ static int debug_probe(struct amba_device *adev, const struct amba_id *id)
> return -ENOMEM;
>
> drvdata->cpu = coresight_get_cpu(dev);
> + if (drvdata->cpu < 0)
> + return drvdata->cpu;
> +
> if (per_cpu(debug_drvdata, drvdata->cpu)) {
> dev_err(dev, "CPU%d drvdata has already been initialized\n",
> drvdata->cpu);
> diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c
> index 225c2982e4fe..e2cb6873c3f2 100644
> --- a/drivers/hwtracing/coresight/coresight-etm3x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm3x.c
> @@ -816,6 +816,9 @@ static int etm_probe(struct amba_device *adev, const struct amba_id *id)
> }
>
> drvdata->cpu = coresight_get_cpu(dev);
> + if (drvdata->cpu < 0)
> + return drvdata->cpu;
> +
> desc.name = devm_kasprintf(dev, GFP_KERNEL, "etm%d", drvdata->cpu);
> if (!desc.name)
> return -ENOMEM;
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
> index 7fe266194ab5..7bcac8896fc1 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
> @@ -1101,6 +1101,9 @@ static int etm4_probe(struct amba_device *adev, const struct amba_id *id)
> spin_lock_init(&drvdata->spinlock);
>
> drvdata->cpu = coresight_get_cpu(dev);
> + if (drvdata->cpu < 0)
> + return drvdata->cpu;
> +
> desc.name = devm_kasprintf(dev, GFP_KERNEL, "etm%d", drvdata->cpu);
> if (!desc.name)
> return -ENOMEM;
> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
> index 3c5ceda8db24..cf580ffbc27c 100644
> --- a/drivers/hwtracing/coresight/coresight-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-platform.c
> @@ -159,16 +159,16 @@ static int of_coresight_get_cpu(struct device *dev)
> struct device_node *dn;
>
> if (!dev->of_node)
> - return 0;
> + return -ENODEV;
> +
> dn = of_parse_phandle(dev->of_node, "cpu", 0);
> - /* Affinity defaults to CPU0 */
> if (!dn)
> - return 0;
> + return -ENODEV;
> +
> cpu = of_cpu_node_to_id(dn);
> of_node_put(dn);
>
> - /* Affinity to CPU0 if no cpu nodes are found */
> - return (cpu < 0) ? 0 : cpu;
> + return cpu;
> }
>
> /*
> @@ -310,7 +310,7 @@ of_get_coresight_platform_data(struct device *dev,
>
> static inline int of_coresight_get_cpu(struct device *dev)
> {
> - return 0;
> + return -ENODEV;
> }
> #endif
>
> @@ -734,14 +734,14 @@ static int acpi_coresight_get_cpu(struct device *dev)
> struct acpi_device *adev = ACPI_COMPANION(dev);
>
> if (!adev)
> - return 0;
> + return -ENODEV;
> status = acpi_get_parent(adev->handle, &cpu_handle);
> if (ACPI_FAILURE(status))
> - return 0;
> + return -ENODEV;
>
> cpu = acpi_handle_to_logical_cpuid(cpu_handle);
> if (cpu >= nr_cpu_ids)
> - return 0;
> + return -ENODEV;
> return cpu;
> }
>
> @@ -769,7 +769,7 @@ acpi_get_coresight_platform_data(struct device *dev,
>
> static inline int acpi_coresight_get_cpu(struct device *dev)
> {
> - return 0;
> + return -ENODEV;
> }
> #endif
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property
2019-07-03 20:02 ` Mathieu Poirier
@ 2019-07-04 6:43 ` Sai Prakash Ranjan
2019-07-04 7:02 ` Greg Kroah-Hartman
0 siblings, 1 reply; 12+ messages in thread
From: Sai Prakash Ranjan @ 2019-07-04 6:43 UTC (permalink / raw)
To: Mathieu Poirier, Greg Kroah-Hartman
Cc: Mark Rutland, devicetree, Rajendra Nayak, Suzuki K Poulose,
Alexander Shishkin, linux-arm-msm, Linux Kernel Mailing List,
David Brown, Rob Herring, Sibi Sankar, Vivek Gautam, Leo Yan,
linux-arm-kernel
On 7/4/2019 1:32 AM, Mathieu Poirier wrote:
> Hi Greg,
>
> On Thu, 27 Jun 2019 at 12:15, Sai Prakash Ranjan
> <saiprakash.ranjan@codeaurora.org> wrote:
>>
>> Do not assume the affinity to CPU0 if cpu phandle is omitted.
>> Update the DT binding rules to reflect the same by changing it
>> to a required property.
>>
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> I'm all good with this patch - can you pick this up for the coming
> merge window? If not I'll simply keep it in my tree for 5.4.
>
> Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
I think you missed adding Greg, adding him now ;)
-Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property
2019-07-04 6:43 ` Sai Prakash Ranjan
@ 2019-07-04 7:02 ` Greg Kroah-Hartman
2019-07-04 8:08 ` Marc Gonzalez
0 siblings, 1 reply; 12+ messages in thread
From: Greg Kroah-Hartman @ 2019-07-04 7:02 UTC (permalink / raw)
To: Sai Prakash Ranjan
Cc: Mark Rutland, devicetree, Rajendra Nayak, Mathieu Poirier,
Suzuki K Poulose, Alexander Shishkin, linux-arm-msm,
Linux Kernel Mailing List, David Brown, Rob Herring, Sibi Sankar,
Vivek Gautam, Leo Yan, linux-arm-kernel
On Thu, Jul 04, 2019 at 12:13:40PM +0530, Sai Prakash Ranjan wrote:
> On 7/4/2019 1:32 AM, Mathieu Poirier wrote:
> > Hi Greg,
> >
> > On Thu, 27 Jun 2019 at 12:15, Sai Prakash Ranjan
> > <saiprakash.ranjan@codeaurora.org> wrote:
> > >
> > > Do not assume the affinity to CPU0 if cpu phandle is omitted.
> > > Update the DT binding rules to reflect the same by changing it
> > > to a required property.
> > >
> > > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> > > Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> >
> > I'm all good with this patch - can you pick this up for the coming
> > merge window? If not I'll simply keep it in my tree for 5.4.
> >
> > Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> >
>
> I think you missed adding Greg, adding him now ;)
I don't see any patch here for me to actually take :(
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property
2019-07-04 7:02 ` Greg Kroah-Hartman
@ 2019-07-04 8:08 ` Marc Gonzalez
2019-07-04 8:18 ` Greg Kroah-Hartman
0 siblings, 1 reply; 12+ messages in thread
From: Marc Gonzalez @ 2019-07-04 8:08 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sai Prakash Ranjan, Mathieu Poirier; +Cc: MSM, Linux ARM
[ Trimming recipients list ]
On 04/07/2019 09:02, Greg Kroah-Hartman wrote:
> On Thu, Jul 04, 2019 at 12:13:40PM +0530, Sai Prakash Ranjan wrote:
>
>> On 7/4/2019 1:32 AM, Mathieu Poirier wrote:
>>
>>> Hi Greg,
>>>
>>> On Thu, 27 Jun 2019 at 12:15, Sai Prakash Ranjan wrote:
>>>>
>>>> Do not assume the affinity to CPU0 if cpu phandle is omitted.
>>>> Update the DT binding rules to reflect the same by changing it
>>>> to a required property.
>>>>
>>>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>>>> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>>
>>> I'm all good with this patch - can you pick this up for the coming
>>> merge window? If not I'll simply keep it in my tree for 5.4.
>>>
>>> Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>>> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>>
>> I think you missed adding Greg, adding him now ;)
>
> I don't see any patch here for me to actually take :(
I see what you're doing here ^_^
https://lore.kernel.org/patchwork/patch/1094935/
Regards.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property
2019-07-04 8:08 ` Marc Gonzalez
@ 2019-07-04 8:18 ` Greg Kroah-Hartman
2019-07-04 8:20 ` Sai Prakash Ranjan
2019-07-04 8:51 ` Marc Gonzalez
0 siblings, 2 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2019-07-04 8:18 UTC (permalink / raw)
To: Marc Gonzalez; +Cc: MSM, Sai Prakash Ranjan, Linux ARM, Mathieu Poirier
On Thu, Jul 04, 2019 at 10:08:24AM +0200, Marc Gonzalez wrote:
> [ Trimming recipients list ]
>
> On 04/07/2019 09:02, Greg Kroah-Hartman wrote:
>
> > On Thu, Jul 04, 2019 at 12:13:40PM +0530, Sai Prakash Ranjan wrote:
> >
> >> On 7/4/2019 1:32 AM, Mathieu Poirier wrote:
> >>
> >>> Hi Greg,
> >>>
> >>> On Thu, 27 Jun 2019 at 12:15, Sai Prakash Ranjan wrote:
> >>>>
> >>>> Do not assume the affinity to CPU0 if cpu phandle is omitted.
> >>>> Update the DT binding rules to reflect the same by changing it
> >>>> to a required property.
> >>>>
> >>>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> >>>> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> >>>
> >>> I'm all good with this patch - can you pick this up for the coming
> >>> merge window? If not I'll simply keep it in my tree for 5.4.
> >>>
> >>> Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> >>> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> >>
> >> I think you missed adding Greg, adding him now ;)
> >
> > I don't see any patch here for me to actually take :(
>
> I see what you're doing here ^_^
>
> https://lore.kernel.org/patchwork/patch/1094935/
What can I do with a random url?
Please send patches as emails, if you want me to be able to actually
take it.
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property
2019-07-04 8:18 ` Greg Kroah-Hartman
@ 2019-07-04 8:20 ` Sai Prakash Ranjan
2019-07-04 8:51 ` Marc Gonzalez
1 sibling, 0 replies; 12+ messages in thread
From: Sai Prakash Ranjan @ 2019-07-04 8:20 UTC (permalink / raw)
To: Greg Kroah-Hartman, Marc Gonzalez; +Cc: MSM, Linux ARM, Mathieu Poirier
On 7/4/2019 1:48 PM, Greg Kroah-Hartman wrote:
> On Thu, Jul 04, 2019 at 10:08:24AM +0200, Marc Gonzalez wrote:
>> [ Trimming recipients list ]
>>
>> On 04/07/2019 09:02, Greg Kroah-Hartman wrote:
>>
>>> On Thu, Jul 04, 2019 at 12:13:40PM +0530, Sai Prakash Ranjan wrote:
>>>
>>>> On 7/4/2019 1:32 AM, Mathieu Poirier wrote:
>>>>
>>>>> Hi Greg,
>>>>>
>>>>> On Thu, 27 Jun 2019 at 12:15, Sai Prakash Ranjan wrote:
>>>>>>
>>>>>> Do not assume the affinity to CPU0 if cpu phandle is omitted.
>>>>>> Update the DT binding rules to reflect the same by changing it
>>>>>> to a required property.
>>>>>>
>>>>>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>>>>>> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>>>>
>>>>> I'm all good with this patch - can you pick this up for the coming
>>>>> merge window? If not I'll simply keep it in my tree for 5.4.
>>>>>
>>>>> Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>>>>> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>>>>
>>>> I think you missed adding Greg, adding him now ;)
>>>
>>> I don't see any patch here for me to actually take :(
>>
>> I see what you're doing here ^_^
>>
>> https://lore.kernel.org/patchwork/patch/1094935/
>
> What can I do with a random url?
>
> Please send patches as emails, if you want me to be able to actually
> take it.
>
> greg k-h
>
No worries I will resend them. And thanks Marc :)
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property
2019-07-04 8:18 ` Greg Kroah-Hartman
2019-07-04 8:20 ` Sai Prakash Ranjan
@ 2019-07-04 8:51 ` Marc Gonzalez
2019-07-04 11:05 ` Greg Kroah-Hartman
1 sibling, 1 reply; 12+ messages in thread
From: Marc Gonzalez @ 2019-07-04 8:51 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: MSM, Sai Prakash Ranjan, Linux ARM, Mathieu Poirier
On 04/07/2019 10:18, Greg Kroah-Hartman wrote:
> Marc Gonzalez wrote:
>
>> https://lore.kernel.org/patchwork/patch/1094935/
>
> What can I do with a random url?
I dunno, click it? ^_^
More seriously, patchwork provides individual patches, as well as
patch series, in the same mbox format used by MUAs, e.g.
https://lore.kernel.org/patchwork/patch/1094935/mbox/
https://lore.kernel.org/patchwork/series/400118/mbox/
Then 'git am' works exactly as expected.
I suspect you know all this, and it's too big a hassle vs your usual
work flow, considering the volume of patches you handle.
Just wanted to point it out to those who might not know.
Regards.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property
2019-07-04 8:51 ` Marc Gonzalez
@ 2019-07-04 11:05 ` Greg Kroah-Hartman
0 siblings, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2019-07-04 11:05 UTC (permalink / raw)
To: Marc Gonzalez; +Cc: MSM, Sai Prakash Ranjan, Linux ARM, Mathieu Poirier
On Thu, Jul 04, 2019 at 10:51:20AM +0200, Marc Gonzalez wrote:
> On 04/07/2019 10:18, Greg Kroah-Hartman wrote:
>
> > Marc Gonzalez wrote:
> >
> >> https://lore.kernel.org/patchwork/patch/1094935/
> >
> > What can I do with a random url?
>
> I dunno, click it? ^_^
>
> More seriously, patchwork provides individual patches, as well as
> patch series, in the same mbox format used by MUAs, e.g.
>
> https://lore.kernel.org/patchwork/patch/1094935/mbox/
> https://lore.kernel.org/patchwork/series/400118/mbox/
>
> Then 'git am' works exactly as expected.
>
> I suspect you know all this, and it's too big a hassle vs your usual
> work flow, considering the volume of patches you handle.
And considering that at some times, while traveling, I can _only_ get
email, not web access, so I can't rely on patchwork.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-07-04 11:05 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-27 18:15 [PATCHv5 0/2] coresight: Do not default to CPU0 for missing CPU phandle Sai Prakash Ranjan
2019-06-27 18:15 ` [PATCHv5 1/2] dt-bindings: coresight: Change CPU phandle to required property Sai Prakash Ranjan
2019-07-03 20:02 ` Mathieu Poirier
2019-07-04 6:43 ` Sai Prakash Ranjan
2019-07-04 7:02 ` Greg Kroah-Hartman
2019-07-04 8:08 ` Marc Gonzalez
2019-07-04 8:18 ` Greg Kroah-Hartman
2019-07-04 8:20 ` Sai Prakash Ranjan
2019-07-04 8:51 ` Marc Gonzalez
2019-07-04 11:05 ` Greg Kroah-Hartman
2019-06-27 18:15 ` [PATCHv5 2/2] coresight: Do not default to CPU0 for missing CPU phandle Sai Prakash Ranjan
2019-07-03 20:03 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).