From: Bart Van Assche <bvanassche@acm.org>
To: Asutosh Das <quic_asutoshd@quicinc.com>,
mani@kernel.org, quic_nguyenb@quicinc.com,
quic_xiaosenh@quicinc.com, quic_cang@quicinc.com,
quic_nitirawa@quicinc.com, quic_rampraka@quicinc.com,
quic_richardp@quicinc.com, stanley.chu@mediatek.com,
adrian.hunter@intel.com, avri.altman@wdc.com, beanhuo@micron.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Kiwoong Kim <kwmad.kim@samsung.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v1 13/16] ufs: mcq: Add completion support of a cqe
Date: Fri, 30 Sep 2022 13:41:31 -0700 [thread overview]
Message-ID: <d0ce6b32-04ac-e3bc-d999-6a9c3d757645@acm.org> (raw)
In-Reply-To: <80b24ce43aadac3bf561a60a65303f36ae8c0c21.1663894792.git.quic_asutoshd@quicinc.com>
On 9/22/22 18:05, Asutosh Das wrote:
> +static int ufshcd_mcq_get_tag(struct ufs_hba *hba,
> + struct ufs_hw_queue *hwq,
> + struct cq_entry *cqe)
> +{
> + dma_addr_t dma_addr;
> +
> + /* Bits 63:7 UCD base address, 6:5 are reserved, 4:0 is SQ ID */
> + dma_addr = le64_to_cpu(cqe->command_desc_base_addr) & CQE_UCD_BA;
> +
> + return (dma_addr - hba->ucdl_dma_addr) /
> + sizeof(struct utp_transfer_cmd_desc);
> +}
Since the above code only works correctly if the size of struct
utp_transfer_cmd_desc is a multiple of 1 << 7, please add a
BUILD_BUG_ON() statement that verifies that the size of
utp_transfer_cmd_desc is a multiple of 128.
Thanks,
Bart.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-30 20:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 1:05 [PATCH v1 00/16] Add Multi Circular Queue Support Asutosh Das
2022-09-23 1:05 ` [PATCH v1 01/16] ufs: core: Probe for ext_iid support Asutosh Das
2022-09-26 14:08 ` Manivannan Sadhasivam
2022-09-30 18:23 ` Bart Van Assche
2022-10-04 22:09 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 02/16] ufs: core: Introduce Multi-circular queue capability Asutosh Das
2022-09-24 8:13 ` Avri Altman
2022-09-26 21:34 ` Asutosh Das
2022-09-26 14:27 ` Manivannan Sadhasivam
2022-09-23 1:05 ` [PATCH v1 03/16] ufs: core: Defer adding host to scsi if mcq is supported Asutosh Das
2022-09-30 18:32 ` Bart Van Assche
2022-10-04 18:51 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 04/16] ufs: core: mcq: Introduce Multi Circular Queue Asutosh Das
2022-09-26 14:49 ` Manivannan Sadhasivam
2022-09-26 21:32 ` Asutosh Das
2022-09-30 18:37 ` Bart Van Assche
2022-09-23 1:05 ` [PATCH v1 05/16] ufs: core: mcq: Configure resource regions Asutosh Das
2022-09-26 15:07 ` Manivannan Sadhasivam
2022-09-30 18:42 ` Bart Van Assche
2022-09-23 1:05 ` [PATCH v1 06/16] ufs: core: mcq: Calculate queue depth Asutosh Das
2022-09-26 15:22 ` Manivannan Sadhasivam
2022-09-26 21:23 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 07/16] ufs: core: mcq: Allocate memory for mcq mode Asutosh Das
2022-09-26 15:45 ` Manivannan Sadhasivam
2022-10-03 20:25 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 08/16] ufs: core: mcq: Configure operation and runtime interface Asutosh Das
2022-09-23 1:05 ` [PATCH v1 09/16] ufs: core: mcq: Use shared tags for MCQ mode Asutosh Das
2022-09-23 1:05 ` [PATCH v1 10/16] ufs: core: Prepare ufshcd_send_command for mcq Asutosh Das
2022-09-23 1:05 ` [PATCH v1 11/16] ufs: core: mcq: Find hardware queue to queue request Asutosh Das
2022-09-23 1:05 ` [PATCH v1 12/16] ufs: core: Prepare for completion in mcq Asutosh Das
2022-09-30 20:43 ` Bart Van Assche
2022-09-23 1:05 ` [PATCH v1 13/16] ufs: mcq: Add completion support of a cqe Asutosh Das
2022-09-30 20:41 ` Bart Van Assche [this message]
2022-09-23 1:05 ` [PATCH v1 14/16] ufs: core: mcq: Add completion support in poll Asutosh Das
2022-09-23 1:05 ` [PATCH v1 15/16] ufs: core: mcq: Enable Multi Circular Queue Asutosh Das
2022-09-30 20:32 ` Bart Van Assche
2022-09-23 1:05 ` [PATCH v1 16/16] ufs: qcom-host: Enable multi circular queue capability Asutosh Das
2022-09-26 13:49 ` [PATCH v1 00/16] Add Multi Circular Queue Support Manivannan Sadhasivam
2022-09-26 18:55 ` Asutosh Das
2022-09-30 20:44 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0ce6b32-04ac-e3bc-d999-6a9c3d757645@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bjorn.andersson@linaro.org \
--cc=jejb@linux.ibm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_richardp@quicinc.com \
--cc=quic_xiaosenh@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).