* [PATCH] ARM: dts: bcm283x: Add missing properties to the PWR LED
@ 2020-02-23 18:03 Stefan Wahren
2020-02-25 13:29 ` Peter Robinson
2020-02-27 19:29 ` Florian Fainelli
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Wahren @ 2020-02-23 18:03 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden
Cc: Stefan Wahren, devicetree, bcm-kernel-feedback-list,
linux-rpi-kernel, linux-arm-kernel
This adds the missing properties to the PWR LED for the RPi 3 & 4 boards,
which are already set for the other boards. Without them we will lose
the LED state after suspend.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 2 ++
arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts | 2 ++
arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 ++
3 files changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
index cb33852..f242834 100644
--- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
+++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
@@ -31,6 +31,8 @@
pwr {
label = "PWR";
gpios = <&expgpio 2 GPIO_ACTIVE_LOW>;
+ default-state = "keep";
+ linux,default-trigger = "default-on";
};
};
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
index 66ab35e..28be033 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
@@ -26,6 +26,8 @@
pwr {
label = "PWR";
gpios = <&expgpio 2 GPIO_ACTIVE_LOW>;
+ default-state = "keep";
+ linux,default-trigger = "default-on";
};
};
};
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
index 74ed6d0..3734314 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
@@ -27,6 +27,8 @@
pwr {
label = "PWR";
gpios = <&expgpio 2 GPIO_ACTIVE_LOW>;
+ default-state = "keep";
+ linux,default-trigger = "default-on";
};
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: bcm283x: Add missing properties to the PWR LED
2020-02-23 18:03 [PATCH] ARM: dts: bcm283x: Add missing properties to the PWR LED Stefan Wahren
@ 2020-02-25 13:29 ` Peter Robinson
2020-02-25 13:50 ` Stefan Wahren
2020-02-27 19:29 ` Florian Fainelli
1 sibling, 1 reply; 4+ messages in thread
From: Peter Robinson @ 2020-02-25 13:29 UTC (permalink / raw)
To: Stefan Wahren
Cc: linux-arm-kernel, devicetree, Florian Fainelli, Scott Branden,
Ray Jui, bcm-kernel-feedback-list, linux-rpi-kernel,
Nicolas Saenz Julienne
> This adds the missing properties to the PWR LED for the RPi 3 & 4 boards,
> which are already set for the other boards. Without them we will lose
> the LED state after suspend.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>
Tested on a 3B+ and a 4B. On a related note it seems that the original
RPi3B is missing the pwr led entry altogether, is that expected given
that at least the 2, other 3 models have the entry?
Peter
> ---
> arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 2 ++
> arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts | 2 ++
> arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 ++
> 3 files changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> index cb33852..f242834 100644
> --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> @@ -31,6 +31,8 @@
> pwr {
> label = "PWR";
> gpios = <&expgpio 2 GPIO_ACTIVE_LOW>;
> + default-state = "keep";
> + linux,default-trigger = "default-on";
> };
> };
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
> index 66ab35e..28be033 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
> @@ -26,6 +26,8 @@
> pwr {
> label = "PWR";
> gpios = <&expgpio 2 GPIO_ACTIVE_LOW>;
> + default-state = "keep";
> + linux,default-trigger = "default-on";
> };
> };
> };
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> index 74ed6d0..3734314 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> @@ -27,6 +27,8 @@
> pwr {
> label = "PWR";
> gpios = <&expgpio 2 GPIO_ACTIVE_LOW>;
> + default-state = "keep";
> + linux,default-trigger = "default-on";
> };
> };
>
> --
> 2.7.4
>
>
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: bcm283x: Add missing properties to the PWR LED
2020-02-25 13:29 ` Peter Robinson
@ 2020-02-25 13:50 ` Stefan Wahren
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2020-02-25 13:50 UTC (permalink / raw)
To: Peter Robinson
Cc: devicetree, Florian Fainelli, Scott Branden, Ray Jui,
Nicolas Saenz Julienne, bcm-kernel-feedback-list,
linux-rpi-kernel, linux-arm-kernel
Hi Peter,
On 25.02.20 14:29, Peter Robinson wrote:
>> This adds the missing properties to the PWR LED for the RPi 3 & 4 boards,
>> which are already set for the other boards. Without them we will lose
>> the LED state after suspend.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Tested-by: Peter Robinson <pbrobinson@gmail.com>
thanks
>
> Tested on a 3B+ and a 4B. On a related note it seems that the original
> RPi3B is missing the pwr led entry altogether, is that expected given
> that at least the 2, other 3 models have the entry?
This is expected since the PWR LED on the 3B doesn't have a real
dedicated GPIO. In downstream this is handled via a virtual GPIO driver
which isn't available in mainline.
Best regards
Stefan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: bcm283x: Add missing properties to the PWR LED
2020-02-23 18:03 [PATCH] ARM: dts: bcm283x: Add missing properties to the PWR LED Stefan Wahren
2020-02-25 13:29 ` Peter Robinson
@ 2020-02-27 19:29 ` Florian Fainelli
1 sibling, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2020-02-27 19:29 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Stefan Wahren, Nicolas Saenz Julienne,
Ray Jui, Scott Branden
Cc: devicetree, linux-rpi-kernel, linux-arm-kernel
On Sun, 23 Feb 2020 19:03:05 +0100, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> This adds the missing properties to the PWR LED for the RPi 3 & 4 boards,
> which are already set for the other boards. Without them we will lose
> the LED state after suspend.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
Applied to devicetree/fixes, thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-27 19:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-23 18:03 [PATCH] ARM: dts: bcm283x: Add missing properties to the PWR LED Stefan Wahren
2020-02-25 13:29 ` Peter Robinson
2020-02-25 13:50 ` Stefan Wahren
2020-02-27 19:29 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).