From: Thomas Zimmermann <tzimmermann@suse.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Albert Ou <aou@eecs.berkeley.edu>,
David Airlie <airlied@linux.ie>,
Catalin Marinas <catalin.marinas@arm.com>,
Russell King <linux@armlinux.org.uk>,
dri-devel@lists.freedesktop.org,
Hans de Goede <hdegoede@redhat.com>,
linux-efi@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>,
Peter Robinson <pbrobinson@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org, Will Deacon <will@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] drivers/firmware: consolidate EFI framebuffer setup for all arches
Date: Sat, 22 May 2021 07:14:25 +0200 [thread overview]
Message-ID: <e23a44ba-5e9d-d27b-b5e8-0cce3b158ed7@suse.de> (raw)
In-Reply-To: <20210521193704.3042024-1-javierm@redhat.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1935 bytes --]
Hi
Am 21.05.21 um 21:37 schrieb Javier Martinez Canillas:
> The register_gop_device() function registers an "efi-framebuffer" platform
> device to match against the efifb driver, to have an early framebuffer for
> EFI platforms.
>
> But the Generic System Framebuffers (sysfb) already has support for this.
>
> Instead of having duplicated logic for x86 and other architectures using
> EFI, consolidate the two in sysfb and remove it from the EFI init logic.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
>
> arch/arm/Kconfig | 1 +
> arch/arm/include/asm/efi.h | 5 +-
> arch/arm64/Kconfig | 1 +
> arch/arm64/include/asm/efi.h | 5 +-
> arch/riscv/Kconfig | 1 +
> arch/riscv/include/asm/efi.h | 5 +-
> drivers/firmware/Kconfig | 7 ++-
> drivers/firmware/Makefile | 2 +-
> drivers/firmware/efi/efi-init.c | 90 -------------------------------
> drivers/firmware/efi/sysfb_efi.c | 77 +++++++++++++++++++++++++-
> drivers/firmware/sysfb.c | 40 +++++++++-----
> drivers/firmware/sysfb_simplefb.c | 29 ++++++----
> include/linux/sysfb.h | 28 +++++-----
> 13 files changed, 145 insertions(+), 146 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 24804f11302..30ba195ca72 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -127,6 +127,7 @@ config ARM
> select PERF_USE_VMALLOC
> select RTC_LIB
> select SET_FS
> + select SYSFB
Don't select this as part of the architecture. Rather make an option for
SYSFB that depends in the architectures that supports it.
Best regards
Thomas
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-22 5:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 19:37 [PATCH 2/2] drivers/firmware: consolidate EFI framebuffer setup for all arches Javier Martinez Canillas
2021-05-22 5:14 ` Thomas Zimmermann [this message]
2021-05-28 8:03 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e23a44ba-5e9d-d27b-b5e8-0cce3b158ed7@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=javierm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pbrobinson@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).