From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Fabien Parent <fparent@baylibre.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: matthias.bgg@gmail.com, tglx@linutronix.de
Subject: Re: [PATCH] clocksource: mediatek: fix error handling
Date: Wed, 25 Sep 2019 18:42:36 +0200 [thread overview]
Message-ID: <e52093c9-a519-62e5-1c1e-acd626a92798@linaro.org> (raw)
In-Reply-To: <20190919191315.25190-1-fparent@baylibre.com>
On 19/09/2019 21:13, Fabien Parent wrote:
> When timer_of_init fails, it cleans up after itself by undoing
> everything it did during the initialization function.
>
> mtk_syst_init and mtk_gpt_init both call timer_of_cleanup if
> timer_of_init fails. timer_of_cleanup try to release the resource taken.
> Since these resources have already been cleaned up by timer_of_init,
> we end up getting a few warnings printed:
[ ... ]
> This commit remove the calls to timer_of_cleanup when timer_of_init
> fails since it is unnecessary and actually cause warnings to be printed.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Applied, thanks for the fix!
In the future add the 'Fixes' tag please.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-09-25 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 19:13 [PATCH] clocksource: mediatek: fix error handling Fabien Parent
2019-09-25 16:42 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e52093c9-a519-62e5-1c1e-acd626a92798@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=fparent@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).