Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver
@ 2020-02-14 21:47 Scott Branden
  2020-02-14 21:50 ` Andrew Lunn
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Scott Branden @ 2020-02-14 21:47 UTC (permalink / raw)
  To: Andrew Lunn, Florian Fainelli, Heiner Kallweit
  Cc: Scott Branden, Ray Jui, Arun Parameswaran, Russell King,
	linux-kernel, bcm-kernel-feedback-list, netdev, David S . Miller,
	linux-arm-kernel

From: Arun Parameswaran <arun.parameswaran@broadcom.com>

The mii management register in iproc mdio block
does not have a retention register so it is lost on suspend.
Save and restore value of register while resuming from suspend.

Fixes: bb1a619735b4 ("net: phy: Initialize mdio clock at probe function")

Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
Signed-off-by: Scott Branden <scott.branden@broadcom.com>
---
 drivers/net/phy/mdio-bcm-iproc.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/net/phy/mdio-bcm-iproc.c b/drivers/net/phy/mdio-bcm-iproc.c
index 7e9975d25066..f1ded03f0229 100644
--- a/drivers/net/phy/mdio-bcm-iproc.c
+++ b/drivers/net/phy/mdio-bcm-iproc.c
@@ -178,6 +178,23 @@ static int iproc_mdio_remove(struct platform_device *pdev)
 	return 0;
 }
 
+#ifdef CONFIG_PM_SLEEP
+int iproc_mdio_resume(struct device *dev)
+{
+	struct platform_device *pdev = to_platform_device(dev);
+	struct iproc_mdio_priv *priv = platform_get_drvdata(pdev);
+
+	/* restore the mii clock configuration */
+	iproc_mdio_config_clk(priv->base);
+
+	return 0;
+}
+
+static const struct dev_pm_ops iproc_mdio_pm_ops = {
+	.resume = iproc_mdio_resume
+};
+#endif /* CONFIG_PM_SLEEP */
+
 static const struct of_device_id iproc_mdio_of_match[] = {
 	{ .compatible = "brcm,iproc-mdio", },
 	{ /* sentinel */ },
@@ -188,6 +205,9 @@ static struct platform_driver iproc_mdio_driver = {
 	.driver = {
 		.name = "iproc-mdio",
 		.of_match_table = iproc_mdio_of_match,
+#ifdef CONFIG_PM_SLEEP
+		.pm = &iproc_mdio_pm_ops,
+#endif
 	},
 	.probe = iproc_mdio_probe,
 	.remove = iproc_mdio_remove,
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver
  2020-02-14 21:47 [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver Scott Branden
@ 2020-02-14 21:50 ` Andrew Lunn
  2020-02-14 22:02 ` Florian Fainelli
  2020-02-17  3:19 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2020-02-14 21:50 UTC (permalink / raw)
  To: Scott Branden
  Cc: Florian Fainelli, Ray Jui, Arun Parameswaran, Russell King,
	linux-kernel, bcm-kernel-feedback-list, netdev, David S . Miller,
	linux-arm-kernel, Heiner Kallweit

On Fri, Feb 14, 2020 at 01:47:46PM -0800, Scott Branden wrote:
> From: Arun Parameswaran <arun.parameswaran@broadcom.com>
> 
> The mii management register in iproc mdio block
> does not have a retention register so it is lost on suspend.
> Save and restore value of register while resuming from suspend.

You actually just reconfigure, you don't save it. But that is minor.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver
  2020-02-14 21:47 [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver Scott Branden
  2020-02-14 21:50 ` Andrew Lunn
@ 2020-02-14 22:02 ` Florian Fainelli
  2020-02-17  3:19 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2020-02-14 22:02 UTC (permalink / raw)
  To: Scott Branden, Andrew Lunn, Heiner Kallweit
  Cc: Ray Jui, Arun Parameswaran, Russell King, linux-kernel,
	bcm-kernel-feedback-list, netdev, David S . Miller,
	linux-arm-kernel

On 2/14/20 1:47 PM, Scott Branden wrote:
> From: Arun Parameswaran <arun.parameswaran@broadcom.com>
> 
> The mii management register in iproc mdio block
> does not have a retention register so it is lost on suspend.
> Save and restore value of register while resuming from suspend.
> 
> Fixes: bb1a619735b4 ("net: phy: Initialize mdio clock at probe function")
> 
> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver
  2020-02-14 21:47 [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver Scott Branden
  2020-02-14 21:50 ` Andrew Lunn
  2020-02-14 22:02 ` Florian Fainelli
@ 2020-02-17  3:19 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-02-17  3:19 UTC (permalink / raw)
  To: scott.branden
  Cc: andrew, f.fainelli, rjui, arun.parameswaran, linux, linux-kernel,
	bcm-kernel-feedback-list, netdev, linux-arm-kernel, hkallweit1

From: Scott Branden <scott.branden@broadcom.com>
Date: Fri, 14 Feb 2020 13:47:46 -0800

> From: Arun Parameswaran <arun.parameswaran@broadcom.com>
> 
> The mii management register in iproc mdio block
> does not have a retention register so it is lost on suspend.
> Save and restore value of register while resuming from suspend.
> 
> Fixes: bb1a619735b4 ("net: phy: Initialize mdio clock at probe function")
> 
> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>

Applied and queued up for -stable.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 21:47 [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver Scott Branden
2020-02-14 21:50 ` Andrew Lunn
2020-02-14 22:02 ` Florian Fainelli
2020-02-17  3:19 ` David Miller

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git