* [PATCH net-next 0/2] net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII @ 2019-05-22 19:56 Heiner Kallweit 2019-05-22 19:57 ` [PATCH net-next 1/2] " Heiner Kallweit 2019-05-22 19:58 ` [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support Heiner Kallweit 0 siblings, 2 replies; 10+ messages in thread From: Heiner Kallweit @ 2019-05-22 19:56 UTC (permalink / raw) To: Madalin-cristian Bucur, Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Andrew Lunn, Florian Fainelli, David Miller Cc: netdev, linux-arm-kernel, devicetree Add mode USXGMII and change places where so far (incorrectly) XGMII was used instead. Heiner Kallweit (2): net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII net: phy: aquantia: add USXGMII support arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 2 +- drivers/net/phy/aquantia_main.c | 6 +++++- include/linux/phy.h | 3 +++ 4 files changed, 10 insertions(+), 3 deletions(-) -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH net-next 1/2] net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII 2019-05-22 19:56 [PATCH net-next 0/2] net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII Heiner Kallweit @ 2019-05-22 19:57 ` Heiner Kallweit 2019-05-22 20:06 ` Florian Fainelli 2019-05-22 19:58 ` [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support Heiner Kallweit 1 sibling, 1 reply; 10+ messages in thread From: Heiner Kallweit @ 2019-05-22 19:57 UTC (permalink / raw) To: Madalin-cristian Bucur, Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Andrew Lunn, Florian Fainelli, David Miller Cc: netdev, linux-arm-kernel, devicetree Add support for interface mode PHY_INTERFACE_MODE_USXGMII. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- include/linux/phy.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 073fb151b..7180b1d1e 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -103,6 +103,7 @@ typedef enum { PHY_INTERFACE_MODE_XAUI, /* 10GBASE-KR, XFI, SFI - single lane 10G Serdes */ PHY_INTERFACE_MODE_10GKR, + PHY_INTERFACE_MODE_USXGMII, PHY_INTERFACE_MODE_MAX, } phy_interface_t; @@ -178,6 +179,8 @@ static inline const char *phy_modes(phy_interface_t interface) return "xaui"; case PHY_INTERFACE_MODE_10GKR: return "10gbase-kr"; + case PHY_INTERFACE_MODE_USXGMII: + return "usxgmii"; default: return "unknown"; } -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH net-next 1/2] net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII 2019-05-22 19:57 ` [PATCH net-next 1/2] " Heiner Kallweit @ 2019-05-22 20:06 ` Florian Fainelli 2019-05-22 20:20 ` Heiner Kallweit 0 siblings, 1 reply; 10+ messages in thread From: Florian Fainelli @ 2019-05-22 20:06 UTC (permalink / raw) To: Heiner Kallweit, Madalin-cristian Bucur, Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Andrew Lunn, David Miller Cc: netdev, linux-arm-kernel, devicetree On 5/22/19 12:57 PM, Heiner Kallweit wrote: > Add support for interface mode PHY_INTERFACE_MODE_USXGMII. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> If you update Documentation/devicetree/bindings/net/ethernet.txt, then this is: Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next 1/2] net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII 2019-05-22 20:06 ` Florian Fainelli @ 2019-05-22 20:20 ` Heiner Kallweit 0 siblings, 0 replies; 10+ messages in thread From: Heiner Kallweit @ 2019-05-22 20:20 UTC (permalink / raw) To: Florian Fainelli, Madalin-cristian Bucur, Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Andrew Lunn, David Miller Cc: netdev, linux-arm-kernel, devicetree On 22.05.2019 22:06, Florian Fainelli wrote: > On 5/22/19 12:57 PM, Heiner Kallweit wrote: >> Add support for interface mode PHY_INTERFACE_MODE_USXGMII. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > If you update Documentation/devicetree/bindings/net/ethernet.txt, then > this is: > Indeed, that's missing. Thanks for the hint. > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support 2019-05-22 19:56 [PATCH net-next 0/2] net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII Heiner Kallweit 2019-05-22 19:57 ` [PATCH net-next 1/2] " Heiner Kallweit @ 2019-05-22 19:58 ` Heiner Kallweit 2019-05-22 20:07 ` Florian Fainelli 2019-05-22 20:58 ` Andrew Lunn 1 sibling, 2 replies; 10+ messages in thread From: Heiner Kallweit @ 2019-05-22 19:58 UTC (permalink / raw) To: Madalin-cristian Bucur, Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Andrew Lunn, Florian Fainelli, David Miller Cc: netdev, linux-arm-kernel, devicetree So far we didn't support mode USXGMII, and in order to not break the two Freescale boards mode XGMII was accepted for the AQR107 family even though it doesn't support XGMII. Add USXGMII support to the Aquantia PHY driver and change the phy connection type for the two boards. As an additional note: Even though the handle is named aqr106 there seem to be LS1046A boards with an AQR107. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 2 +- drivers/net/phy/aquantia_main.c | 6 +++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts index 4223a2352..c2ce1a611 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts @@ -139,7 +139,7 @@ ethernet@f0000 { /* 10GEC1 */ phy-handle = <&aqr105_phy>; - phy-connection-type = "xgmii"; + phy-connection-type = "usxgmii"; }; mdio@fc000 { diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts index 6a6514d0e..f927a8a25 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts @@ -147,7 +147,7 @@ ethernet@f0000 { /* 10GEC1 */ phy-handle = <&aqr106_phy>; - phy-connection-type = "xgmii"; + phy-connection-type = "usxgmii"; }; ethernet@f2000 { /* 10GEC2 */ diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c index 0fedd28fd..3f24c42a8 100644 --- a/drivers/net/phy/aquantia_main.c +++ b/drivers/net/phy/aquantia_main.c @@ -27,6 +27,7 @@ #define MDIO_PHYXS_VEND_IF_STATUS_TYPE_MASK GENMASK(7, 3) #define MDIO_PHYXS_VEND_IF_STATUS_TYPE_KR 0 #define MDIO_PHYXS_VEND_IF_STATUS_TYPE_XFI 2 +#define MDIO_PHYXS_VEND_IF_STATUS_TYPE_USXGMII 3 #define MDIO_PHYXS_VEND_IF_STATUS_TYPE_SGMII 6 #define MDIO_PHYXS_VEND_IF_STATUS_TYPE_OCSGMII 10 @@ -360,6 +361,9 @@ static int aqr107_read_status(struct phy_device *phydev) case MDIO_PHYXS_VEND_IF_STATUS_TYPE_XFI: phydev->interface = PHY_INTERFACE_MODE_10GKR; break; + case MDIO_PHYXS_VEND_IF_STATUS_TYPE_USXGMII: + phydev->interface = PHY_INTERFACE_MODE_USXGMII; + break; case MDIO_PHYXS_VEND_IF_STATUS_TYPE_SGMII: phydev->interface = PHY_INTERFACE_MODE_SGMII; break; @@ -487,7 +491,7 @@ static int aqr107_config_init(struct phy_device *phydev) /* Check that the PHY interface type is compatible */ if (phydev->interface != PHY_INTERFACE_MODE_SGMII && phydev->interface != PHY_INTERFACE_MODE_2500BASEX && - phydev->interface != PHY_INTERFACE_MODE_XGMII && + phydev->interface != PHY_INTERFACE_MODE_USXGMII && phydev->interface != PHY_INTERFACE_MODE_10GKR) return -ENODEV; -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support 2019-05-22 19:58 ` [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support Heiner Kallweit @ 2019-05-22 20:07 ` Florian Fainelli 2019-05-22 20:18 ` Heiner Kallweit 2019-05-22 20:58 ` Andrew Lunn 1 sibling, 1 reply; 10+ messages in thread From: Florian Fainelli @ 2019-05-22 20:07 UTC (permalink / raw) To: Heiner Kallweit, Madalin-cristian Bucur, Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Andrew Lunn, David Miller Cc: netdev, linux-arm-kernel, devicetree On 5/22/19 12:58 PM, Heiner Kallweit wrote: > So far we didn't support mode USXGMII, and in order to not break the > two Freescale boards mode XGMII was accepted for the AQR107 family > even though it doesn't support XGMII. Add USXGMII support to the > Aquantia PHY driver and change the phy connection type for the two > boards. > > As an additional note: Even though the handle is named aqr106 > there seem to be LS1046A boards with an AQR107. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> You can probably split the DTS changes and the PHY driver changes into a separate commits and just have the DTS changes come last? With that: Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support 2019-05-22 20:07 ` Florian Fainelli @ 2019-05-22 20:18 ` Heiner Kallweit 2019-05-22 20:29 ` Florian Fainelli 0 siblings, 1 reply; 10+ messages in thread From: Heiner Kallweit @ 2019-05-22 20:18 UTC (permalink / raw) To: Florian Fainelli, Madalin-cristian Bucur, Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Andrew Lunn, David Miller Cc: netdev, linux-arm-kernel, devicetree On 22.05.2019 22:07, Florian Fainelli wrote: > On 5/22/19 12:58 PM, Heiner Kallweit wrote: >> So far we didn't support mode USXGMII, and in order to not break the >> two Freescale boards mode XGMII was accepted for the AQR107 family >> even though it doesn't support XGMII. Add USXGMII support to the >> Aquantia PHY driver and change the phy connection type for the two >> boards. >> >> As an additional note: Even though the handle is named aqr106 >> there seem to be LS1046A boards with an AQR107. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > You can probably split the DTS changes and the PHY driver changes into a > separate commits and just have the DTS changes come last? With that: > To split the patches I would have to do: 1. Add USXGMII support to Aquantia PHY driver 2. DTS changes 3. Don't accept XGMII any longer in Aquantia PHY driver This seemed to me to be too much overhead considering the very small change. Just making the DTS changes a separate patch would break bisecting. > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support 2019-05-22 20:18 ` Heiner Kallweit @ 2019-05-22 20:29 ` Florian Fainelli 0 siblings, 0 replies; 10+ messages in thread From: Florian Fainelli @ 2019-05-22 20:29 UTC (permalink / raw) To: Heiner Kallweit, Madalin-cristian Bucur, Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Andrew Lunn, David Miller Cc: netdev, linux-arm-kernel, devicetree On 5/22/19 1:18 PM, Heiner Kallweit wrote: > On 22.05.2019 22:07, Florian Fainelli wrote: >> On 5/22/19 12:58 PM, Heiner Kallweit wrote: >>> So far we didn't support mode USXGMII, and in order to not break the >>> two Freescale boards mode XGMII was accepted for the AQR107 family >>> even though it doesn't support XGMII. Add USXGMII support to the >>> Aquantia PHY driver and change the phy connection type for the two >>> boards. >>> >>> As an additional note: Even though the handle is named aqr106 >>> there seem to be LS1046A boards with an AQR107. >>> >>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >> >> You can probably split the DTS changes and the PHY driver changes into a >> separate commits and just have the DTS changes come last? With that: >> > To split the patches I would have to do: > 1. Add USXGMII support to Aquantia PHY driver > 2. DTS changes > 3. Don't accept XGMII any longer in Aquantia PHY driver > This seemed to me to be too much overhead considering the very small > change. > > Just making the DTS changes a separate patch would break bisecting. I fail to see how, you can't make use of "usxgmii" in DTS unless you define that as as a valid phy-mode property value (patch #1), and you can't have that possibly working until patch #2. Until then using "xgmii" is still supported and going to work. Once patch #3 which brings DTS lands in, you could possibly deprecate "xgmii" in the Aquantia PHY driver (or rather issue a big warning). -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support 2019-05-22 19:58 ` [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support Heiner Kallweit 2019-05-22 20:07 ` Florian Fainelli @ 2019-05-22 20:58 ` Andrew Lunn 2019-05-23 4:08 ` Heiner Kallweit 1 sibling, 1 reply; 10+ messages in thread From: Andrew Lunn @ 2019-05-22 20:58 UTC (permalink / raw) To: Heiner Kallweit Cc: Mark Rutland, devicetree, Florian Fainelli, Madalin-cristian Bucur, netdev, Li Yang, Rob Herring, Shawn Guo, David Miller, linux-arm-kernel On Wed, May 22, 2019 at 09:58:32PM +0200, Heiner Kallweit wrote: > So far we didn't support mode USXGMII, and in order to not break the > two Freescale boards mode XGMII was accepted for the AQR107 family > even though it doesn't support XGMII. Add USXGMII support to the > Aquantia PHY driver and change the phy connection type for the two > boards. > > As an additional note: Even though the handle is named aqr106 > there seem to be LS1046A boards with an AQR107. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 +- > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 2 +- > drivers/net/phy/aquantia_main.c | 6 +++++- > 3 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts > index 4223a2352..c2ce1a611 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts > @@ -139,7 +139,7 @@ > > ethernet@f0000 { /* 10GEC1 */ > phy-handle = <&aqr105_phy>; > - phy-connection-type = "xgmii"; > + phy-connection-type = "usxgmii"; > }; > > mdio@fc000 { > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts > index 6a6514d0e..f927a8a25 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts > @@ -147,7 +147,7 @@ > > ethernet@f0000 { /* 10GEC1 */ > phy-handle = <&aqr106_phy>; > - phy-connection-type = "xgmii"; > + phy-connection-type = "usxgmii"; > }; > > ethernet@f2000 { /* 10GEC2 */ > diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c > index 0fedd28fd..3f24c42a8 100644 > @@ -487,7 +491,7 @@ static int aqr107_config_init(struct phy_device *phydev) > /* Check that the PHY interface type is compatible */ > if (phydev->interface != PHY_INTERFACE_MODE_SGMII && > phydev->interface != PHY_INTERFACE_MODE_2500BASEX && > - phydev->interface != PHY_INTERFACE_MODE_XGMII && > + phydev->interface != PHY_INTERFACE_MODE_USXGMII && > phydev->interface != PHY_INTERFACE_MODE_10GKR) > return -ENODEV; Hi Heiner Just to reiterate Florian's point. We need to be careful with device tree blobs. We should try not to break them, at least not for a few cycles. I would much prefer to see a WARN_ON(phydev->interface == PHY_INTERFACE_MODE_XGMII, "Your devicetree is out of date, please update it"); and accept XGMII for this cycle. These are development boards, so in theory users are developers, so should know how to update the DT. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support 2019-05-22 20:58 ` Andrew Lunn @ 2019-05-23 4:08 ` Heiner Kallweit 0 siblings, 0 replies; 10+ messages in thread From: Heiner Kallweit @ 2019-05-23 4:08 UTC (permalink / raw) To: Andrew Lunn Cc: Mark Rutland, devicetree, Florian Fainelli, Madalin-cristian Bucur, netdev, Li Yang, Rob Herring, Shawn Guo, David Miller, linux-arm-kernel On 22.05.2019 22:58, Andrew Lunn wrote: > On Wed, May 22, 2019 at 09:58:32PM +0200, Heiner Kallweit wrote: >> So far we didn't support mode USXGMII, and in order to not break the >> two Freescale boards mode XGMII was accepted for the AQR107 family >> even though it doesn't support XGMII. Add USXGMII support to the >> Aquantia PHY driver and change the phy connection type for the two >> boards. >> >> As an additional note: Even though the handle is named aqr106 >> there seem to be LS1046A boards with an AQR107. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >> --- >> arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 +- >> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 2 +- >> drivers/net/phy/aquantia_main.c | 6 +++++- >> 3 files changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts >> index 4223a2352..c2ce1a611 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts >> @@ -139,7 +139,7 @@ >> >> ethernet@f0000 { /* 10GEC1 */ >> phy-handle = <&aqr105_phy>; >> - phy-connection-type = "xgmii"; >> + phy-connection-type = "usxgmii"; >> }; >> >> mdio@fc000 { >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts >> index 6a6514d0e..f927a8a25 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts >> @@ -147,7 +147,7 @@ >> >> ethernet@f0000 { /* 10GEC1 */ >> phy-handle = <&aqr106_phy>; >> - phy-connection-type = "xgmii"; >> + phy-connection-type = "usxgmii"; >> }; >> >> ethernet@f2000 { /* 10GEC2 */ >> diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c >> index 0fedd28fd..3f24c42a8 100644 >> @@ -487,7 +491,7 @@ static int aqr107_config_init(struct phy_device *phydev) >> /* Check that the PHY interface type is compatible */ >> if (phydev->interface != PHY_INTERFACE_MODE_SGMII && >> phydev->interface != PHY_INTERFACE_MODE_2500BASEX && >> - phydev->interface != PHY_INTERFACE_MODE_XGMII && >> + phydev->interface != PHY_INTERFACE_MODE_USXGMII && >> phydev->interface != PHY_INTERFACE_MODE_10GKR) >> return -ENODEV; > > Hi Heiner > > Just to reiterate Florian's point. We need to be careful with device > tree blobs. We should try not to break them, at least not for a few > cycles. > > I would much prefer to see a > > WARN_ON(phydev->interface == PHY_INTERFACE_MODE_XGMII, > "Your devicetree is out of date, please update it"); > > and accept XGMII for this cycle. These are development boards, so in > theory users are developers, so should know how to update the DT. > I see your point. Then I'll just change phylib and will let the NXP guys change the board DTS. > Andrew > Heiner _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-05-23 4:09 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-05-22 19:56 [PATCH net-next 0/2] net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII Heiner Kallweit 2019-05-22 19:57 ` [PATCH net-next 1/2] " Heiner Kallweit 2019-05-22 20:06 ` Florian Fainelli 2019-05-22 20:20 ` Heiner Kallweit 2019-05-22 19:58 ` [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support Heiner Kallweit 2019-05-22 20:07 ` Florian Fainelli 2019-05-22 20:18 ` Heiner Kallweit 2019-05-22 20:29 ` Florian Fainelli 2019-05-22 20:58 ` Andrew Lunn 2019-05-23 4:08 ` Heiner Kallweit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).