From: <Tudor.Ambarus@microchip.com>
To: <yuehaibing@huawei.com>, <Ludovic.Desroches@microchip.com>,
<vkoul@kernel.org>, <Eugen.Hristev@microchip.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize()
Date: Tue, 6 Apr 2021 10:11:53 +0000 [thread overview]
Message-ID: <e854d48d-d15b-43f1-07ad-2d545ea94638@microchip.com> (raw)
In-Reply-To: <20210406085043.32544-1-yuehaibing@huawei.com>
On 4/6/21 11:50 AM, YueHaibing wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")
> left behind this, so can remove it.
Checkpatch complains:
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")'
but the change is good:
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/dma/at_xdmac.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index fe45ad5d06c4..64a52bf4d737 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -344,17 +344,6 @@ static inline int at_xdmac_chan_is_paused(struct at_xdmac_chan *atchan)
> return test_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
> }
>
> -static inline int at_xdmac_csize(u32 maxburst)
> -{
> - int csize;
> -
> - csize = ffs(maxburst) - 1;
> - if (csize > 4)
> - csize = -EINVAL;
> -
> - return csize;
> -};
> -
> static inline bool at_xdmac_chan_is_peripheral_xfer(u32 cfg)
> {
> return cfg & AT_XDMAC_CC_TYPE_PER_TRAN;
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-04-06 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 8:50 [PATCH -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize() YueHaibing
2021-04-06 10:11 ` Tudor.Ambarus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e854d48d-d15b-43f1-07ad-2d545ea94638@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).