* [PATCH -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize()
@ 2021-04-06 8:50 YueHaibing
2021-04-06 10:11 ` Tudor.Ambarus
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2021-04-06 8:50 UTC (permalink / raw)
To: ludovic.desroches, tudor.ambarus, vkoul, eugen.hristev
Cc: linux-arm-kernel, dmaengine, linux-kernel, YueHaibing
765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")
left behind this, so can remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/dma/at_xdmac.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index fe45ad5d06c4..64a52bf4d737 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -344,17 +344,6 @@ static inline int at_xdmac_chan_is_paused(struct at_xdmac_chan *atchan)
return test_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
}
-static inline int at_xdmac_csize(u32 maxburst)
-{
- int csize;
-
- csize = ffs(maxburst) - 1;
- if (csize > 4)
- csize = -EINVAL;
-
- return csize;
-};
-
static inline bool at_xdmac_chan_is_peripheral_xfer(u32 cfg)
{
return cfg & AT_XDMAC_CC_TYPE_PER_TRAN;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize()
2021-04-06 8:50 [PATCH -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize() YueHaibing
@ 2021-04-06 10:11 ` Tudor.Ambarus
0 siblings, 0 replies; 2+ messages in thread
From: Tudor.Ambarus @ 2021-04-06 10:11 UTC (permalink / raw)
To: yuehaibing, Ludovic.Desroches, vkoul, Eugen.Hristev
Cc: linux-arm-kernel, dmaengine, linux-kernel
On 4/6/21 11:50 AM, YueHaibing wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")
> left behind this, so can remove it.
Checkpatch complains:
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")'
but the change is good:
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/dma/at_xdmac.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index fe45ad5d06c4..64a52bf4d737 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -344,17 +344,6 @@ static inline int at_xdmac_chan_is_paused(struct at_xdmac_chan *atchan)
> return test_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
> }
>
> -static inline int at_xdmac_csize(u32 maxburst)
> -{
> - int csize;
> -
> - csize = ffs(maxburst) - 1;
> - if (csize > 4)
> - csize = -EINVAL;
> -
> - return csize;
> -};
> -
> static inline bool at_xdmac_chan_is_peripheral_xfer(u32 cfg)
> {
> return cfg & AT_XDMAC_CC_TYPE_PER_TRAN;
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-06 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 8:50 [PATCH -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize() YueHaibing
2021-04-06 10:11 ` Tudor.Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).