linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* Re: [Linux-stm32] [PATCH v2 12/13] ARM: dts: stm32: enable optee firmware and SCMI support on STM32MP13
       [not found] <CAN5uoS9F1cjN+WLks1S=GzA1SHw=o-ibFbu-VsUzJ4NydAkAdw@mail.gmail.com>
@ 2022-03-16 11:17 ` Ahmad Fatoum
  0 siblings, 0 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2022-03-16 11:17 UTC (permalink / raw)
  To: Etienne Carriere, Gabriel FERNANDEZ, Michael Turquette,
	Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Maxime Coquelin,
	Alexandre Torgue, Philipp Zabel, devicetree, linux-kernel,
	linux-clk,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-stm32, Pengutronix Kernel Team

Hello Etienne,

On 16.03.22 12:01, Etienne Carriere wrote:
> Hi Ahmad,
> 
>> Helo Gabriel,
>>
>> On 03.03.22 14:09, Gabriel FERNANDEZ wrote:
>>>
>>> On 2/25/22 16:13, Ahmad Fatoum wrote:
>>>> Hello Gabriel,
>>>>
>>>> On 25.02.22 14:31, gabriel.fernandez@foss.st.com wrote:
>>>>> From: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>>>>> +    firmware {
>>>>> +        optee {
>>>>> +            method = "smc";
>>>>> +            compatible = "linaro,optee-tz";
>>>>> +        };
>>>>> +
>>>>> +        scmi: scmi {
>>>>> +            compatible = "linaro,scmi-optee";
>>>> This compatible doesn't seem to be documented upstream. I am looking at v5.17-rc5.
>>>> Do you have a reference detailing the difference between this conduit and
>>>> plain arm,scmi-smc (as used with TF-A on the STM32MP151).
>>>>
>>>> Cheers,
>>>> Ahmad
>>>
>>> Hi
>>>
>>> Ahmad,
>>>
>>> it's on going.
>>>
>>> https://lore.kernel.org/linux-arm-kernel/20211029102118.GG6526@e120937-lin/T/#mf46c83f0aadce3061ee93fa22159405f38d881a0
>>
>> I've found that thread in the meantime and got some clarification on why a new
>> transport for OP-TEE was added. One question I still have though is why make
>> this transport the default for STM32MP13x instead of using SCMI over SMC like
>> you do for STM32MP15x. OP-TEE could still be made to service SCMI over SMC
>> and it would allow people employing TF-A as SCMI provider an easier migration
>> to the newer SoC.
>>
> 
> Just to rephrase a bit what's being said in the referred mail thread:
> On STM32MP13x, there are SCMI messages that must be processed inside a
> thread execution context in the SCMI server. There is no standard SMC
> function ID defined that the SCMI/SMC transport could use for that
> purpose. OP-TEE provides such a threaded context. Therefore STM32MP13x
> explicitly expects SCMI services based on SCMI/OP-TEE transport, not
> SCMI/SMC transport.

I see. Users can still override it as they see fit and I understand that
ST would prefer to have the "fully-featured" boot chain be the default
for the new SoC. So no concerns from my side.

Thanks a lot for the clarification!

Cheers,
Ahmad

> 
> Best regards,
> etienne
> 
>> Cheers,
>> Ahmad
> 
>>
>>>
>>>> +            #address-cells = <1>;
>>>> +            #size-cells = <0>;
>>>> +            linaro,optee-channel-id = <0>;
>>>> +            shmem = <&scmi_shm>;
>>>> +
>>>> +            scmi_clk: protocol@14 {
>>>> +                reg = <0x14>;
>>>> +                #clock-cells = <1>;
>>>> +            };
>>>> +
>>>> +            scmi_reset: protocol@16 {
>>>> +                reg = <0x16>;
>>>> +                #reset-cells = <1>;
>>>> +            };
>>>> +        };
>>>> +    };
>>>>       clocks {
>>>>           clk_axi: clk-axi {
>>>>               #clock-cells = <0>;
>>>
>>
> 
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Linux-stm32] [PATCH v2 12/13] ARM: dts: stm32: enable optee firmware and SCMI support on STM32MP13
  2022-03-03 13:09     ` Gabriel FERNANDEZ
@ 2022-03-08  9:58       ` Ahmad Fatoum
  0 siblings, 0 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2022-03-08  9:58 UTC (permalink / raw)
  To: Gabriel FERNANDEZ, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Maxime Coquelin, Alexandre Torgue,
	Philipp Zabel
  Cc: devicetree, linux-kernel, linux-clk, linux-arm-kernel,
	linux-stm32, Pengutronix Kernel Team, Etienne Carriere

Helo Gabriel,

On 03.03.22 14:09, Gabriel FERNANDEZ wrote:
> 
> On 2/25/22 16:13, Ahmad Fatoum wrote:
>> Hello Gabriel,
>>
>> On 25.02.22 14:31, gabriel.fernandez@foss.st.com wrote:
>>> From: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>>> +    firmware {
>>> +        optee {
>>> +            method = "smc";
>>> +            compatible = "linaro,optee-tz";
>>> +        };
>>> +
>>> +        scmi: scmi {
>>> +            compatible = "linaro,scmi-optee";
>> This compatible doesn't seem to be documented upstream. I am looking at v5.17-rc5.
>> Do you have a reference detailing the difference between this conduit and
>> plain arm,scmi-smc (as used with TF-A on the STM32MP151).
>>
>> Cheers,
>> Ahmad
> 
> Hi
> 
> Ahmad,
> 
> it's on going.
> 
> https://lore.kernel.org/linux-arm-kernel/20211029102118.GG6526@e120937-lin/T/#mf46c83f0aadce3061ee93fa22159405f38d881a0

I've found that thread in the meantime and got some clarification on why a new
transport for OP-TEE was added. One question I still have though is why make
this transport the default for STM32MP13x instead of using SCMI over SMC like
you do for STM32MP15x. OP-TEE could still be made to service SCMI over SMC
and it would allow people employing TF-A as SCMI provider an easier migration
to the newer SoC.

Cheers,
Ahmad

> 
>>
>>> +            #address-cells = <1>;
>>> +            #size-cells = <0>;
>>> +            linaro,optee-channel-id = <0>;
>>> +            shmem = <&scmi_shm>;
>>> +
>>> +            scmi_clk: protocol@14 {
>>> +                reg = <0x14>;
>>> +                #clock-cells = <1>;
>>> +            };
>>> +
>>> +            scmi_reset: protocol@16 {
>>> +                reg = <0x16>;
>>> +                #reset-cells = <1>;
>>> +            };
>>> +        };
>>> +    };
>>>       clocks {
>>>           clk_axi: clk-axi {
>>>               #clock-cells = <0>;
>>
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Linux-stm32] [PATCH v2 12/13] ARM: dts: stm32: enable optee firmware and SCMI support on STM32MP13
  2022-02-25 15:13   ` [Linux-stm32] " Ahmad Fatoum
@ 2022-03-03 13:09     ` Gabriel FERNANDEZ
  2022-03-08  9:58       ` Ahmad Fatoum
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel FERNANDEZ @ 2022-03-03 13:09 UTC (permalink / raw)
  To: Ahmad Fatoum, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Maxime Coquelin, Alexandre Torgue,
	Philipp Zabel
  Cc: devicetree, linux-kernel, linux-clk, linux-arm-kernel,
	linux-stm32, Pengutronix Kernel Team


On 2/25/22 16:13, Ahmad Fatoum wrote:
> Hello Gabriel,
>
> On 25.02.22 14:31, gabriel.fernandez@foss.st.com wrote:
>> From: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>>
>> Enable optee and SCMI clocks support.
>>
>> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>> ---
>>   arch/arm/boot/dts/stm32mp131.dtsi | 37 +++++++++++++++++++++++++++++++
>>   1 file changed, 37 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp131.dtsi b/arch/arm/boot/dts/stm32mp131.dtsi
>> index 262de4eeb4ed..78eac53224d4 100644
>> --- a/arch/arm/boot/dts/stm32mp131.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp131.dtsi
>> @@ -27,6 +27,43 @@ arm-pmu {
>>   		interrupt-parent = <&intc>;
>>   	};
>>   
>> +	scmi_sram: sram@2ffff000 {
>> +		compatible = "mmio-sram";
>> +		reg = <0x2ffff000 0x1000>;
>> +		#address-cells = <1>;
>> +		#size-cells = <1>;
>> +		ranges = <0 0x2ffff000 0x1000>;
>> +
>> +		scmi_shm: scmi_shm@0 {
>> +			compatible = "arm,scmi-shmem";
>> +			reg = <0 0x80>;
>> +		};
>> +	};
>> +
>> +	firmware {
>> +		optee {
>> +			method = "smc";
>> +			compatible = "linaro,optee-tz";
>> +		};
>> +
>> +		scmi: scmi {
>> +			compatible = "linaro,scmi-optee";
> This compatible doesn't seem to be documented upstream. I am looking at v5.17-rc5.
> Do you have a reference detailing the difference between this conduit and
> plain arm,scmi-smc (as used with TF-A on the STM32MP151).
>
> Cheers,
> Ahmad

Hi

Ahmad,

it's on going.

https://lore.kernel.org/linux-arm-kernel/20211029102118.GG6526@e120937-lin/T/#mf46c83f0aadce3061ee93fa22159405f38d881a0

>
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			linaro,optee-channel-id = <0>;
>> +			shmem = <&scmi_shm>;
>> +
>> +			scmi_clk: protocol@14 {
>> +				reg = <0x14>;
>> +				#clock-cells = <1>;
>> +			};
>> +
>> +			scmi_reset: protocol@16 {
>> +				reg = <0x16>;
>> +				#reset-cells = <1>;
>> +			};
>> +		};
>> +	};
>>   	clocks {
>>   		clk_axi: clk-axi {
>>   			#clock-cells = <0>;
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Linux-stm32] [PATCH v2 12/13] ARM: dts: stm32: enable optee firmware and SCMI support on STM32MP13
  2022-02-25 13:31 ` [PATCH v2 12/13] ARM: dts: stm32: enable optee firmware and SCMI support on STM32MP13 gabriel.fernandez
@ 2022-02-25 15:13   ` Ahmad Fatoum
  2022-03-03 13:09     ` Gabriel FERNANDEZ
  0 siblings, 1 reply; 4+ messages in thread
From: Ahmad Fatoum @ 2022-02-25 15:13 UTC (permalink / raw)
  To: gabriel.fernandez, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Maxime Coquelin, Alexandre Torgue,
	Philipp Zabel
  Cc: devicetree, linux-kernel, linux-clk, linux-arm-kernel,
	linux-stm32, Pengutronix Kernel Team

Hello Gabriel,

On 25.02.22 14:31, gabriel.fernandez@foss.st.com wrote:
> From: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
> 
> Enable optee and SCMI clocks support.
> 
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
> ---
>  arch/arm/boot/dts/stm32mp131.dtsi | 37 +++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stm32mp131.dtsi b/arch/arm/boot/dts/stm32mp131.dtsi
> index 262de4eeb4ed..78eac53224d4 100644
> --- a/arch/arm/boot/dts/stm32mp131.dtsi
> +++ b/arch/arm/boot/dts/stm32mp131.dtsi
> @@ -27,6 +27,43 @@ arm-pmu {
>  		interrupt-parent = <&intc>;
>  	};
>  
> +	scmi_sram: sram@2ffff000 {
> +		compatible = "mmio-sram";
> +		reg = <0x2ffff000 0x1000>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0 0x2ffff000 0x1000>;
> +
> +		scmi_shm: scmi_shm@0 {
> +			compatible = "arm,scmi-shmem";
> +			reg = <0 0x80>;
> +		};
> +	};
> +
> +	firmware {
> +		optee {
> +			method = "smc";
> +			compatible = "linaro,optee-tz";
> +		};
> +
> +		scmi: scmi {
> +			compatible = "linaro,scmi-optee";

This compatible doesn't seem to be documented upstream. I am looking at v5.17-rc5.
Do you have a reference detailing the difference between this conduit and
plain arm,scmi-smc (as used with TF-A on the STM32MP151).

Cheers,
Ahmad

> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			linaro,optee-channel-id = <0>;
> +			shmem = <&scmi_shm>;
> +
> +			scmi_clk: protocol@14 {
> +				reg = <0x14>;
> +				#clock-cells = <1>;
> +			};
> +
> +			scmi_reset: protocol@16 {
> +				reg = <0x16>;
> +				#reset-cells = <1>;
> +			};
> +		};
> +	};
>  	clocks {
>  		clk_axi: clk-axi {
>  			#clock-cells = <0>;


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-03-16 11:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAN5uoS9F1cjN+WLks1S=GzA1SHw=o-ibFbu-VsUzJ4NydAkAdw@mail.gmail.com>
2022-03-16 11:17 ` [Linux-stm32] [PATCH v2 12/13] ARM: dts: stm32: enable optee firmware and SCMI support on STM32MP13 Ahmad Fatoum
2022-02-25 13:31 [PATCH v2 00/13] Introduction of STM32MP13 RCC driver (Reset Clock Controller) gabriel.fernandez
2022-02-25 13:31 ` [PATCH v2 12/13] ARM: dts: stm32: enable optee firmware and SCMI support on STM32MP13 gabriel.fernandez
2022-02-25 15:13   ` [Linux-stm32] " Ahmad Fatoum
2022-03-03 13:09     ` Gabriel FERNANDEZ
2022-03-08  9:58       ` Ahmad Fatoum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).