* [PATCH v2] arm64: Clarify when cpu_enable() is called
@ 2019-08-08 13:53 Mark Brown
2019-08-08 13:57 ` Suzuki K Poulose
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2019-08-08 13:53 UTC (permalink / raw)
To: Suzuki K Poulose, will, catalin.marinas; +Cc: Mark Brown, linux-arm-kernel
Strengthen the wording in the documentation for cpu_enable() to make it
more obvious to readers not already familiar with the code when the core
will call this callback and that this is intentional.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
v2: Much more verbose wording from Suzuki.
arch/arm64/include/asm/cpufeature.h | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h
index cf65a47ee6b4..2447d4afbf54 100644
--- a/arch/arm64/include/asm/cpufeature.h
+++ b/arch/arm64/include/asm/cpufeature.h
@@ -289,9 +289,17 @@ struct arm64_cpu_capabilities {
u16 type;
bool (*matches)(const struct arm64_cpu_capabilities *caps, int scope);
/*
- * Take the appropriate actions to enable this capability for this CPU.
- * For each successfully booted CPU, this method is called for each
- * globally detected capability.
+ * Take the appropriate actions to configure this capability
+ * for this CPU. If the capability is detected by the kernel
+ * this will be called on all the CPUs in the system,
+ * including the hotplugged CPUs, regardless of if the
+ * capability was *available* on that specific CPU. This is
+ * useful for some capabilities (e.g, working around CPU
+ * errata), where all the CPUs must take some action (e.g,
+ * changing system control/configuration). Thus, if an action
+ * is required only if the CPU has the capability then the
+ * routine must check it before taking any action.
+
*/
void (*cpu_enable)(const struct arm64_cpu_capabilities *cap);
union {
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm64: Clarify when cpu_enable() is called
2019-08-08 13:53 [PATCH v2] arm64: Clarify when cpu_enable() is called Mark Brown
@ 2019-08-08 13:57 ` Suzuki K Poulose
0 siblings, 0 replies; 2+ messages in thread
From: Suzuki K Poulose @ 2019-08-08 13:57 UTC (permalink / raw)
To: broonie, will, catalin.marinas; +Cc: linux-arm-kernel
On 08/08/2019 14:53, Mark Brown wrote:
> Strengthen the wording in the documentation for cpu_enable() to make it
> more obvious to readers not already familiar with the code when the core
> will call this callback and that this is intentional.
>
Looks good to me, except for some minor space related issues below.
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>
> v2: Much more verbose wording from Suzuki.
>
> arch/arm64/include/asm/cpufeature.h | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h
> index cf65a47ee6b4..2447d4afbf54 100644
> --- a/arch/arm64/include/asm/cpufeature.h
> +++ b/arch/arm64/include/asm/cpufeature.h
> @@ -289,9 +289,17 @@ struct arm64_cpu_capabilities {
> u16 type;
> bool (*matches)(const struct arm64_cpu_capabilities *caps, int scope);
> /*
> - * Take the appropriate actions to enable this capability for this CPU.
> - * For each successfully booted CPU, this method is called for each
> - * globally detected capability.
> + * Take the appropriate actions to configure this capability
> + * for this CPU. If the capability is detected by the kernel
minor nit: double space ^^
> + * this will be called on all the CPUs in the system,
> + * including the hotplugged CPUs, regardless of if the
> + * capability was *available* on that specific CPU. This is
> + * useful for some capabilities (e.g, working around CPU
> + * errata), where all the CPUs must take some action (e.g,
> + * changing system control/configuration). Thus, if an action
and here before "Thus".
> + * is required only if the CPU has the capability then the
> + * routine must check it before taking any action.
> +
spurious new line ?
> */
> void (*cpu_enable)(const struct arm64_cpu_capabilities *cap);
> union {
>
With the above addressed,
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-08 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08 13:53 [PATCH v2] arm64: Clarify when cpu_enable() is called Mark Brown
2019-08-08 13:57 ` Suzuki K Poulose
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).