* [PATCH] arm64: armv8_deprecated: Checking return value for memory allocation
@ 2019-09-29 4:44 Yunfeng Ye
2019-09-30 13:22 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Yunfeng Ye @ 2019-09-29 4:44 UTC (permalink / raw)
To: catalin.marinas, will.deacon, kstewart, gregkh, tglx, info
Cc: linux-kernel, linux-arm-kernel
There are no return value checking when using kzalloc() and kcalloc() for
memory allocation. so add it.
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
---
arch/arm64/kernel/armv8_deprecated.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
index 2ec09de..ca158be 100644
--- a/arch/arm64/kernel/armv8_deprecated.c
+++ b/arch/arm64/kernel/armv8_deprecated.c
@@ -174,6 +174,9 @@ static void __init register_insn_emulation(struct insn_emulation_ops *ops)
struct insn_emulation *insn;
insn = kzalloc(sizeof(*insn), GFP_KERNEL);
+ if (!insn)
+ return;
+
insn->ops = ops;
insn->min = INSN_UNDEF;
@@ -233,6 +236,8 @@ static void __init register_insn_emulation_sysctl(void)
insns_sysctl = kcalloc(nr_insn_emulated + 1, sizeof(*sysctl),
GFP_KERNEL);
+ if (!insns_sysctl)
+ return;
raw_spin_lock_irqsave(&insn_emulation_lock, flags);
list_for_each_entry(insn, &insn_emulation, node) {
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: armv8_deprecated: Checking return value for memory allocation
2019-09-29 4:44 [PATCH] arm64: armv8_deprecated: Checking return value for memory allocation Yunfeng Ye
@ 2019-09-30 13:22 ` Will Deacon
2019-10-07 6:06 ` Yunfeng Ye
0 siblings, 1 reply; 3+ messages in thread
From: Will Deacon @ 2019-09-30 13:22 UTC (permalink / raw)
To: Yunfeng Ye
Cc: kstewart, catalin.marinas, will.deacon, linux-kernel, gregkh,
tglx, info, linux-arm-kernel
On Sun, Sep 29, 2019 at 12:44:17PM +0800, Yunfeng Ye wrote:
> There are no return value checking when using kzalloc() and kcalloc() for
> memory allocation. so add it.
>
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> ---
> arch/arm64/kernel/armv8_deprecated.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> index 2ec09de..ca158be 100644
> --- a/arch/arm64/kernel/armv8_deprecated.c
> +++ b/arch/arm64/kernel/armv8_deprecated.c
> @@ -174,6 +174,9 @@ static void __init register_insn_emulation(struct insn_emulation_ops *ops)
> struct insn_emulation *insn;
>
> insn = kzalloc(sizeof(*insn), GFP_KERNEL);
> + if (!insn)
> + return;
> +
> insn->ops = ops;
> insn->min = INSN_UNDEF;
>
> @@ -233,6 +236,8 @@ static void __init register_insn_emulation_sysctl(void)
>
> insns_sysctl = kcalloc(nr_insn_emulated + 1, sizeof(*sysctl),
> GFP_KERNEL);
> + if (!insns_sysctl)
> + return;
Since both of these failure paths are fatal to the instruction emulation,
can you please return an error code when the allocation fails and use that
to fail the calling initcall() appropriately?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: armv8_deprecated: Checking return value for memory allocation
2019-09-30 13:22 ` Will Deacon
@ 2019-10-07 6:06 ` Yunfeng Ye
0 siblings, 0 replies; 3+ messages in thread
From: Yunfeng Ye @ 2019-10-07 6:06 UTC (permalink / raw)
To: Will Deacon
Cc: kstewart, catalin.marinas, will.deacon, linux-kernel, gregkh,
tglx, info, linux-arm-kernel
On 2019/9/30 21:22, Will Deacon wrote:
> On Sun, Sep 29, 2019 at 12:44:17PM +0800, Yunfeng Ye wrote:
>> There are no return value checking when using kzalloc() and kcalloc() for
>> memory allocation. so add it.
>>
>> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
>> ---
>> arch/arm64/kernel/armv8_deprecated.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
>> index 2ec09de..ca158be 100644
>> --- a/arch/arm64/kernel/armv8_deprecated.c
>> +++ b/arch/arm64/kernel/armv8_deprecated.c
>> @@ -174,6 +174,9 @@ static void __init register_insn_emulation(struct insn_emulation_ops *ops)
>> struct insn_emulation *insn;
>>
>> insn = kzalloc(sizeof(*insn), GFP_KERNEL);
>> + if (!insn)
>> + return;
>> +
>> insn->ops = ops;
>> insn->min = INSN_UNDEF;
>>
>> @@ -233,6 +236,8 @@ static void __init register_insn_emulation_sysctl(void)
>>
>> insns_sysctl = kcalloc(nr_insn_emulated + 1, sizeof(*sysctl),
>> GFP_KERNEL);
>> + if (!insns_sysctl)
>> + return;
>
> Since both of these failure paths are fatal to the instruction emulation,
> can you please return an error code when the allocation fails and use that
> to fail the calling initcall() appropriately?
>
ok, I will modify as your suggest, thanks.
> Will
>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-07 6:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-29 4:44 [PATCH] arm64: armv8_deprecated: Checking return value for memory allocation Yunfeng Ye
2019-09-30 13:22 ` Will Deacon
2019-10-07 6:06 ` Yunfeng Ye
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).