From: Leonard Crestez <leonard.crestez@nxp.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Angus Ainslie <angus@akkea.ca>, Rob Herring <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Robin Gong <yibin.gong@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 1/3] mfd: bd718x7: Remove hardcoded config for button press duration
Date: Mon, 20 May 2019 08:55:56 +0000 [thread overview]
Message-ID: <ed27e04ba7486cce7860197bc8c76bcedafde398.1558341613.git.leonard.crestez@nxp.com> (raw)
In-Reply-To: <cover.1558341613.git.leonard.crestez@nxp.com>
The reset button on imx8mm-evk is tied to PWRON_B pin of bd71847 and the
long press duration is set to zero from OTP. The linux driver overrides
those values and breaks reset from button.
Overwriting OTP or bootloader configuration with some hardcoded defaults
is not desirable, keep already programmed values instead.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
drivers/mfd/rohm-bd718x7.c | 23 -----------------------
1 file changed, 23 deletions(-)
diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
index a29d529a96f4..cdbef83884f0 100644
--- a/drivers/mfd/rohm-bd718x7.c
+++ b/drivers/mfd/rohm-bd718x7.c
@@ -115,33 +115,10 @@ static int bd718xx_i2c_probe(struct i2c_client *i2c,
if (ret) {
dev_err(&i2c->dev, "Failed to add irq_chip\n");
return ret;
}
- /* Configure short press to 10 milliseconds */
- ret = regmap_update_bits(bd718xx->regmap,
- BD718XX_REG_PWRONCONFIG0,
- BD718XX_PWRBTN_PRESS_DURATION_MASK,
- BD718XX_PWRBTN_SHORT_PRESS_10MS);
- if (ret) {
- dev_err(&i2c->dev,
- "Failed to configure button short press timeout\n");
- return ret;
- }
-
- /* Configure long press to 10 seconds */
- ret = regmap_update_bits(bd718xx->regmap,
- BD718XX_REG_PWRONCONFIG1,
- BD718XX_PWRBTN_PRESS_DURATION_MASK,
- BD718XX_PWRBTN_LONG_PRESS_10S);
-
- if (ret) {
- dev_err(&i2c->dev,
- "Failed to configure button long press timeout\n");
- return ret;
- }
-
ret = regmap_irq_get_virq(bd718xx->irq_data, BD718XX_INT_PWRBTN_S);
if (ret < 0) {
dev_err(&i2c->dev, "Failed to get the IRQ\n");
return ret;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-20 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 8:55 [PATCH 0/3] mfd: bd718x7: Set button press duration via dt only Leonard Crestez
2019-05-20 8:55 ` Leonard Crestez [this message]
2019-05-20 9:11 ` [PATCH 1/3] mfd: bd718x7: Remove hardcoded config for button press duration Vaittinen, Matti
2019-05-20 8:55 ` [PATCH 2/3] dt-bindings: mfd: Document short/long press duration for bd718x7 Leonard Crestez
2019-05-20 9:15 ` Vaittinen, Matti
2019-05-20 8:55 ` [PATCH 3/3] mfd: bd718x7: Make power button press duration configurable Leonard Crestez
2019-05-20 9:23 ` Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed27e04ba7486cce7860197bc8c76bcedafde398.1558341613.git.leonard.crestez@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=angus@akkea.ca \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).