* [PATCH] drivers/bus/brcmstb_gisb.c : Remove the suppress_bind_attrs attribute of the driver
@ 2022-03-20 6:45 lizhe
2022-03-22 14:52 ` Andy Shevchenko
2022-04-19 18:49 ` Florian Fainelli
0 siblings, 2 replies; 5+ messages in thread
From: lizhe @ 2022-03-20 6:45 UTC (permalink / raw)
To: f.fainelli, bcm-kernel-feedback-list, linux-arm-kernel, sensor1010
Cc: linux-kernel
Even if platform_driver does not set suppress_bind_attrs attribute,
when registering with platform_driver_probe, the value of
suppress_bind_attrs is still true, see __platform_driver_probe()
Signed-off-by: lizhe <sensor1010@163.com>
---
drivers/bus/brcmstb_gisb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c
index 183d5cc37d42..b0c3704777e9 100644
--- a/drivers/bus/brcmstb_gisb.c
+++ b/drivers/bus/brcmstb_gisb.c
@@ -536,7 +536,6 @@ static struct platform_driver brcmstb_gisb_arb_driver = {
.name = "brcm-gisb-arb",
.of_match_table = brcmstb_gisb_arb_of_match,
.pm = &brcmstb_gisb_arb_pm_ops,
- .suppress_bind_attrs = true,
},
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/bus/brcmstb_gisb.c : Remove the suppress_bind_attrs attribute of the driver
2022-03-20 6:45 [PATCH] drivers/bus/brcmstb_gisb.c : Remove the suppress_bind_attrs attribute of the driver lizhe
@ 2022-03-22 14:52 ` Andy Shevchenko
2022-03-22 14:56 ` Andy Shevchenko
2022-04-19 18:49 ` Florian Fainelli
1 sibling, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2022-03-22 14:52 UTC (permalink / raw)
To: lizhe
Cc: Florian Fainelli, bcm-kernel-feedback-list,
linux-arm Mailing List, Linux Kernel Mailing List
On Tue, Mar 22, 2022 at 12:41 AM lizhe <sensor1010@163.com> wrote:
>
> Even if platform_driver does not set suppress_bind_attrs attribute,
> when registering with platform_driver_probe, the value of
> suppress_bind_attrs is still true, see __platform_driver_probe()
Any reasons it can't be switched to builtin_platform_driver() macro
and hence constification the driver structure?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/bus/brcmstb_gisb.c : Remove the suppress_bind_attrs attribute of the driver
2022-03-22 14:52 ` Andy Shevchenko
@ 2022-03-22 14:56 ` Andy Shevchenko
[not found] ` <531e91bf.3734.17fb4e3150e.Coremail.sensor1010@163.com>
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2022-03-22 14:56 UTC (permalink / raw)
To: lizhe
Cc: Florian Fainelli, bcm-kernel-feedback-list,
linux-arm Mailing List, Linux Kernel Mailing List
On Tue, Mar 22, 2022 at 4:52 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Tue, Mar 22, 2022 at 12:41 AM lizhe <sensor1010@163.com> wrote:
> >
> > Even if platform_driver does not set suppress_bind_attrs attribute,
> > when registering with platform_driver_probe, the value of
> > suppress_bind_attrs is still true, see __platform_driver_probe()
>
> Any reasons it can't be switched to builtin_platform_driver() macro
> and hence constification of the driver structure?
Ah, the patch that brought that assignment actually allows to built
the driver as a module, so, the correct patch would be to switch to
module_platform_driver() I suppose.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/bus/brcmstb_gisb.c : Remove the suppress_bind_attrs attribute of the driver
[not found] ` <531e91bf.3734.17fb4e3150e.Coremail.sensor1010@163.com>
@ 2022-03-23 3:52 ` Florian Fainelli
0 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2022-03-23 3:52 UTC (permalink / raw)
To: lizhe, Andy Shevchenko
Cc: bcm-kernel-feedback-list, linux-arm Mailing List,
Linux Kernel Mailing List
On 3/22/2022 8:47 PM, lizhe wrote:
> HI Andy Shevchenko
> Even if it is loaded as a module, its execution flow is still executed
> through do_one_initcall(),
> __platform_driver_probe() still invoked.
> So, this suppress_bind_attrs = true is redundant
>
> https://github.com/torvalds/linux/commit/707a4cdf86e5d6a2c4fad51fb98a6ff3425f820e
> <https://github.com/torvalds/linux/commit/707a4cdf86e5d6a2c4fad51fb98a6ff3425f820e>
>
>
> The author has simply added some descriptions here. Nothing
> substantial has changed.
No HTML please, and yes I have seen your patch, and yes I plan on
applying it. No need to fuss about it however.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/bus/brcmstb_gisb.c : Remove the suppress_bind_attrs attribute of the driver
2022-03-20 6:45 [PATCH] drivers/bus/brcmstb_gisb.c : Remove the suppress_bind_attrs attribute of the driver lizhe
2022-03-22 14:52 ` Andy Shevchenko
@ 2022-04-19 18:49 ` Florian Fainelli
1 sibling, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2022-04-19 18:49 UTC (permalink / raw)
To: lizhe, f.fainelli, bcm-kernel-feedback-list, linux-arm-kernel
Cc: linux-kernel
On 3/19/2022 11:45 PM, lizhe wrote:
> Even if platform_driver does not set suppress_bind_attrs attribute,
> when registering with platform_driver_probe, the value of
> suppress_bind_attrs is still true, see __platform_driver_probe()
>
> Signed-off-by: lizhe <sensor1010@163.com>
Applied with a revised subject, thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-19 18:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-20 6:45 [PATCH] drivers/bus/brcmstb_gisb.c : Remove the suppress_bind_attrs attribute of the driver lizhe
2022-03-22 14:52 ` Andy Shevchenko
2022-03-22 14:56 ` Andy Shevchenko
[not found] ` <531e91bf.3734.17fb4e3150e.Coremail.sensor1010@163.com>
2022-03-23 3:52 ` Florian Fainelli
2022-04-19 18:49 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).