* [PATCH] arm64: dts: rockchip: Add some pins for NanoPi4
@ 2022-03-15 13:52 Robin Murphy
2022-03-15 18:43 ` Heiko Stübner
0 siblings, 1 reply; 3+ messages in thread
From: Robin Murphy @ 2022-03-15 13:52 UTC (permalink / raw)
To: heiko; +Cc: linux-rockchip, linux-arm-kernel
The NanoPi4 boards have the RK808's always-on 32KHz clock wired to the
SoC, so have it claim the relevant pinctrl to actually enable the
CLK32K_IN input. The RK808's SLEEP pin is also wired to the SoC's
AP_PWROFF output, so we may as well claim that too.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
index 8c0ff6c96e03..cbb12cfd40be 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
@@ -267,7 +267,7 @@ rk808: pmic@1b {
interrupt-parent = <&gpio1>;
interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
pinctrl-names = "default";
- pinctrl-0 = <&pmic_int_l>;
+ pinctrl-0 = <&pmic_int_l>, <&ap_pwroff>, <&xin32k>;
rockchip,system-power-controller;
wakeup-source;
--
2.28.0.dirty
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Add some pins for NanoPi4
2022-03-15 13:52 [PATCH] arm64: dts: rockchip: Add some pins for NanoPi4 Robin Murphy
@ 2022-03-15 18:43 ` Heiko Stübner
2022-03-15 18:53 ` Robin Murphy
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stübner @ 2022-03-15 18:43 UTC (permalink / raw)
To: Robin Murphy; +Cc: linux-rockchip, linux-arm-kernel
Am Dienstag, 15. März 2022, 14:52:59 CET schrieb Robin Murphy:
> The NanoPi4 boards have the RK808's always-on 32KHz clock wired to the
> SoC, so have it claim the relevant pinctrl to actually enable the
> CLK32K_IN input. The RK808's SLEEP pin is also wired to the SoC's
> AP_PWROFF output, so we may as well claim that too.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
> index 8c0ff6c96e03..cbb12cfd40be 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
> @@ -267,7 +267,7 @@ rk808: pmic@1b {
> interrupt-parent = <&gpio1>;
> interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
> pinctrl-names = "default";
> - pinctrl-0 = <&pmic_int_l>;
> + pinctrl-0 = <&pmic_int_l>, <&ap_pwroff>, <&xin32k>;
hmm that xin32k isn't present. Is this missing some previous patch?
> rockchip,system-power-controller;
> wakeup-source;
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Add some pins for NanoPi4
2022-03-15 18:43 ` Heiko Stübner
@ 2022-03-15 18:53 ` Robin Murphy
0 siblings, 0 replies; 3+ messages in thread
From: Robin Murphy @ 2022-03-15 18:53 UTC (permalink / raw)
To: Heiko Stübner; +Cc: linux-rockchip, linux-arm-kernel
On 2022-03-15 18:43, Heiko Stübner wrote:
> Am Dienstag, 15. März 2022, 14:52:59 CET schrieb Robin Murphy:
>> The NanoPi4 boards have the RK808's always-on 32KHz clock wired to the
>> SoC, so have it claim the relevant pinctrl to actually enable the
>> CLK32K_IN input. The RK808's SLEEP pin is also wired to the SoC's
>> AP_PWROFF output, so we may as well claim that too.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
>> index 8c0ff6c96e03..cbb12cfd40be 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
>> @@ -267,7 +267,7 @@ rk808: pmic@1b {
>> interrupt-parent = <&gpio1>;
>> interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
>> pinctrl-names = "default";
>> - pinctrl-0 = <&pmic_int_l>;
>> + pinctrl-0 = <&pmic_int_l>, <&ap_pwroff>, <&xin32k>;
>
> hmm that xin32k isn't present. Is this missing some previous patch?
Err... no, that should of course be &clk_32k :(
That's what happens when I leave ~24 hours between hacking about with
the board then typing up a proper patch from memory on a different
machine, then "git send-email @~1" without even build-testing because
it's so simple it can't possibly go wrong, right?
*Sigh* sorry for the noise, let me spin up a v2 and properly test it
this time...
Robin.
>
>> rockchip,system-power-controller;
>> wakeup-source;
>>
>>
>
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-15 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-15 13:52 [PATCH] arm64: dts: rockchip: Add some pins for NanoPi4 Robin Murphy
2022-03-15 18:43 ` Heiko Stübner
2022-03-15 18:53 ` Robin Murphy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).