From: Stefan Wahren <stefan.wahren@i2se.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org, f.fainelli@gmail.com,
phil@raspberrypi.com, Tim Gover <tim.gover@raspberrypi.com>,
sbranden@broadcom.com, alcooperx <alcooperx@gmail.com>
Cc: adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency
Date: Fri, 26 Mar 2021 17:42:42 +0100 [thread overview]
Message-ID: <f12a61ad-84f3-ad90-5553-02fc0d1926d5@i2se.com> (raw)
In-Reply-To: <c7c8e20d3d11c7d6cd203797c5faffa8a4d202a6.camel@suse.de>
Am 26.03.21 um 17:17 schrieb Nicolas Saenz Julienne:
> On Thu, 2021-03-25 at 20:11 +0100, Stefan Wahren wrote:
>> Am 24.03.21 um 16:34 schrieb Nicolas Saenz Julienne:
>>> Hi Stefan,
>>>
>>> On Wed, 2021-03-24 at 16:16 +0100, Stefan Wahren wrote:
>>>> Hi Nicolas,
>>>>
>>>> Am 22.03.21 um 19:58 schrieb Nicolas Saenz Julienne:
>>>>> From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>>>>>
>>>>> Force emmc2's frequency to 150MHz as the default 100MHz (set by FW)
>>>>> seems to interfere with the VPU clock when setup at frequencies bigger
>>>>> than 500MHz (a pretty common case). This ends up causing unwarranted
>>>>> SDHCI CMD hangs when no SD card is present.
>>>>>
>>>>> Signed-off-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
>>>>> ---
>>>>> arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 ++++++
>>>>> 1 file changed, 6 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
>>>>> index 3b4ab947492a..9aa8408d9960 100644
>>>>> --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
>>>>> +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
>>>>> @@ -257,6 +257,12 @@ &emmc2 {
>>>>> vqmmc-supply = <&sd_io_1v8_reg>;
>>>>> vmmc-supply = <&sd_vcc_reg>;
>>>>> broken-cd;
>>>>> + /*
>>>>> + * Force the frequency to 150MHz as the default 100MHz seems to
>>>>> + * interfere with the VPU clock when setup at frequencies bigger than
>>>>> + * 500MHz, causing unwarranted CMD hangs.
>>>>> + */
>>>>> + clock-frequency = <150000000>;
>>>> i don't want to bike-shed here, but is there any chance to solve this in
>>>> clk-bcm2835 in a less hacky way?
>>> What do you have in mind?
>> Sorry, nothing specific.
>>> All I can think of is adding some kind of heuristic to the clock's prepare()
>>> callback. That said, I don't feel it would be a better solution than this.
>> Based on my limited knowledge and an old SD card specification, all
>> possibly connected devices could have different frequencies. So my
>> concern here is, that in case we limit the frequency to a specific value
>> we could break things just to suppress a warning.
> SDHCI should be able to handle up to 233MHz IIRC, and there are divisors
> available, it depends on the implementation but the worst kind provide /2^n.
> Not perfect, but good enough for things to work.
>
> Now, I've been having a deeper look into how clocks are handled, and found two
> new clues:
>
> - First of all RPi4's sdhci-iproc needs SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN,
> that is, the controller isn't properly identifying the clock frequency fed
> into it, and defaults to saying it's configured at 100MHz. I'm not an SDHCI
> expert, so it's possible changing frequencies also needs a special operation
> to recalculate this variable. But this was making all internal calculations
> wrong when paired with this series.
>
> - With this flag set SDHCI's core now properly calculates divisor values based
> on whatever clock frequency I set in DT. And guess what, the issue reappears
> even when running on 150MHz. It turns out, as I had some debugging enabled,
> the issue only happens when the controller is configured at 100KHz (that
> only happens while running the card detect thread).
>
> So, I can now do this (note that for card detection try to communicate with the
> card starting at 400KHz down to 100KHz in 100KHz steps):
>
> ----->8-----
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 536c382e2486..e5a5de63f347 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -173,6 +173,11 @@ static unsigned int sdhci_iproc_get_max_clock(struct sdhci_host *host)
> return pltfm_host->clock;
> }
>
> +static unsigned int sdhci_iproc_bcm2711_get_min_clock(struct sdhci_host *host)
> +{
> + return 200000;
> +}
> +
> static const struct sdhci_ops sdhci_iproc_ops = {
> .set_clock = sdhci_set_clock,
> .get_max_clock = sdhci_iproc_get_max_clock,
> @@ -271,13 +276,15 @@ static const struct sdhci_ops sdhci_iproc_bcm2711_ops = {
> .set_clock = sdhci_set_clock,
> .set_power = sdhci_set_power_and_bus_voltage,
> .get_max_clock = sdhci_iproc_get_max_clock,
> + .get_min_clock = sdhci_iproc_bcm2711_get_min_clock,
> .set_bus_width = sdhci_set_bus_width,
> .reset = sdhci_reset,
> .set_uhs_signaling = sdhci_set_uhs_signaling,
> };
>
> ----->8-----
>
> Which is rather nicer than what this series introduces. But I can't still
> explain why configuring the controller at 100KHz is causing the hangs (while
> having the core clock setup at 500MHz), and I'm not sure if excluding 100KHz
> from the polling frequency list is going to break support for older SD cards.
Thanks for your investigations. Yes, this looks much cleaner to me.
>
> Regards,
> Nicolas
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-26 16:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 18:58 [PATCH 0/4] BCM2711's sdhci-iproc CMD timeouts Nicolas Saenz Julienne
2021-03-22 18:58 ` [PATCH 1/4] dt-bindings: mmc: iproc-sdhci: Convert to json-schema Nicolas Saenz Julienne
2021-03-22 19:11 ` Scott Branden
2021-03-22 19:16 ` Nicolas Saenz Julienne
2021-03-23 21:08 ` Rob Herring
2021-03-23 21:24 ` Nicolas Saenz Julienne
2021-03-24 16:27 ` Scott Branden
2021-03-24 16:35 ` Nicolas Saenz Julienne
2021-03-24 16:43 ` Scott Branden
2021-03-23 20:16 ` Rob Herring
2021-03-22 18:58 ` [PATCH 2/4] dt-bindings: mmc: iproc-sdhci: Add clock-frequency support Nicolas Saenz Julienne
2021-03-27 17:14 ` Rob Herring
2021-03-22 18:58 ` [PATCH 3/4] mmc: sdhci-iproc: Set clock frequency as per DT Nicolas Saenz Julienne
2021-03-22 18:58 ` [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency Nicolas Saenz Julienne
2021-03-22 19:06 ` Scott Branden
2021-03-22 19:17 ` Nicolas Saenz Julienne
2021-03-24 15:16 ` Stefan Wahren
2021-03-24 15:34 ` Nicolas Saenz Julienne
2021-03-25 19:11 ` Stefan Wahren
2021-03-26 16:17 ` Nicolas Saenz Julienne
2021-03-26 16:42 ` Stefan Wahren [this message]
2021-04-01 15:23 ` Alan Cooper
2021-04-05 8:45 ` Nicolas Saenz Julienne
2021-04-07 20:37 ` Alan Cooper
2021-04-09 9:28 ` Nicolas Saenz Julienne
2021-04-09 10:54 ` Nicolas Saenz Julienne
2021-04-09 18:28 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f12a61ad-84f3-ad90-5553-02fc0d1926d5@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=adrian.hunter@intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenz@kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=tim.gover@raspberrypi.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).