[PATCH] kvm: arm64: Fix comment for KVM_PHYS_SHIFT

[PATCH] kvm: arm64: Fix comment for KVM_PHYS_SHIFT

[Zenghui Yu]

Since Suzuki K Poulose's work on Dynamic IPA support, KVM_PHYS_SHIFT will
be used only when machine_type's bits[7:0] equal to 0 (by default). Thus
the outdated comment should be fixed.

Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
 arch/arm64/include/asm/kvm_mmu.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h
index 8af4b1b..a12bf48 100644
--- a/arch/arm64/include/asm/kvm_mmu.h
+++ b/arch/arm64/include/asm/kvm_mmu.h
@@ -138,7 +138,8 @@ static inline unsigned long __kern_hyp_va(unsigned long v)
 	})
 
 /*
- * We currently only support a 40bit IPA.
+ * We currently support using a VM-specified IPA size. For backward
+ * compatibility, the default IPA size is fixed to 40bits.
  */
 #define KVM_PHYS_SHIFT	(40)
 
-- 
1.8.3.1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] kvm: arm64: Fix comment for KVM_PHYS_SHIFT

[Suzuki K Poulose]

Hi

On 14/02/2019 01:45, Zenghui Yu wrote:
> Since Suzuki K Poulose's work on Dynamic IPA support, KVM_PHYS_SHIFT will
> be used only when machine_type's bits[7:0] equal to 0 (by default). Thus
> the outdated comment should be fixed.
> 
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
>   arch/arm64/include/asm/kvm_mmu.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h
> index 8af4b1b..a12bf48 100644
> --- a/arch/arm64/include/asm/kvm_mmu.h
> +++ b/arch/arm64/include/asm/kvm_mmu.h
> @@ -138,7 +138,8 @@ static inline unsigned long __kern_hyp_va(unsigned long v)
>   	})
>   
>   /*
> - * We currently only support a 40bit IPA.
> + * We currently support using a VM-specified IPA size. For backward
> + * compatibility, the default IPA size is fixed to 40bits.
>    */
>   #define KVM_PHYS_SHIFT	(40)

Thanks for the fix.

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] kvm: arm64: Fix comment for KVM_PHYS_SHIFT

[Marc Zyngier]

On Thu, 14 Feb 2019 10:11:38 +0000
Suzuki K Poulose <suzuki.poulose@arm.com> wrote:

> Hi
> 
> On 14/02/2019 01:45, Zenghui Yu wrote:
> > Since Suzuki K Poulose's work on Dynamic IPA support, KVM_PHYS_SHIFT will
> > be used only when machine_type's bits[7:0] equal to 0 (by default). Thus
> > the outdated comment should be fixed.  
> > > Cc: Suzuki K Poulose <suzuki.poulose@arm.com>  
> > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> > ---
> >   arch/arm64/include/asm/kvm_mmu.h | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)  
> > > diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h  
> > index 8af4b1b..a12bf48 100644
> > --- a/arch/arm64/include/asm/kvm_mmu.h
> > +++ b/arch/arm64/include/asm/kvm_mmu.h
> > @@ -138,7 +138,8 @@ static inline unsigned long __kern_hyp_va(unsigned long v)
> >   	})  
> >   >   /*  
> > - * We currently only support a 40bit IPA.
> > + * We currently support using a VM-specified IPA size. For backward
> > + * compatibility, the default IPA size is fixed to 40bits.
> >    */
> >   #define KVM_PHYS_SHIFT	(40)  
> 
> Thanks for the fix.
> 
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Applied, thanks.

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel