From: Hugues FRUCHET <hugues.fruchet@st.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Yannick FERTRE <yannick.fertre@st.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Mickael GUENE <mickael.guene@st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Philippe CORNU <philippe.cornu@st.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v6 2/4] media: stm32-dcmi: trace the supported fourcc/mbus_code
Date: Mon, 19 Aug 2019 07:23:17 +0000 [thread overview]
Message-ID: <fb02573f-991a-18c5-b780-b5fc100da6a8@st.com> (raw)
In-Reply-To: <20190816081514.GU6133@paasikivi.fi.intel.com>
Hi Sakari,
On 8/16/19 10:15 AM, Sakari Ailus wrote:
> Hi Hugues,
>
> On Wed, Aug 14, 2019 at 03:48:51PM +0200, Hugues Fruchet wrote:
>> Add a trace of the set of supported fourcc/mbus_code which
>> intersect between DCMI and source sub-device.
>>
>> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
>> ---
>> drivers/media/platform/stm32/stm32-dcmi.c | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
>> index b462f71..18acecf 100644
>> --- a/drivers/media/platform/stm32/stm32-dcmi.c
>> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
>> @@ -1447,12 +1447,20 @@ static int dcmi_formats_init(struct stm32_dcmi *dcmi)
>> /* Code supported, have we got this fourcc yet? */
>> for (j = 0; j < num_fmts; j++)
>> if (sd_fmts[j]->fourcc ==
>> - dcmi_formats[i].fourcc)
>> + dcmi_formats[i].fourcc) {
>> /* Already available */
>> + dev_dbg(dcmi->dev, "Skipping fourcc/code: %4.4s/0x%x\n",
>> + (char *)&sd_fmts[j]->fourcc,
>> + mbus_code.code);
>> break;
>> - if (j == num_fmts)
>> + }
>> + if (j == num_fmts) {
>> /* New */
>> sd_fmts[num_fmts++] = dcmi_formats + i;
>> + dev_dbg(dcmi->dev, "Supported fourcc/code: %4.4s/0x%x\n",
>
> Over 80 characters per line.
>
This an exception of the "80 chars" in order to be able to grep in
kernel messages:
https://www.kernel.org/doc/html/v4.10/process/coding-style.html
"However, never break user-visible strings such as printk messages,
because that breaks the ability to grep for them."
This exception is managed in checkpatch.pl (--strict).
>> + (char *)&sd_fmts[num_fmts - 1]->fourcc,
>> + sd_fmts[num_fmts - 1]->mbus_code);
>> + }
>> }
>> mbus_code.index++;
>> }
>
BR,
Hugues.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-19 7:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 13:48 [PATCH v6 0/4] DCMI bridge support Hugues Fruchet
2019-08-14 13:48 ` [PATCH v6 1/4] media: stm32-dcmi: improve sensor subdev naming Hugues Fruchet
2019-08-14 13:48 ` [PATCH v6 2/4] media: stm32-dcmi: trace the supported fourcc/mbus_code Hugues Fruchet
2019-08-16 8:15 ` Sakari Ailus
2019-08-19 7:23 ` Hugues FRUCHET [this message]
2019-08-19 7:26 ` Sakari Ailus
2019-08-19 7:40 ` Hugues FRUCHET
2019-08-19 8:10 ` Sakari Ailus
2019-08-14 13:48 ` [PATCH v6 3/4] media: stm32-dcmi: add media controller support Hugues Fruchet
2019-08-14 13:48 ` [PATCH v6 4/4] media: stm32-dcmi: add support of several sub-devices Hugues Fruchet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb02573f-991a-18c5-b780-b5fc100da6a8@st.com \
--to=hugues.fruchet@st.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mchehab@kernel.org \
--cc=mickael.guene@st.com \
--cc=philippe.cornu@st.com \
--cc=sakari.ailus@linux.intel.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).