* [PATCH] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188
@ 2022-09-23 1:42 liangxu.xu
2022-09-23 11:16 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: liangxu.xu @ 2022-09-23 1:42 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, jitao.shi
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
liangxu xu
From: liangxu xu <liangxu.xu@mediatek.com>
Add dt-binding documentation of dpi for MediaTek MT8188 SoC.
Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
---
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index 5bb23e97cf33..d976380801e3 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -23,6 +23,7 @@ properties:
- mediatek,mt8173-dpi
- mediatek,mt8183-dpi
- mediatek,mt8186-dpi
+ - mediatek,mt8188-dp-intf
- mediatek,mt8192-dpi
- mediatek,mt8195-dp-intf
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188
2022-09-23 1:42 [PATCH] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188 liangxu.xu
@ 2022-09-23 11:16 ` Krzysztof Kozlowski
[not found] ` <ff6020d05962e202e917644b06eaa2cff7b2bb99.camel@mediatek.com>
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-23 11:16 UTC (permalink / raw)
To: liangxu.xu, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, jitao.shi
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group
On 23/09/2022 03:42, liangxu.xu@mediatek.com wrote:
> From: liangxu xu <liangxu.xu@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8188 SoC.
>
> Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
Where is the DTS? Where are driver changes?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188
[not found] ` <8cc90559-6e83-1b6d-2718-d26ceace6362@linaro.org>
@ 2022-09-26 12:12 ` liangxu.xu
2022-09-26 12:53 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: liangxu.xu @ 2022-09-26 12:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, liangxu.xu, chunkuang.hu, p.zabel, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt, matthias.bgg, jitao.shi
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group
On Mon, 2022-09-26 at 08:26 +0200, Krzysztof Kozlowski wrote:
> On 26/09/2022 04:53, liangxu.xu wrote:
> > On Fri, 2022-09-23 at 13:16 +0200, Krzysztof Kozlowski wrote:
> > > On 23/09/2022 03:42, liangxu.xu@mediatek.com wrote:
> > > > From: liangxu xu <liangxu.xu@mediatek.com>
> > > >
> > > > Add dt-binding documentation of dpi for MediaTek MT8188 SoC.
> > > >
> > > > Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
> > >
> > > Where is the DTS? Where are driver changes?
> > >
> > > Best regards,
> > > Krzysztof
> > >
> >
> > Hi Krzysztof:
> >
> > If you want to see the synchronous changes of dts and binding
> > files,
> > then I will attach this binding file changes when sending dts
> > later.
>
> Keep discussions public. You submit a lot of unused compatibles. I
> want
> users to come with them.
>
> >
> > The driver change of mt8188 reuses that of mt8195. The driver link
> > is
> > as follows:
> >
> >
https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/mediatek/mtk_dpi.c?id=48f4230642ee32a97ddf4be492838ce96089f040__;!!CTRNKA9wMg0ARbw!1Rd4E1huTfB_u1FjLXMIKlqMciGL24xsYInu1vg1z9c026cL0PiITklArLfwrMsi3x4$
> >
>
> Driver does not support that compa
> >
> > Best Regards,
> > LiangXu
> >
>
> Best regards,
> Krzysztof
Hi Krzysztof:
Can I modify it to the following form:
properties:
compatible:
oneOf:
- enum:
- mediatek,mt2701-dpi
- mediatek,mt7623-dpi
- mediatek,mt8173-dpi
- mediatek,mt8183-dpi
- mediatek,mt8186-dpi
- mediatek,mt8192-dpi
- mediatek,mt8195-dp-intf
- items:
- enum:
- mediatek,mt8188-dp-intf
- const: mediatek,mt8195-dp-intf
This means that mt8188 reuses mt8195, so there is no need to add
compatible to the driver.
Best Regards,
LiangXu
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188
2022-09-26 12:12 ` liangxu.xu
@ 2022-09-26 12:53 ` Krzysztof Kozlowski
2022-09-27 6:31 ` liangxu.xu
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 12:53 UTC (permalink / raw)
To: liangxu.xu, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, jitao.shi
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group
On 26/09/2022 14:12, liangxu.xu wrote:
>
> Can I modify it to the following form:
> properties:
> compatible:
> oneOf:
> - enum:
> - mediatek,mt2701-dpi
> - mediatek,mt7623-dpi
> - mediatek,mt8173-dpi
> - mediatek,mt8183-dpi
> - mediatek,mt8186-dpi
> - mediatek,mt8192-dpi
> - mediatek,mt8195-dp-intf
> - items:
> - enum:
> - mediatek,mt8188-dp-intf
> - const: mediatek,mt8195-dp-intf
>
> This means that mt8188 reuses mt8195, so there is no need to add
> compatible to the driver.
I am now confused. You send some bindings which do not match DTS and driver?
This has to stop... please post the bindings with the user - DTS and
optionally driver.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188
2022-09-26 12:53 ` Krzysztof Kozlowski
@ 2022-09-27 6:31 ` liangxu.xu
0 siblings, 0 replies; 5+ messages in thread
From: liangxu.xu @ 2022-09-27 6:31 UTC (permalink / raw)
To: Krzysztof Kozlowski, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt, matthias.bgg, jitao.shi
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
xinlei.lee
On Mon, 2022-09-26 at 14:53 +0200, Krzysztof Kozlowski wrote:
> On 26/09/2022 14:12, liangxu.xu wrote:
> >
> > Can I modify it to the following form:
> > properties:
> > compatible:
> > oneOf:
> > - enum:
> > - mediatek,mt2701-dpi
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> > - mediatek,mt8195-dp-intf
> > - items:
> > - enum:
> > - mediatek,mt8188-dp-intf
> > - const: mediatek,mt8195-dp-intf
> >
> > This means that mt8188 reuses mt8195, so there is no need to add
> > compatible to the driver.
>
> I am now confused. You send some bindings which do not match DTS and
> driver?
>
> This has to stop... please post the bindings with the user - DTS and
> optionally driver.
>
> Best regards,
> Krzysztof
>
Hi Krzysztof:
I'm very sorry that my patch made you confused, please ignore this
patch. I will wait for the patch of mt8188 dts to be ready and send it
together. In the later mt8188 dts, I will reuse the compatible of
mt8195.
Best Regards,
LiangXu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-27 6:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 1:42 [PATCH] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188 liangxu.xu
2022-09-23 11:16 ` Krzysztof Kozlowski
[not found] ` <ff6020d05962e202e917644b06eaa2cff7b2bb99.camel@mediatek.com>
[not found] ` <8cc90559-6e83-1b6d-2718-d26ceace6362@linaro.org>
2022-09-26 12:12 ` liangxu.xu
2022-09-26 12:53 ` Krzysztof Kozlowski
2022-09-27 6:31 ` liangxu.xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).